maemo.org - Talk

maemo.org - Talk (https://talk.maemo.org/index.php)
-   Development (https://talk.maemo.org/forumdisplay.php?f=13)
-   -   Clean way to add/remove LED patterns to mce.ini (https://talk.maemo.org/showthread.php?t=45614)

rambo 2010-03-06 19:54

Re: Clean way to add/remove LED patterns to mce.ini
 
Quote:

Originally Posted by rambo (Post 557304)
Added a very ugly copy-paste solution for vibra patterns (not even tested yet), this raises the code smellines factor so high that refactoring needs to be done Real Soon Now.

And it's done. Now adding support for anything that follows the same logic (one section [and config key] for enabling, another for the patterns themselves) as vibra/led patterns is going to be easy.

I'll promote the 0.4.0 version to extras testing when I get back from sauna.

ph5: we could probably add use of your more sophisticated pattern sanity checks but the live-test code should be a separate tool (and doing mce.ini update+mce daemon restart should probably be a small shell script first calling my tool and then if exit code is ok restart mce [this is what I intent to do on postinstall of the prog I needed this tool for...])

rambo 2010-03-12 20:37

Re: Clean way to add/remove LED patterns to mce.ini
 
Made some packaging adjustments and promoted as 1.0.0 to extras-testing.

Edit: Made announcement thread.


All times are GMT. The time now is 21:24.

vBulletin® Version 3.8.8