maemo.org - Talk

maemo.org - Talk (https://talk.maemo.org/index.php)
-   Applications (https://talk.maemo.org/forumdisplay.php?f=41)
-   -   [SFOS] Pure Maps (https://talk.maemo.org/showthread.php?t=100442)

rinigus 2018-08-23 14:31

Pure Maps
 
Pure Maps is a fork of WhoGo Maps. Its a full-featured map and navigation application allowing you to explore maps, search for addresses and points of interest, as well as assist with navigation.

Releases started from 1.2.0 to indicate continuity of the development of WhoGo Maps code. Release notes for the initial release will be given in a separate post.

Reasons for forking discussed in a separate thread, see post for details.

License: GPLv3
Source code: https://github.com/rinigus/pure-maps
Packaging and screenshots: OpenRepos https://openrepos.net/content/rinigus/pure-maps
Translations: https://www.transifex.com/rinigus/pure-maps

Acknowledgments

rinigus 2018-08-23 14:32

Re: 1.2.0
 
The first release (1.2.0) is out and let me go through the new features introduced into WhoGo Maps 1.1 code as a part of this release.

Before I will get into the details, I would like to thank Osmo again. Its an amazing code base, well thought through release process and its documentation. Thanks to that, making this release and setting up transifex page turned out to be faster than I anticipated, thank you Osmo!

For translators, if you are interested, please join the corresponding team. I don't think I can invite you automatically over.

This code was written over the last month and was focused on navigation aspects since I was preparing for rather long drives during vacation.

Map matching

OSM Scout Server provides DBus service that takes consecutive locations and matches them with the road. Obviously, you have to tell whether you are walking, cycling, or driving to match the corresponding road. Since it all works locally, you get the road matched coordinates fast (<100ms for the worst response time on my tests). In addition, you get current speed limit and the street name.

Speed limit and street name are now displayed by Pure Maps while you navigate. For that, enable "snap to road" on navigation page. You could also snap to road while you just walk around, this is done in Preferences. Personally, I am using it while navigating only.

Obvious requirement: installed and setup OSM Scout Server.


GUI styling in accordance with the map

In WhoGo Maps, the dark maps were supported rather poorly. Colors of GUI elements, route and location indicators were not in sufficient contrast with the map. Now, together with each map provider, we can set through its configuration file. This includes route, GUI elements and icons displayed on the map. Think of themes, one per each map. So, we can have separate "darker" themes for OSM Scout Night and Mapbox Traffic Night.

Those with better understanding of color schemes, please feel free to propose other combinations.


Navigation controls and zoom factor

Navigation controls got rearranged with the focus on the data that is relevant in this mode. In particular, you can see large speed indicator, estimated time of arrival, remaining time and distance. To make space, WhoGo Maps regular menu button is hidden during navigation and its functionality is provided by the navigation controls on the bottom of the screen (speed, remaining time and distance).

The arrangement has been made for landscape mode. I think it works quite well in this mode as well and I have driven bit more than a half of my travels with it. So, in addition to portrait, Pure Maps supports landscape as well.

When navigating, you could select now the zoom factor for a map. This zoom factor can be specified for each navigation mode (foot, car, bicycle, transit) separately. Thus, you could account to the difference in the distance between your eyes and the device at different modes. This zoom factor is applied only when you press start in navigation page and overwrites the zoom factor in Preferences. Defaults are 2 for car and bicycle, 1 for foot and transit.


Data shown during navigation

I have tried to reduce the amount of text shown as a part of the navigation instructions. Namely, instead of "Turn right to Street Such and ...", it will show just "Street Such" in big letters. Anyway, we already have an icon showing what to do and its just harder to read smaller text while driving. This is not always possible (sometimes street name is missing), then small text with the maneuver description is shown instead.

In addition, some routers, provide signs that are on the road before maneuver. This could include exit number, exit towards, and such. If this data is available, Pure Maps will show the sign with the corresponding text when you approach the maneuver (but should be well in time). So, this allows you to find the corresponding traffic sign on the road and follow it. Also, when the street is not available, but the sign data is, the sign data will be shown with ⇨ in front of it.

Its important to use a router that supports all these data. Valhalla has a full support by Pure Maps. MapQuest plugin has support for street names, but not signs. As I could see, MapQuest has some sign support, but its different from Valhalla and I haven't worked on it.

Valhalla is a default router of OSM Scout Server, so its users are covered. For online router provider, I have added Stadia Maps which provides routing via Valhalla. Osmo was not sure in their reliability, hence he didn't include it. However, let's test it in practice and see how good they are. So, I would urge all online router users to switch to that provider and use it. Please report back. If all is fine, I will consider setting them as a default due to full support by Pure Maps.


Search along route

OSM Scout Server allows to search along the route. So, when you have route selected, Nearby Venues search has an option "Search along the route" for OSM Scout provider. This allows you to search for POIs that are next to the route (distance specified by "radius" option on that page), like searching for cafes, fuel stations. In addition, you could search not from the start of the route, but from some other location along it (current location, for example). For that, specify relevant location as "Near" and enable "search starting from the reference point"


Misc

I have removed Cartago maps, since Osmo is considering taking it down. All API keys have been replaced with my keys, I should not have missed any. Finally, English Pirate voice instructions are back for Valhalla routers.

I did my best with testing this release, but since some changes were introduced recently as a part of the forking effort, there maybe some bonus bug lurking. Let me know and I'll do my best in fixing them.

carlosgonz 2018-08-23 20:54

Re: Pure Maps
 
tested *e-maps so speed motion-map in navigator is a lot improved.
also I do not get speed-limit Icon when I was on navigating the route, I do not know why?
also I do not get the window-emergent than is showing number of exit and name of street, I do not know why?
thanks @rinigus for being a coder supersonic : )

edit:

rinigus 2018-08-23 21:07

Re: Pure Maps
 
Quote:

Originally Posted by carlosgonz (Post 1547497)
tested *e-maps so speed-motion-map is a lot improved.
also I do not get speed-limit Icon when I was on navigating the route, I do not know why?
also I do not get the window-emergent than is showing number of exit and name of street, I do not know why?
thanks @rinigus to be a coder supersonic : )

Very good questions and remark regarding motion of the map.

Let's start with the remark: I have removed animation for moving the map while you navigate. As a result, we should get way smaller swing of position indicator on the display.

Speed limit signs: assuming that its enabled in navigation page (the one where you press Begin) and assuming that you have OSM Scout Server installed, maps downloaded:

this means that the road that you were traveling upon does not have speed limit info in OSM database. In Estonia, we have rather good coverage and these data are usually in the parts of the road where the speed is limited when compared to default. For example, if its 30km/h instead of 50km/h in the city. To fix it, start entering the data into OSM and I will pick it up when the imports are done.

Direction signs: again, its all about missing data in OSM. These are tricky, usually are on highways in the countries with the great coverage. I enjoyed them in Sweden and Denmark. In Estonia, haven't seen any on my routes. Again, start entering the data. See https://wiki.openstreetmap.org/wiki/...stination_sign and explore http://k1wiosm.github.io/checkautopista2/

Fellfrosch 2018-08-24 07:41

Re: Pure Maps
 
A further question. I have a XperiaX which is comparing it to Jolla1 quite loud. Anyway for some reasons the output of Pure Maps (and also WhoGo Maps) is quite soft-spoken.

I have searched for config files where I can raise the volume but haven't found one. In the config files of Pure Maps and OSM Scout Server there is no option. And for Mimic I haven't found config files in /home/nemo. Any chance to raise the Volume?

rinigus 2018-08-24 07:49

Re: Pure Maps
 
Quote:

Originally Posted by Fellfrosch (Post 1547511)
A further question. I have a XperiaX which is comparing it to Jolla1 quite loud. Anyway for some reasons the output of Pure Maps (and also WhoGo Maps) is quite soft-spoken.

I have searched for config files where I can raise the volume but haven't found one. In the config files of Pure Maps and OSM Scout Server there is no option. And for Mimic I haven't found config files in /home/nemo. Any chance to raise the Volume?

Its a frequent complaint. I'll add it into issues and will look into in time. Which language / TTS engine do you use?

Fellfrosch 2018-08-24 08:44

Re: Pure Maps
 
Hi rinigus thanxs for tracking this issue! Language is German and TTS engine should be Mimic as far as I remember. Problem is that I have installed mimic and piccots (don't know/remember why both) so as there is no possibility (at least I haven't found a setting) to set wich engine is used, I think I use that which Pure Maps prefer.

rinigus 2018-08-24 08:57

Re: Pure Maps
 
Quote:

Originally Posted by Fellfrosch (Post 1547514)
Hi rinigus thanxs for tracking this issue! Language is German and TTS engine should be Mimic as far as I remember. Problem is that I have installed mimic and piccots (don't know/remember why both) so as there is no possibility (at least I haven't found a setting) to set wich engine is used, I think I use that which Pure Maps prefer.

Nope, its picoTTS then. Mimic is EN only, unfortunately.

Kabouik 2018-08-24 09:25

Re: Pure Maps
 
The new features are looking great, I'm looking forward to try Pure Maps for my next trip. Thanks Rinigus.

There are a few things I am missing since Poor Maps, so I'll just list them here as you seem to be full of energy still. :p Please note that Poor Maps/WhoGo/Pure Maps is still my preferred native navigation application, so these points are fairly minor annoyances and this is only my opinion:

- I've always found the options confusing in the way they are organized. I think they need to be a bit better spatialized, i.e., make it obvious what is a sub-menu and what is a main page, whether the settings toggle are restricted to a sub-application (like Navigating) or the full application, whether they are permanent or just temporary for the current trip, etc. We have the Sailfish page indicator which is usually great and minimalist, but might be insufficient at times for complex applications like Pure Maps.

I don't have any clear suggestion in mind, I just find it hard to step back and clearly know in advance where to find a particular setting. I know the settings are already shown in the pages corresponding to the sub-menus, but I don't know, there is something I can't explain. Maybe it's just because there are many configuration options (which is good), or because items are big (which is good too for a navigation application), or because all items look the same regardless of whether they are settings, recent searches, POI categories, search options, router selection. I just feel it is hard to quickly figure out where is what, is that option on the same level as that one, and so on.

I am not a daily user, which makes it hard to really know the application by heart, but I feel it could be a bit more straightforward and be useful to all those like me that tend to use the application only when they are already panicking because they are going to be late somewhere.

- It is also difficult sometimes to know what does what and whether I should change that or that. I'm not familiar with the routers, and what you explained here for Stadia for instance, I would never have guessed. I don't even know why or if I should use another one in other situations. Same for maps, a keyword and a preview would help greatly, though default maps are clearly identified so I can go back to the "dev's suggestion" easily if I am not sure. Maybe it would be possible to better expose what features are offered by each specific options, and whether there are obvious cons. Restricting the available options depending on whether the map data in use is supplied by OSM Server or not would help too I suppose. Not sure if doable.

- I would love to be able to control OSM Server from the map application, something like:
Code:

Map data >
  Offline maps >
      Toggle on/off
      Download the maps you want to use offline >
        List of areas, and the download folder

- Sometimes it would be good to be able to show all POIs next to the current location without any specific preselected category, but instead category icons on the map. Or, at least, having the possibility to preselect several categories. There are so many different keywords for food for instance, you never know if selecting Restaurants will show everything or if what you are looking for would instead be in Food, French Restaurant, Belgian Restaurant, Bagel Shop, Bakery, Breakfast spot, Burger, Café, etc. I know the keywords are inherited from the search service being used (and again here pointers would be helpful to choose one), but they are all cluttered so sometimes selecting several would just be easier, without the fear of missing something. Maybe even allowing the user to save some searches, so that he can do a meta search with all food-related stuff and then just select this meta-type later without bothering with the million keywords from Foursquare again.

Anyway, as I said, it's the best native application in my opinion and I love it. Very excited by the new features you've added too, thanks a lot!

Fellfrosch 2018-08-24 09:25

Re: Pure Maps
 
Probably that's the reason, why I have both installed. Is flite supporting german? is it better than picoTTS?

rinigus 2018-08-24 09:51

Re: Pure Maps
 
Quote:

Originally Posted by Fellfrosch (Post 1547520)
Probably that's the reason, why I have both installed. Is flite supporting german? is it better than picoTTS?

not to my knowledge. you are stuck with picoTTS (kinda dead end, not developed anymore). maybe there is mimic update that supports German, but I don't know that. At the moment when I packaged it for SFOS, it did not.

Fellfrosch 2018-08-24 10:04

Re: Pure Maps
 
Quote:

Originally Posted by rinigus (Post 1547522)
not to my knowledge. you are stuck with picoTTS (kinda dead end, not developed anymore). maybe there is mimic update that supports German, but I don't know that. At the moment when I packaged it for SFOS, it did not.

No big bummer if it is a dead end or not. As long as it works of course :D

pichlo 2018-08-24 11:20

Re: Pure Maps
 
For the record, I like the idea of showing the speed limit only when it differs from default. It is a nice reminder to be extra careful.

A few initial observations, in the chronological order:
  1. The default setting seem a bit "wrong". Of course, de gustibus non disputandum est, but I would expect OSM Scout to be the default maps provider ;)
  2. Search and Navigation have their own provider settings. That is fine and some may find it useful, but I would expect the default to follow the setting of the maps provider and only diverge when the user explicitly tells it to.
  3. The application crashed on the first search. It took a while, as OSM Scout searches always do, so I took that opportunity to swipe to Home screen to check something and... Pure Maps took that opportunity to crash. Without saving my preferences. The second time I left it finish the search without disturbing it and it was fine.
  4. The landscape view seems a bit cluttered compared to portrait.
  5. I really like the view while navigating (driving). The tilt, rotation and especially the zoom (especially street names) are just perfect.

(Some if not most of the above are inherited from WhoGo Maps but I had been using WhoGo for so long that I had forgotten about them. Only starting a new application that had not the default changed yet to my liking has highlighted them.)

A few more advanced observations (again, none of them are new):
  1. In the Maps settings, what is the difference between OSM Scout Day and OSM Scout Day English?
  2. I don't think most people associate the difference between day and night with switching the map provider. I certainly don't. I would expect it to be a quick switch in a very prominent place. Something you can do quickly and easily while driving at 120 km/h on a motorway.
  3. The voice instructions told me to turn into A404, which it pronounced as "eigh-four-four" instead of "eigh-four-oh-four". This happened several times, so I was not hearing it wrong. Or maybe I was but consistently ;)
  4. I have mentioned this before in the WhoGo thread, but still... I found "drive for 4/10 of a mile" a bit odd. I think I finally figured out why. The SI system is wonderful not because it uses meters and kilograms, but because it is decimal. In contrast, the imperial system never uses the decimal notation. A foot is 12 inches, not 10. A mile is 1760 yards (4 furlongs, 80 chains), not 1000.
    Fractions work in a similar way: everything is in halves, thirds, quarters, eights and twelfths. Examples: 5/8", 2/3 mile... Cooking recipes mention 1/4 lb, 3/4 oz etc, unlike metric recipes with their 125 ml and 250 g (not 1/8 litre and 1/4 kg).
    "4/10 of a mile" simply does not fit this paradigm. I realize this is too much work for such a minor cosmetic thing so I am just throwing it in as a curious observation, not a change request.

All the above said, I really appreciate the work you put in it and the continued development of an independent navigation solution for Sailfish. Thank you!

pagis 2018-08-24 11:50

Re: Pure Maps
 
Quote:

Originally Posted by pichlo (Post 1547526)
[*]The application crashed on the first search. It took a while, as OSM Scout searches always do, so I took that opportunity to swipe to Home screen to check something and... Pure Maps took that opportunity to crash. Without saving my preferences. The second time I left it finish the search without disturbing it and it was fine.

I've experienced a very similar behaviour, after it crashed it could not start again. I did try few times to start it again but it was failing to start. I was not patient enough and restarted the phone (XperiaX). After that Pure Maps works fine.

pichlo 2018-08-24 12:04

Re: Pure Maps
 
Quote:

Originally Posted by pagis (Post 1547528)
(XperiaX)

Thank you for that. I forgot to say that mine is Jolla 1. So it seems that the low specs might not be the problem.

DrYak 2018-08-24 13:19

Re: Pure Maps
 
Hello,

having been using WhoGo maps predecessor for some time, I would like to know if Pure maps could be updated with... :

1. Destination-less navigation :
displaying the 3D autorotating tilted map like when navigating, but without needing to enter a destination. Basically: Being able to use the App as any dedicated satnav (Tomtom, Garmin, etc.) and get the useful informations from the navigation screen while simply driving around.

2. Foreign-language street names :

Currently when speaking out navigation instruction, the whole sentence string is passed as-is to the speech engine. Which usually gives rise to "To turn right into {completely garbled name }"
(e.g.: last week I was vacationing in Portugal, and the English text-to-speech engine was unable to meaningfully handle the local names).
It's probably going to be even worse if the street names aren't even written in latin script.

In case of using an engine that supports multiple language (like pico with english, german, etc.), would it be possible to flag the street names as the foreign language so that the correct "text-to-phoneme" processor handles it ?
I'm almost sure that the openstreet maps data has the necessary tagging for that.
The question is : does the speech engine support tags to mark different languages (I haven't been playing with TTS engine for at least a decade) ?

Alternative fallbacks would be to generate and concatenate the different parts separately (one separate job on the TTS engine for each separate language block) while using correct punctuation to avoid having the intonation mark an end of sentence.
(pico.say("Turn left into...", "en-US"); pico.say("Hautpbahnhofstrasse.", "de-DE"); )

Another alternative would be to check which speech engine exposes the text-to-phoneme step separately (the one I used I long time ago did), to concatenate them at the phoneme step, and hope that the final phoneme-to-audio engine will be able to manage all the diverse phonemes.

rinigus 2018-08-24 13:33

Re: Pure Maps
 
Thank you all for providing constructive feedback. I will go through it in multiple replies to keep it trackable.

Now, before I start, I want just to remind that there is some way before we hit 2.0 version :)

Let's start with the crashes.

On my device (onyx, 3GB RAM), I occasionally see it not starting from launcher (WhoGo and, later, Pure Maps). I will check next time whether app process from earlier start is still working. You could try to do the same (See corresponding discussion at WhoGo thread, around https://talk.maemo.org/showthread.php?t=100253&page=16)

In addition, sometimes, when starting from terminal, there are some exceptions thrown in what looks like C++ (Mapbox GL plugin, Mapbox GL itself, or something else, no idea).

However, I haven't experienced crashes while running. To me, it sounds like OOM kill and not much I can do about that.

Let's keep an eye on it and when you have some reproducible info, please open an issue.

Will go through other points separately...

Kabouik 2018-08-24 13:34

Re: Pure Maps
 
I really like both suggestions/requests.

rinigus 2018-08-24 15:55

Re: Pure Maps
 
Quote:

Originally Posted by Kabouik (Post 1547519)
There are a few things I am missing since Poor Maps, so I'll just list them here as you seem to be full of energy still. :p

Let's see for how long :) . Main thing is not to overcommit, so expect slower months in development as well. But the target is to compete with the best apps, not just the native ones.

Quote:

Originally Posted by Kabouik (Post 1547519)
- I've always found the options confusing in the way they are organized. I think they need to be a bit better spatialized, i.e., make it obvious what is a sub-menu and what is a main page, whether the settings toggle are restricted to a sub-application (like Navigating) or the full application, whether they are permanent or just temporary for the current trip, etc. We have the Sailfish page indicator which is usually great and minimalist, but might be insufficient at times for complex applications like Pure Maps.

I don't have any clear suggestion in mind, I just find it hard to step back and clearly know in advance where to find a particular setting. I know the settings are already shown in the pages corresponding to the sub-menus, but I don't know, there is something I can't explain. Maybe it's just because there are many configuration options (which is good), or because items are big (which is good too for a navigation application), or because all items look the same regardless of whether they are settings, recent searches, POI categories, search options, router selection. I just feel it is hard to quickly figure out where is what, is that option on the same level as that one, and so on.

I am not a daily user, which makes it hard to really know the application by heart, but I feel it could be a bit more straightforward and be useful to all those like me that tend to use the application only when they are already panicking because they are going to be late somewhere.

I am open for redesign, if needed. As a user, I think the only problem for me was to figure out what's Nearby for. Otherwise all was very clear. Obviously, now I find it all very intuitive and its hard for me to judge the user friendliness.

Note that application has grown over the years and so has the number of options. Expect more of them to appear (requests were/are flying in before and after the fork). So, one way to approach it, would be to think through the designs (you don't even need to program for it) and when all would seem to fit, we can approach redesigning the app.

Please try to remember the confusing parts next time and write them up, probably via opening an issue at Github and advertising it here. So, we could have separate discussion on it, see if others are confused similarly, and how to resolve it.

Quote:

Originally Posted by Kabouik (Post 1547519)
- It is also difficult sometimes to know what does what and whether I should change that or that. I'm not familiar with the routers, and what you explained here for Stadia for instance, I would never have guessed. I don't even know why or if I should use another one in other situations. Same for maps, a keyword and a preview would help greatly, though default maps are clearly identified so I can go back to the "dev's suggestion" easily if I am not sure. Maybe it would be possible to better expose what features are offered by each specific options, and whether there are obvious cons. Restricting the available options depending on whether the map data in use is supplied by OSM Server or not would help too I suppose. Not sure if doable.

I am planning to formulate recommended suggestions for online and offline services (offline seems to be without competition these days) and a way to simply switch between them.

Partially, we have so many online providers, since there is no one perfectly filling the bill. I am also going to add HERE as a provider, at least for search/routing. But, in the end, we will have to formulate the recommended providers and give a simple way to switch to them.

Quote:

Originally Posted by Kabouik (Post 1547519)
- I would love to be able to control OSM Server from the map application, something like:
Code:

Map data >
  Offline maps >
      Toggle on/off
      Download the maps you want to use offline >
        List of areas, and the download folder


Sorry, this is not going to happen with my help. I much more prefer unixy "stick to one task and do it well". OSM Scout Server was written to be client-independent and I would like to keep it that way. In theory, I can write DBus service that would allow you to configure it via clients, but it will take significant amount of time on the server side and on the client side to implement it. Taking into account other priorities, it looks to be postponed forever.

Quote:

Originally Posted by Kabouik (Post 1547519)
- Sometimes it would be good to be able to show all POIs next to the current location without any specific preselected category, but instead category icons on the map. Or, at least, having the possibility to preselect several categories. There are so many different keywords for food for instance, you never know if selecting Restaurants will show everything or if what you are looking for would instead be in Food, French Restaurant, Belgian Restaurant, Bagel Shop, Bakery, Breakfast spot, Burger, Café, etc. I know the keywords are inherited from the search service being used (and again here pointers would be helpful to choose one), but they are all cluttered so sometimes selecting several would just be easier, without the fear of missing something. Maybe even allowing the user to save some searches, so that he can do a meta search with all food-related stuff and then just select this meta-type later without bothering with the million keywords from Foursquare again.

This suggestion just opened few issues all around the place.

Icons on a map and search data are stored in different databases. If based on OSM, data comes from the same source, but handled via separate imports.

I would expect that Foursquare has some types predefined which should include different food shops/cafes/... But I never looked into it. Note that Foursquare maybe will become problematic due to their low allowed search limits. Let's see how good HERE is as a replacement in future.

I opened corresponding issues:

https://github.com/rinigus/pure-maps/issues/20
https://github.com/rinigus/osmscout-server/issues/279

rinigus 2018-08-24 16:53

Re: Pure Maps
 
Quote:

Originally Posted by pichlo (Post 1547526)
The default setting seem a bit "wrong". Of course, de gustibus non disputandum est, but I would expect OSM Scout to be the default maps provider ;)

I am planning to make separate defaults for online and offline services with a simple way. It will take some time to implement it properly.

Quote:

Originally Posted by pichlo (Post 1547526)
Search and Navigation have their own provider settings. That is fine and some may find it useful, but I would expect the default to follow the setting of the maps provider and only diverge when the user explicitly tells it to.

Well, Mapbox as a search provider and router will be probably just out of our reach due to its price. So, it makes sense to mix and match and use the best online provider for corresponding service. But there should be some easy way to set defaults and that I plan to add.

crashes discussed separately

Quote:

Originally Posted by pichlo (Post 1547526)
The landscape view seems a bit cluttered compared to portrait.

Ideas for making more space are welcome!

Quote:

Originally Posted by pichlo (Post 1547526)
I really like the view while navigating (driving). The tilt, rotation and especially the zoom (especially street names) are just perfect.

Maybe will be better in future, see below

Quote:

Originally Posted by pichlo (Post 1547526)
In the Maps settings, what is the difference between OSM Scout Day and OSM Scout Day English?

It shows names in English instead of local language, if possible. Makes a major difference in Japan, for example.

Quote:

Originally Posted by pichlo (Post 1547526)
I don't think most people associate the difference between day and night with switching the map provider. I certainly don't. I would expect it to be a quick switch in a very prominent place. Something you can do quickly and easily while driving at 120 km/h on a motorway.

Agreed, its just a current implementation. Situation is somewhat more different when you take navigation into account. See https://blog.mapbox.com/better-maps-...n-e2a41b9dc048 for example showing 2 map styles (one for planning navigation, one for navigating) for day and same for night. Right now, I just added zoom factor to switch between pre- and during navigation settings, but this can be refined further. Let's see if we get there.

Quote:

Originally Posted by pichlo (Post 1547526)
The voice instructions told me to turn into A404, which it pronounced as "eigh-four-four" instead of "eigh-four-oh-four". This happened several times, so I was not hearing it wrong. Or maybe I was but consistently ;)

It could be an issue with TTS engine, but can't help you there much. You could check what is spoken by running Pure Maps from terminal and then checking out what was said.


Quote:

Originally Posted by pichlo (Post 1547526)
I have mentioned this before in the WhoGo thread, but still... I found "drive for 4/10 of a mile" a bit odd. I think I finally figured out why. The SI system is wonderful not because it uses meters and kilograms, but because it is decimal. In contrast, the imperial system never uses the decimal notation. A foot is 12 inches, not 10. A mile is 1760 yards (4 furlongs, 80 chains), not 1000.
Fractions work in a similar way: everything is in halves, thirds, quarters, eights and twelfths. Examples: 5/8", 2/3 mile... Cooking recipes mention 1/4 lb, 3/4 oz etc, unlike metric recipes with their 125 ml and 250 g (not 1/8 litre and 1/4 kg).
"4/10 of a mile" simply does not fit this paradigm. I realize this is too much work for such a minor cosmetic thing so I am just throwing it in as a curious observation, not a change request.

I think it corresponds to Valhalla's issue filed at https://github.com/valhalla/valhalla/issues/874 . Please add your examples there to make it happen. All we do on Pure Maps side is saying what the router told us to say :)

rinigus 2018-08-24 17:39

Re: Pure Maps
 
Quote:

Originally Posted by DrYak (Post 1547533)
1. Destination-less navigation :

Added issue https://github.com/rinigus/pure-maps/issues/22 .

Quote:

Originally Posted by DrYak (Post 1547533)
2. Foreign-language street names :

Currently when speaking out navigation instruction, the whole sentence string is passed as-is to the speech engine. Which usually gives rise to "To turn right into {completely garbled name }"
(e.g.: last week I was vacationing in Portugal, and the English text-to-speech engine was unable to meaningfully handle the local names).
It's probably going to be even worse if the street names aren't even written in latin script.

In case of using an engine that supports multiple language (like pico with english, german, etc.), would it be possible to flag the street names as the foreign language so that the correct "text-to-phoneme" processor handles it ?
I'm almost sure that the openstreet maps data has the necessary tagging for that.
The question is : does the speech engine support tags to mark different languages (I haven't been playing with TTS engine for at least a decade) ?

Alternative fallbacks would be to generate and concatenate the different parts separately (one separate job on the TTS engine for each separate language block) while using correct punctuation to avoid having the intonation mark an end of sentence.
(pico.say("Turn left into...", "en-US"); pico.say("Hautpbahnhofstrasse.", "de-DE"); )

Another alternative would be to check which speech engine exposes the text-to-phoneme step separately (the one I used I long time ago did), to concatenate them at the phoneme step, and hope that the final phoneme-to-audio engine will be able to manage all the diverse phonemes.

To work properly, the router and TTS engine should understand each other and which parts are spoken in which language. As far as I remember when looking into it, Valhalla doesn't support it. But this can be asked for. I haven't done it, since we don't have TTS engine supporting it well anyway. On TTS side, its supposed to be coded by SSML.

IMHO, we should get a better TTS engine before worrying and hacking around very limited TTS support that we have. Mimic2 and others are developed, but I have not looked into them (https://github.com/MycroftAI/mimic2).

If someone wants to look into it and bring better TTS to the platform - that would be great!

rinigus 2018-08-26 04:16

Re: Pure Maps
 
Looks like someone used my keys for MapQuest for DDOS attack or some other use. While we are using "Open" versions of geocoder and router, someone used their regular geocoding and directions service. As a result, instead of ~150 calls by Pure Maps users, 16000 were done in addition wiping out monthly quota.

Osmo, MartinK: has something like it happened for you?

For now, please use some other service for routing and search.

I would prefer not to think about how to start securing the keys and focus on other aspects. Right now they are available as a part of the source, but that has been like that for other projects as well.

Fellfrosch 2018-08-26 06:47

Re: Pure Maps
 
Quote:

Originally Posted by pichlo (Post 1547526)
For the record, I like the idea of showing the speed limit only when it differs from default. It is a nice reminder to be extra careful.

I concur with that. Maybe that's nice as a option. But for me it's helpful to see the Speedlimit all the time it is available. Sometimes I just miss how fast I'm allowed to drive. Than a short glance on the Display helps me a lot.

rinigus 2018-08-26 07:03

Re: Pure Maps
 
Quote:

Originally Posted by Fellfrosch (Post 1547578)
I concur with that. Maybe that's nice as a option. But for me it's helpful to see the Speedlimit all the time it is available. Sometimes I just miss how fast I'm allowed to drive. Than a short glance on the Display helps me a lot.

Its option already. You could choose on navigation page (the one where you start navigation) whether you want to see it always, on exceeding, or never.

Fellfrosch 2018-08-26 08:36

Re: Pure Maps
 
Quote:

Originally Posted by rinigus (Post 1547579)
Its option already. You could choose on navigation page (the one where you start navigation) whether you want to see it always, on exceeding, or never.

Brilliant - as always :)

By the way you didn't really answer the question for a liberapay alternative, or have they found a solution for there problems meanwhile?

rinigus 2018-08-26 11:47

Re: Pure Maps
 
1.3.0 is out.

Its mainly polishing Valhalla's router and exposing its options, including, as requested, consideration of tolls and preference for the shorter route. In addition to earlier types of transportation, you could specify if you go by bus or high-occupancy vehicle. In future, after new OSM Scout Server maps are imported (coming in a week or two), motor scooter and motorcycle will be enabled too (relevant code is commented out right now).

Due to the lack of access to MapQuest for at least about a month now, I have set Stadia Maps as a default router. Use that if you prefer to use online routers. Anyway, Valhalla, the router behind Stadia, is supported the best by the application.

Translations have been updated - thank you all who have worked on it!

Quote:

Originally Posted by Fellfrosch (Post 1547580)
By the way you didn't really answer the question for a liberapay alternative, or have they found a solution for there problems meanwhile?

Not yet, let's see when it will reopen. Thanks!

otsaloma 2018-08-26 12:04

Re: Pure Maps
 
Quote:

Originally Posted by rinigus (Post 1547576)
Looks like someone used my keys for MapQuest for DDOS attack or some other use. While we are using "Open" versions of geocoder and router, someone used their regular geocoding and directions service. As a result, instead of ~150 calls by Pure Maps users, 16000 were done in addition wiping out monthly quota.

Osmo, MartinK: has something like it happened for you?

Ouch. I have noticed some "extra" use, of Mapbox if I recall correctly, basically stats showing use of some particular services that I hadn't shipped with Poor/WhoGo Maps. But that was such small scale use that I didn't bother to react to it. I haven't seen anything that could be called malicious.

But, I have thought about this, the obvious first thing to do is to revoke the key and get a new one. The next step would be to remove the keys from the source and when running qml/qmlscene, read them from environment variables and when building the RPM, write them from environment variables into JSON. The keys would still be installed as plain text, but getting them away from GitHub might help. Plain text files in RPMs and on devices could still be a problem, but that seems more difficult to solve.

rinigus 2018-08-26 12:34

Re: Pure Maps
 
Quote:

Originally Posted by otsaloma (Post 1547589)
Ouch. I have noticed some "extra" use, of Mapbox if I recall correctly, basically stats showing use of some particular services that I hadn't shipped with Poor/WhoGo Maps. But that was such small scale use that I didn't bother to react to it. I haven't seen anything that could be called malicious.

But, I have thought about this, the obvious first thing to do is to revoke the key and get a new one. The next step would be to remove the keys from the source and when running qml/qmlscene, read them from environment variables and when building the RPM, write them from environment variables into JSON. The keys would still be installed as plain text, but getting them away from GitHub might help. Plain text files in RPMs and on devices could still be a problem, but that seems more difficult to solve.

I did revoke the key, that's done. But yes, let's hope that the attack comes via Github source and not RPM. I'll look into how to inject the keys on RPM building. I was mainly thinking about sed and writing them into the code as a part of packaging. That would allow to keep the code as it is.

For users: I probably would have to do it relatively fast, just to be sure that some other vital service will not be lost. So, if suddenly all online services will stop working, please check whether there is a new version with new access codes is released.

MartinK 2018-08-26 16:18

Re: Pure Maps
 
Quote:

Originally Posted by rinigus (Post 1547576)
Osmo, MartinK: has something like it happened for you?

I don't think I've ever encountered something like this. But on the other hand, I don't think this is really avoidable in principle, especially for open source applications. Proprietary apps can try to obfuscate the API key somehow but that's not really doable for open source apps.

Indeed, one possibility is to inject the key at package build time, but each user will still have to get a copy as part of the package. Not to mention that ideally all the package build source artifacts & the build system would be open (as when building packages in Fedora) so there would be no place to hide the key - every user should be able to audit the package build and rebuilt the package, so needs all of the input artifacts.

For that reason I prefer "public" APIs that don't use API keys where possible and that apply IP base rate limiting (IIRC geonames and Nominatim work that way).

Another possibility is to add an option for users to add they own API keys, so they can get stuff working if the default one goes bad or even by default if you want to use an API with so low rate limit a shared key is unusable.

rinigus 2018-08-26 17:16

Re: Pure Maps
 
@MartinK: well said. For now, I have removed the keys from the source and made new ones for services that allow multiple keys. Keys are injected at rpm build time by a small script

Let's see if this will help and whether such accident was one-off.

rinigus 2018-08-26 20:53

Re: Pure Maps
 
Unless I am misreading it, we cannot add HERE to this application. Maybe someone more adequate in legal aspects can confirm/deny.

It looks like you cannot display search results from HERE on a map , if its not HERE tiles. This is based on https://legal.here.com/en-gb/terms/a...ble-use-policy , Layering and Modifications; https://developer.here.com/faqs, Licensing & Terms, Q7 [but Q9]

I think its illegal to use HERE routes in navigation apps. See https://legal.here.com/en-gb/terms/a...ble-use-policy, Application Restrictions , paragraph with "Route guidance applications"

Which means that I can drop plans on adding HERE as a service. Which is pity, they could have been great option for online service.

carlosgonz 2018-08-26 21:22

Re: Pure Maps
 
I think are new rules after BMW buyed HERE, no problem go forward . . .

otsaloma 2018-08-26 23:55

Re: Pure Maps
 
Quote:

Originally Posted by rinigus (Post 1547608)
Unless I am misreading it, we cannot add HERE to this application. Maybe someone more adequate in legal aspects can confirm/deny.

I think you're reading the old terms. That linked page says "Effective date: Monday, 4 June, 2018", while their new plans and terms were released in July/August. See the below link for newer terms ("Updated July 2018"). I haven't read it in full, but it seems much more liberal and even says "Section “Application Restrictions” as set out in the Acceptable Use Policy shall not apply."

https://developer.here.com/terms-and-conditions

I do remember reading that they lifted the ban on turn-by-turn apps, I'm not sure about commingling with non-HERE services.

rinigus 2018-08-27 06:43

Re: Pure Maps
 
Quote:

Originally Posted by otsaloma (Post 1547612)
I do remember reading that they lifted the ban on turn-by-turn apps, I'm not sure about commingling with non-HERE services.

Indeed, I missed that they canceled Application Restrictions. But the commingling restriction is still there, unfortunately. So, unless we make special HERE-only mode (map/search/nearby/route by HERE only), it cannot be used. For now, at least, I'll better focus on other things.

PamNor 2018-08-27 16:58

Re: Pure Maps
 
When driving and missing GPS signal inside a tunnel, is it possible to continue to show the marker based on the speed before GPS signal disappeared? Pure maps is the best navigating app. Thanks riginius.

rinigus 2018-08-27 17:43

Re: Pure Maps
 
Quote:

Originally Posted by PamNor (Post 1547637)
When driving and missing GPS signal inside a tunnel, is it possible to continue to show the marker based on the speed before GPS signal disappeared? Pure maps is the best navigating app. Thanks riginius.

Yes, Osmo wrote an absolutely brilliant application and its a joy to work on it.

As for what to do when GPS is lost: for my liking, its too many unknowns to predict position reasonably. It would matter only in the tunnels with the branches, but then we don't know which one you took. Don't forget, its frequent when we reduce speed in the tunnel as well. From GPS POV, you will loose the signal that will have to be restored - so after tunel we will have a short break as well.

The alternative would be to switch to car's speedometer, compass, and from these try to predict the motion. I think that could come one day to Qt, if it hasn't done yet, but for the car industry mainly.

So, unfortunately, its a bit too far at foreseeable future.

otsaloma 2018-08-27 18:18

Re: Pure Maps
 
Quote:

Originally Posted by rinigus (Post 1547615)
Indeed, I missed that they canceled Application Restrictions. But the commingling restriction is still there, unfortunately. So, unless we make special HERE-only mode (map/search/nearby/route by HERE only), it cannot be used. For now, at least, I'll better focus on other things.

Ah, they didn't update the acceptable use document, only revoked a part of it in the terms document. By my liberal reading, it seems similar to Mapbox now, that you could take HERE tiles and combine them with non-HERE overlays, but can't combine HERE geocoding, routing or venues with non-HERE maps.

carlosgonz 2018-08-27 19:21

Re: Pure Maps
 
. . .moved from osmscoutserver thread.
ok, i did not know what was already enabled, i knowing it was only available on the server, but thank u to let me know.
but i think there is something wrong here with the string below.
###navigation page###

- prefer shorter path
x
+ prefer shorter route

can someone with native english idiom confirm if is ok to use the word path to say routes of maps? rinigus? maemer? sailor? i am unclear about.

rinigus 2018-08-27 19:28

Re: Pure Maps
 
Quote:

Originally Posted by carlosgonz (Post 1547646)
. . .moved from osmscoutserver thread.
ok, i did not know what was already enabled, i knowing it was only available on the server, but thank u to let me know.
but i think there is something wrong here with the string below.
###navigation page###
- prefer shorter path
x
+ prefer shorter route
can someone with native english idiom confirm if is ok to use the word path to say routes of maps? rinigus? maemer? sailor? i am unclear about.

In general, review by native English speaker would be appreciated. Router options are now rather extensive an I was struggling with expressing the shades of preference, for example.

pichlo 2018-08-27 19:40

Re: Pure Maps
 
I am not a native English speaker but "shorter route" is definitely preferred over "shorter path".


All times are GMT. The time now is 17:46.

vBulletin® Version 3.8.8