View Single Post
gidzzz's Avatar
Posts: 282 | Thanked: 2,387 times | Joined on Sep 2011
#1654
Originally Posted by TomJ View Post
I'm not looking for a new menu entry, rather a button on (one of) the now playing screen(s). The most obvious use is in-car, so perhaps the in-car screen.
Thanks for clarifying, I forgot about QML views. For the car view it makes sense, I even have it somewhere on my to-do list.



Originally Posted by marmistrz View Post
This might be an option, provided that the dialog has the current song's tags after showing up.
Sure, this a natural thing to do.

Originally Posted by marmistrz View Post
Any reason apart from spending the time? What if someone did it on their own?
Yes, questionable gains at the cost of increased complexity. You can create your own plugin if you want -- drop it in "/opt/openmediaplayer/lyrics/" and OMP should pick it up.

Originally Posted by marmistrz View Post
Why? A couple of situations in which overrides are extremely useful:

Misnamed tags (on our or the provider's side). This includes the mentioned wikia problem, capital/small letters issues (no redirects here if name is Cyrillic [1]) or situations where the band changed its name.
The fix for bad tags is to fix the bad tags, not to accumulate overrides in a file. If the problem is on your side, edit the audio files. If the problem is on LyricWikia's side or it's moot, add a redirection for everyone to benefit. The broken example in [1] is against LyricWikia's page naming policy, as all words should start with a capital letter. I expect that song to work in the next release of OMP, because LyricWikia plugin will 1) capitalize names and 2) handle artist redirections. There will also be a search dialog to deal with refractory songs when in haste or lazy.

Originally Posted by marmistrz View Post
Live tracks. Suppose you have a track "I Am The Law (Live)". You can override it and have the lyrics for the real track loaded. Ideally, you would use a regular-expression-based override, but specifying the overrides in a per-track manner is better than no lyrics
Unfortunately there are lots of exceptions when it comes to lyrics and when you fix one thing, you can break another. An example would be a live recording having a hidden track at the end (http://lyrics.wikia.com/Incubus:Pardon_Me_%28Live%29). This is why there are multiple plugins and why I prefer to leave as much of name processing as possible to the provider -- if one fails, maybe others can get it right (in case of "I Am The Law (Live)" ChartLyrics works, returning lyrics for the studio version, because it has a search engine behind the API).

Originally Posted by marmistrz View Post
Another reason to use it: if we know that artist "Эпидемия" is in fact "Эпидемия_(Epidemia)" we load 1 page instead of 3 per track.
But each user would have to enter each such artist manually... and no, I am not going to ship a huge file with exceptions just to speed up LyricWikia.

Originally Posted by marmistrz View Post
The 3-page strategy would work great if being supplemental but on its own is merely a workaround.
No, it is an implementation of the LyricWikia page naming policy (which requires non-latin names to have a transliteration appended). Unfortunately it depends on the artist page having a redirection (although I believe the overwhelming majority has it), but the only automatic alternative seems to be the search box (which is risky, maybe a bit less with a good heuristic). A file with manual overrides is what I would call a workaround.
__________________
My Thumb mini-repository: http://gidzzz.mooo.com/maemo/.
 

The Following 5 Users Say Thank You to gidzzz For This Useful Post: