Thread: [ANNOUNCE] cbrPager lightweight comic book reader ported to Maemo
View Single Post
bge is offline bge
2008-09-24 , 03:02
Posts: 39 | Thanked: 66 times | Joined on May 2008 @ Montreal
#5
Originally Posted by Navi View Post
CBR, but I believe it'll happen with CBZs as well. This is pretty common, really. Evince used to do this before as well, 'til escaped '?', '|', '[', ']', '*', and '\' characters. The in this instance archive itself doesn't contain any of these characters, but the filename does. However, if something as simple as the filename will segfault the app, I'm worred that it'll segfault if the archive contains files with these characters as well.

Here's an archive that it'll segfault on:
http://www.mangashare.com/dl/Claymore_83/4028/
No, the code is actually careful with escaping filenames in the archive. But I'm quite surprised it does this, because it calls exec() directly, not system(). Maybe it behaves differently on the tablet.

The file looks like a cbr to me :-) For cbz, it won't do this, or at least, I'd be very surprised, as it doesn't use the command line at all. It embeds libunzip, so escaping should not even come into play.

I'm taking a look at the file right now.

Thanks!