Notices


Reply
Thread Tools
Posts: 885 | Thanked: 1,506 times | Joined on Jul 2010 @ Brittany, France
#2551
Is anyone interested in adopting and maintaining the great patch named No home carousel? Unfortunately, Cornerman is not using Sailfish anymore and he is looking for a maintainer: https://github.com/cornerman/sailfis...ment-403765302

This patch greatly improved (in my opinion) the user experience by restoring the "one swipe direction = one feature" spirit of early Sailfish versions before everything was made less consistent to conform with the introduction of partnerspace. It also improved the task switcher page by allowing quick close gestures on covers, and allowed swiping events in the Events page to remove them without changing page.

The comments on OpenRepos show how much this patch was appreciated, as it had a great impact on whole UI.
 

The Following 2 Users Say Thank You to Kabouik For This Useful Post:
Posts: 13 | Thanked: 18 times | Joined on Jan 2016
#2552
Originally Posted by coderus View Post
in the past email did not provide qml files, nowadays you can patch it. no need to mess systemwide plugins. please.
Ok. you are right.

@Markkyboy
Please discharge all changes made on file /usr/lib/qt5/qml/Sailfish/Silica/SilicaWebView.qml

Instead insert in file /usr/share/jolla-email/pages/HtmlViewer.qml
at around line 24 the following:

experimental.transparentBackground: true

that's enough, I tried it already.
 

The Following 2 Users Say Thank You to kneeli For This Useful Post:
Posts: 13 | Thanked: 18 times | Joined on Jan 2016
#2553
Originally Posted by Markkyboy View Post
Kneeli - your code shown for HtmlViewer.qml does not match what I have. I'm on SFOS 2.2.0.29 - which version are you using?
is in function
Code:
function setHtml(html) {
}
The sailfish mail app, does show many html mails in desktop view. Sometimes there even not zoom able, so unreadable at all.

In this function jolla-email does count the viewport, which seems to be buggy sincs version 1

I just defined a fix viewport with 300, which make nearly all html emails readable and shows them up in mobile view if there responsive.

Just replace this function with:
Code:
    function setHtml(html) {
        htmlBody = html
            experimental.customLayoutWidth = 300
        webView.loadHtml(htmlBody, "file:///usr/share/jolla-email")
        onScreen = true
    }
 

The Following User Says Thank You to kneeli For This Useful Post:
Markkyboy's Avatar
Posts: 269 | Thanked: 350 times | Joined on Oct 2012 @ Costa Blanca, Espaņa
#2554
Man, did I get in a muddle!, 35c here, fitting a new bathroom and compiling this patch, I am cooked!!

Anyway, I can now see the new changes that have been made, text looks a little too big in HTML emails, but is now very readable and plain emails also are now easily readable, see what you guys think!

As usual, all users try this second version at their own risk, it installs/applies & functions correctly on my ageing Jolla1;

https://www.dropbox.com/s/d66q7kojnc...oarch.rpm?dl=0
__________________
| Openrepos | T.J.C. |

Don't just sit there standing around, pick up a shovel and sweep up!
 

The Following 2 Users Say Thank You to Markkyboy For This Useful Post:
Posts: 13 | Thanked: 18 times | Joined on Jan 2016
#2555
Originally Posted by Markkyboy View Post
text looks a little too big in HTML emails
Here on my device, sometimes too big, mostly perfect. I have the XperiaX, I don't know how does it look an screens with more less resolution.
But anyhow, sometimes too big is far better as sometimes too tiny and not zoomable.

I just looked an you're patch, it seems all parts to be fine.

You're CSS file is well formatted. I changed mine, with you're version.
 

The Following 2 Users Say Thank You to kneeli For This Useful Post:
Posts: 13 | Thanked: 18 times | Joined on Jan 2016
#2556
Originally Posted by Markkyboy View Post
As usual, all users try this second version at their own risk, it installs/applies & functions correctly on my ageing Jolla1
ok. I had a small mistake, because my HtmlViewer.qml file was a little bit older

line 98 in you're patch file should be:
Code:
loadHtml(htmlBody, "file:///usr/share/jolla-email")
But I think it is also working with the "webView." before. You can try to increase the with from 300 to 480 and see, if the text size got smaller.
 

The Following 2 Users Say Thank You to kneeli For This Useful Post:
Markkyboy's Avatar
Posts: 269 | Thanked: 350 times | Joined on Oct 2012 @ Costa Blanca, Espaņa
#2557
Originally Posted by kneeli View Post
ok. I had a small mistake, because my HtmlViewer.qml file was a little bit older

line 98 in you're patch file should be:
Code:
loadHtml(htmlBody, "file:///usr/share/jolla-email")
But I think it is also working with the "webView." before. You can try to increase the with from 300 to 480 and see, if the text size got smaller.
Cool, yeah, I've just tried 480, for me it's a little too small, so I set at 400 instead, which looks pretty good on my Jolla1. Also line 98 changed to your specification.

Thanks for the code!

PATCH VERSION THREE:

https://www.dropbox.com/s/f5xbhgjczl...oarch.rpm?dl=0

I think this is ready to be offered on Openrepos
__________________
| Openrepos | T.J.C. |

Don't just sit there standing around, pick up a shovel and sweep up!

Last edited by Markkyboy; 2018-07-11 at 07:47.
 

The Following 2 Users Say Thank You to Markkyboy For This Useful Post:
Markkyboy's Avatar
Posts: 269 | Thanked: 350 times | Joined on Oct 2012 @ Costa Blanca, Espaņa
#2558
@coderus

Is this 'categories' list an exhaustive list of Patchmanager categories or are there more?

https://github.com/sailfishos-patches/patchmanager
__________________
| Openrepos | T.J.C. |

Don't just sit there standing around, pick up a shovel and sweep up!
 

The Following User Says Thank You to Markkyboy For This Useful Post:
coderus's Avatar
Posts: 6,129 | Thanked: 11,556 times | Joined on Nov 2011 @ Open Mobile Platform, Innopolis, Russia
#2559
Originally Posted by Markkyboy View Post
@coderus

Is this 'categories' list an exhaustive list of Patchmanager categories or are there more?

https://github.com/sailfishos-patches/patchmanager
this readme is outdated... check pm2 submit page
__________________
Twitter | Openrepos | GitHub | PayPal.Me
 

The Following User Says Thank You to coderus For This Useful Post:
Markkyboy's Avatar
Posts: 269 | Thanked: 350 times | Joined on Oct 2012 @ Costa Blanca, Espaņa
#2560
Originally Posted by coderus View Post
this readme is outdated... check pm2 submit page
and where might that be?, link please.
__________________
| Openrepos | T.J.C. |

Don't just sit there standing around, pick up a shovel and sweep up!
 

The Following User Says Thank You to Markkyboy For This Useful Post:
Reply

Tags
patchmanager, sailfish os

Thread Tools

 
Forum Jump


All times are GMT. The time now is 17:49.