Active Topics

 


Reply
Thread Tools
Posts: 2,225 | Thanked: 3,822 times | Joined on Jun 2010 @ Florida
#1
Okay, so on the meeting held on 2013-03-15, community member sixwheeledbeast brought up issues with the relatively well known packages speedpatch and batterypatch.

The criticisms against those particular packages were that:
  • speedpatch installs itself by modifying syspart in a way that's not uninstalled cleanly (because it didn't use the standard syspart as the reference for what to make it after uninstall), and that it has caused people to have to reflash in the past.
  • batterypatch automatically overclocks a device that installs it without any warning to a user
  • batterypatch is coded in such a way that it does not properly check for the more recent power-kernel versions, even though it depends on that package
  • One or both (I don't recall) of them violates the Debian packaging guidelines (which Maemo packages are supposed to adhere to).

After some searching since the meeting, I am personally uncertain if all of those criticisms are completely up to date - speedpatch's changelog says since version 3.5 that it does a safe uninstall and uses syspart configs provided by Nokia, for instance. So, obviously, a more in-depth look should always be conducted before doing anything to any package.

But the main point is, does the community think either the tech staff volunteers, or the Council, (or the Board, in theory), should act to remove packages that do clearly have the potential for damage from the Extras and perhaps Extras-Testing repositories? (Extras-Devel would be left untouched either way.)

[The Council's position as of two weeks ago was a unanimous yes for removing harmful packages from both Extras and Extras-Testing.]

[Full disclosure: Although this question is from the entire Council, the text in this post was written by me alone without the proof-reading usually done by other Council members.]
 

The Following 19 Users Say Thank You to Mentalist Traceur For This Useful Post:
Ken-Young's Avatar
Posts: 387 | Thanked: 1,700 times | Joined on Feb 2010 @ Cambridge, MA, USA
#2
I believe such packages should be removed. I was bitten by the unexpected overclocking after installing batterypatch. I didn't realize overclocking was happening until many days after I installed batterypatch, and I certainly didn't expect that program to change the clock rate, so it took me quite a while to figure out what had happened. I was not pleased....
 

The Following 9 Users Say Thank You to Ken-Young For This Useful Post:
Dave999's Avatar
Posts: 7,074 | Thanked: 9,069 times | Joined on Oct 2009 @ Moon! It's not the East or the West side... it's the Dark Side
#3
Removal from extras would be nice. Would also be nice with some logs of what is removed and why.

Let's remove some stuff
__________________
Do something for the climate today! Anything!

I don't trust poeple without a Nokia n900...
 

The Following 4 Users Say Thank You to Dave999 For This Useful Post:
uros's Avatar
Posts: 151 | Thanked: 108 times | Joined on Jan 2011 @ Belgrade, Serbia
#4
I think no. Mainly because is good thing to have choice. If any user wish to install those particular packages, this user have choice and responsibility.
 

The Following 2 Users Say Thank You to uros For This Useful Post:
Posts: 2,290 | Thanked: 4,133 times | Joined on Apr 2010 @ UK
#5
I would like to point out the original report is here.
http://talk.maemo.org/showpost.php?p...postcount=3325

I made my feelings clear in the meeting.

Personally I don't see why they can't be removed completely. Leaving the sources in garage for potential future maintainers to repair.

IMO these should be treated separately from simple broken packages like "theme-customizer" for example, due to the nuture of the damage that can be caused.
__________________

Wiki Admin
sixwheeledbeast's wiki
Testing Squad Subscriber
- mcallerx - tenminutecore - FlopSwap - Qnotted - zzztop - Bander - Fight2048 -


Before posting or starting a thread please try this.
 

The Following 4 Users Say Thank You to sixwheeledbeast For This Useful Post:
Estel's Avatar
Posts: 5,028 | Thanked: 8,613 times | Joined on Mar 2011
#6
This may have some sense only, if clear guidelines what is *not* allowed in package, would be prepared. Otherwise, packages with many influential people biased against them (batterypatch is good example here - heck, I'm also biased against it ) and/or bad fame, could get removed/harassed without thorough testing of actual state.

As said, I'm not fan of packages like speedpatch/batterypatch, but just like MentalistTraceur, I'm not sure about their actual state. Also, people tend to mix battery patch and speedpatch into one thing (AFAIK, only one of them does overclocking - 2nd is wrong [as in useless], but not harmful, either).

I certainly *don't* want to see packages removed, without good report about what serious and obligatory rules they've broken - especially, after perceiving first hand, how "objective" some people in tech staff are.

Originally Posted by Mentalist Traceur View Post
[*]One or both (I don't recall) of them violates the Debian packaging guidelines (which Maemo packages are supposed to adhere to).
That, for example, is very bad reason to remove package - it should result in kindly asking maintainer to fix packaging, at most. Otherwise, we should remove 1/3 of extras, including some really good things from various "community heroes" here.

/Estel
__________________
N900's aluminum backcover / body replacement
-
N900's HDMI-Out
-
Camera cover MOD
-
Measure battery's real capacity on-device
-
TrueCrypt 7.1 | ereswap | bnf
-
Hardware's mods research is costly. To support my work, please consider donating. Thank You!
 

The Following 8 Users Say Thank You to Estel For This Useful Post:
XiliX's Avatar
Posts: 356 | Thanked: 217 times | Joined on Aug 2010 @ Netherlands
#7
I think the council should be allowed to do so, if they can prove a package is dangerous/malicious.

And even though people are warned about the dangers of installing from the extras-devel and extras-testing repositories, intentionally dangerous software should be removed.

In case the maintainer of a package is aware of faults in his or her software, as described by Mentalist Traceur, and does not take action to fix this, these packages should be removed aswell.
 

The Following 6 Users Say Thank You to XiliX For This Useful Post:
Posts: 2,290 | Thanked: 4,133 times | Joined on Apr 2010 @ UK
#8
Originally Posted by Estel View Post
...Also, people tend to mix battery patch and speedpatch into one thing (AFAIK, only one of them does overclocking - 2nd is wrong [as in useless], but not harmful, either).
...
I certainly *don't* want to see packages removed, without good report about what serious and obligatory rules they've broken - especially, after perceiving first hand, how "objective" some people in tech staff are.
...
That, for example, is very bad reason to remove package - it should result in kindly asking maintainer to fix packaging, at most.
Not 100% true, modifing syspart is equally as harmful.

My report linked above has been done after testing both packages and checking it's sources. I had to reflash due to device unstablity. This is not a anti-foopackage issue.

The maintainer is not capable of repairing the package in this instance.
__________________

Wiki Admin
sixwheeledbeast's wiki
Testing Squad Subscriber
- mcallerx - tenminutecore - FlopSwap - Qnotted - zzztop - Bander - Fight2048 -


Before posting or starting a thread please try this.
 

The Following 3 Users Say Thank You to sixwheeledbeast For This Useful Post:
Estel's Avatar
Posts: 5,028 | Thanked: 8,613 times | Joined on Mar 2011
#9
sixwheeledbeast, you're last person, that I would expect to have bad will, when it comes to testing packages.

Nevertheless, I think that it would be more fair to re-define rules for packages (what can't be in repos and why), announce them, and give maintainers 2-3 weeks for fixing. Then, start mercilessly executing those rules, be it against *patch or any other super-popular and respected package.

This way, it should be fair for everyone, without any sneaking suspicions about anyone being biased against anything.

/Estel

// Edit

And yes, I'm kinda playing advocatus diaboli here - I think that the more clear rules applying to *everyone* we will setup now (and tweak, if experience taught us about need to), the better future will be
__________________
N900's aluminum backcover / body replacement
-
N900's HDMI-Out
-
Camera cover MOD
-
Measure battery's real capacity on-device
-
TrueCrypt 7.1 | ereswap | bnf
-
Hardware's mods research is costly. To support my work, please consider donating. Thank You!

Last edited by Estel; 2013-03-29 at 20:06.
 

The Following 3 Users Say Thank You to Estel For This Useful Post:
Posts: 3,074 | Thanked: 12,960 times | Joined on Mar 2010 @ Sofia,Bulgaria
#10
No matter that (maybe) I am the most anti-crappatch person here, I have to unpleasantly agree with Estel - we should modify the rules for extras in such a way that maintainers to be given a chance to fix/withdraw broken packages from extras. Along with a definition of what is "fubar package in extras". And if they don't fix/withdraw them, there should be a procedure to be followed.

I think extras-testing should not be changed, IMO it is fine.
__________________
Never fear. I is here.

720p video support on N900,SmartReflex on N900,Keyboard and mouse support on N900
Nothing is impossible - Stable thumb2 on n900

Community SSU developer
kernel-power developer and maintainer

 

The Following 7 Users Say Thank You to freemangordon For This Useful Post:
Reply

Tags
community, dangerous, extras, harmful, repositories


 
Forum Jump


All times are GMT. The time now is 15:18.