maemo.org - Talk - Panucci Podcast and Audiobook Player

Take a look at this commit:
https://github.com/xerxes2/panucci/c...c595afe2c93f66

If that doesn't work we have to try something else. Does the playlist window work well on gtk? I'd rather avoid setting a fixed size on the playlist window if possible.

No, your fix isn't working. And yes, it works at gtk.

But I played with the code a little bit. And it works fine if I set the Main window as Stacked Window, too. :)

So I added this lines to qtmain.py somewhere around line 68 (not inside "if platform.MAEMO:"):

Code:

        if platform.FREMANTLE:

            self.main_window.setAttribute(QtCore.Qt.WA_Maemo5StackedWindow)

Works now! :)
I could create tomorrow at home a patch if you need one. But I guess the change is small enought that you could fix it without... :)

xerxes2

2011-03-26 07:52

Re: Panucci Podcast and Audiobook Player

Quote:

Originally Posted by Helmuth (Post 975865)

Confirmed. :)

I promised I should fix it didn't I? And you shouldn't make promises you cant keep, that's my fourth rule. :)

Quote:

Originally Posted by Helmuth (Post 975865)

Code:

        if platform.FREMANTLE:

            self.main_window.setAttribute(QtCore.Qt.WA_Maemo5StackedWindow)

Works now! :)
I could create tomorrow at home a patch if you need one. But I guess the change is small enought that you could fix it without... :)

Hey that's great thanks man. Finally this annoying bug got squashed. So if I understand correctly this commit was all that was needed:
https://github.com/xerxes2/panucci/c...402d6d9c890b0a

Many thanks to thp too who found that attribute, he's my Maemo hero. :D Now if not anything blows up I'd say that it's time for 0.99.1.

Luigi Brosse

2011-03-28 09:04

Re: Panucci Podcast and Audiobook Player

Well go for it because the actual behavior of 0.99 is disturbing at the moment ;o)

And thanks for taking care of Panucci!

xerxes2

2011-04-04 20:45

Re: Panucci Podcast and Audiobook Player

Thanks man, and yeah I'm sorry I introduced that bug with gpodder. New package will be up in a few days, hopefully, thp had a hdd crash so he has to reinstall some stuff before he can upload a new package.

Helmuth

2011-04-04 22:37

Re: Panucci Podcast and Audiobook Player

Oh, thats sad to hear. :(
Hope he had a good backup... but nevertheless a pain in the [...]

Perhaps, if this will need a bit more time, I found a new bug:

Put 4 Files at your Playlist, delete File 3 (using File manager or gpodder) while you're playing File 4
Seek back until you're inside File 3 and Panucci will stop working

I guess he is trying to load the deleted file.
I searched the correct place to put in a try / catch. But while searching I realized that skipping the missing file would be a better idea. But then I have to deal with the playlist and perhaps break more things. Could you try to look into it?

xerxes2

2011-04-04 22:54

Re: Panucci Podcast and Audiobook Player

Hmm, what do you think should happen? It seems to work fine for me. The file doesn't exist so it can't play it. Perhaps it should play the next possible file? It's late now but I promise I'll look into it tomorrow.

Helmuth

2011-04-04 23:15

Re: Panucci Podcast and Audiobook Player

Hm, okay. I tested this using the gtk version. All Buttons are disable in this case. So I have to close panucci. Perhaps I could select a other track using the playlist. But I haven't tested it.

Could the Qt version work different?

A error message (A Hildon infobar for 3 seconds) would be nice in such a case... :rolleyes:

nuknuk

2011-04-04 23:46

Re: Panucci Podcast and Audiobook Player

check MGH 454 it works

xerxes2

2011-04-05 18:37

Re: Panucci Podcast and Audiobook Player

Quote:

Originally Posted by Helmuth (Post 981975)

Perhaps, if this will need a bit more time, I found a new bug:

Put 4 Files at your Playlist, delete File 3 (using File manager or gpodder) while you're playing File 4
Seek back until you're inside File 3 and Panucci will stop working

There was indeed a bug as the playlist tried to load the non existing file, thankfully it was easy to fix. The playlist now checks if the file exists on disk before it tries to load it and if not it sends an eof signal on the player. Hmm, should perhaps check what happens if you remove the currrently played file too ...

Edit: If you remove the currently played file it just keeps on playing it so that's good.

Helmuth

2011-04-05 19:43

Re: Panucci Podcast and Audiobook Player

Quote:

Originally Posted by xerxes2 (Post 982588)

Hmm, should perhaps check what happens if you remove the currrently played file too ...

Edit: If you remove the currently played file it just keeps on playing it so that's good.

Ah, thanks for fixing! :)
Unable to check at the moment. But I will believe you. ;)

Your observation is fine for Linux systems. The ext3 File system deletes open files completely as soon as the last application has closed the file. If a application is accessing a file while you delete it, only the entry at the directory table is getting deleted and the file itself is on the waiting list. Other applications are unable to find the file. So it seems that the file is already gone. In the moment the application closes the file the file gets completely deleted and no second before.

At windows it is different. You're simply unable to delete opened files. You got a error message. And if you don't get a error message the accessing application will crash. ;) (but this works very well since Windows XP)

Please correct me if my own observation and comparsion between Windows and Linux is wrong. It's how it feels here at my experience. And English is not my native language so it's hard for me to describe. :)

If you're unable to understand my short essay just read this: It works great! :D

All times are GMT. The time now is 03:18.

Page 50 of 57

Show 40 post(s) from this thread on one page

vBulletin® Version 3.8.8