maemo.org - Talk

maemo.org - Talk (https://talk.maemo.org/index.php)
-   Applications (https://talk.maemo.org/forumdisplay.php?f=41)
-   -   New FBReader build in Extras-Devel (https://talk.maemo.org/showthread.php?t=36857)

Rob1n 2010-11-29 14:50

Re: New FBReader build in Extras-Devel
 
I've uploaded 0.12.10-24 (for Diablo and Fremantle) which stores the margin and padding CSS values separately and adds them together to calculate the spacings.

The source code changes can be downloaded from here.

I'll look to push this to extras-testing at the end of the week, so please let me know if you find any issues before then.

fms 2010-11-29 19:21

Re: New FBReader build in Extras-Devel
 
Hello, Rob1n

It looks like your latest updated royally screwed up .epub reading, and some other formats too, most likely. Most of the time, the latest FBReader just shows empty screen. Page display also appears to be broken: it only changes after 2-4 page flips in a row.

Whatever you have done to that code broke it. Please, consider rolling back =)

WhiteWolf 2010-11-29 20:12

Re: New FBReader build in Extras-Devel
 
Excellent application.

Vote for the addition of the ability to create bookmarks, notes, and to copy when full screen without leaving it with the keyboard closed...

Rob1n 2010-11-29 20:24

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by fms (Post 885738)
Hello, Rob1n

It looks like your latest updated royally screwed up .epub reading, and some other formats too, most likely. Most of the time, the latest FBReader just shows empty screen. Page display also appears to be broken: it only changes after 2-4 page flips in a row.

Whatever you have done to that code broke it. Please, consider rolling back =)

I'll have a look into this - the few books I tested worked perfectly, but I've now found one that exhibits the same issues you've reported. I'll see why they're getting the incorrect settings and upload a fixed version shortly.

TinaHolmboe 2010-11-29 20:34

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by Rob1n (Post 885552)
I've tracked down the issue. FBReader uses the margin & padding settings for the same variable, so your zero padding values are overriding the margin values. Removing the padding values from the CSS fixes this issue. I'll have a dig into this further - adding the values would probably be a better solution, but means dealing with unit conversion.

I'm ... speechless. Ok. Will you add an upstreams bug, or shall I?

Thanks for looking into this, tho. Atleast I've got a workaround until the ... problem can be fixed.

Rob1n 2010-11-29 20:57

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by Rob1n (Post 885776)
I'll have a look into this - the few books I tested worked perfectly, but I've now found one that exhibits the same issues you've reported. I'll see why they're getting the incorrect settings and upload a fixed version shortly.

Okay, 0.12.10-25 uploaded which fixes this (it was failing to check the values had actually been set before using them, so was picking up invalid values).

Quote:

Originally Posted by TinaHolmboe (Post 885782)
I'm ... speechless. Ok. Will you add an upstreams bug, or shall I?

Thanks for looking into this, tho. Atleast I've got a workaround until the ... problem can be fixed.

I'll add the bug at some point - I'm planning on adding bugs/feature requests for all the work I've done.

I've fixed this in the latest uploaded version though (0.12.10-25) though, so there should be no need for a workaround. It should be available in the repository shortly.

ForeverYoung 2010-11-30 05:02

Re: New FBReader build in Extras-Devel
 
I have a FR: something like checking/filtering read books in library.
And maybe some list of read books, with date, comments, etc.

paulkoan 2010-11-30 05:13

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by Rob1n (Post 883701)
I'm not sure that's a bug - I think that's all it's intended to do.

So "always use my css" doesn't apply to font-size? That is disappointing, as the epub font size must presume a DPI. The epub book I have, the font is too small, so I can increase it in base, but then I have to go and decrease it for those books that respect the font size setting in other books.

ejasmudar 2010-11-30 06:33

Re: New FBReader build in Extras-Devel
 
Hey, I just downloaded FBreader after a long time due to all this activity in this thread. And I must say, I am impressed. I expect that FBReader will soon be one amoung my top used apps with Comix, gPodder and www2sms. But a few gripes (bugs?):
The fact that direct dictionary search is included is brilliant. But when text selection is activated, the swiping to turn pages does not work. They only select the text. So could it be possible to have small next/previous page buttons like in Comix?
Once again thanks.

Rob1n 2010-11-30 09:09

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by ForeverYoung (Post 885985)
I have a FR: something like checking/filtering read books in library.
And maybe some list of read books, with date, comments, etc.

I'll have a look, but I think the latter part will mean database changes, making it incompatible with the upstream version, which I'd rather not do. You could use the tags to flag read books though, and there's some code done for filtering (though it doesn't look to have been completed yet) which I may be able to do something with. That should allow you to check & filter read books.

Quote:

Originally Posted by paulkoan (Post 885990)
So "always use my css" doesn't apply to font-size? That is disappointing, as the epub font size must presume a DPI. The epub book I have, the font is too small, so I can increase it in base, but then I have to go and decrease it for those books that respect the font size setting in other books.

Well, the option is "Always use my font" which I think just overrides the font-family. I'll have a look though - it ought to be possible to override the font size as well.

Quote:

Originally Posted by ejasmudar (Post 886011)
Hey, I just downloaded FBreader after a long time due to all this activity in this thread. And I must say, I am impressed. I expect that FBReader will soon be one amoung my top used apps with Comix, gPodder and www2sms. But a few gripes (bugs?):
The fact that direct dictionary search is included is brilliant. But when text selection is activated, the swiping to turn pages does not work. They only select the text. So could it be possible to have small next/previous page buttons like in Comix?
Once again thanks.

There's no reason these couldn't go on the toolbar, but that'll have to wait until I've finished writing the menu/toolbar customisation app. In the meantine, you can use the volume buttons to change pages, or enable the "single tap" option for dictionary search (though you then need to be careful of where your swipe starts, as I think the search is triggered on press rather than on release).

TinaHolmboe 2010-11-30 09:53

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by Rob1n (Post 885802)
I've fixed this in the latest uploaded version though (0.12.10-25) though, so there should be no need for a workaround. It should be available in the repository shortly.

Excellent. I'll test it as soon as my N900 finds the repositories again :( In the meantime, big thanks for lots of good work :)

TinaHolmboe 2010-12-01 14:03

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by TinaHolmboe (Post 886096)
Excellent. I'll test it as soon as my N900 finds the repositories again :( In the meantime, big thanks for lots of good work :)

It works perfectly - thank you! :)

Very few things remain before I, personally atleast, consider FBreader THE single best ebook reader out there ...

Rob1n 2010-12-02 15:27

Re: New FBReader build in Extras-Devel
 
I've uploaded an initial version of the FBReader Customiser. This currently allows customising the main and popup menus - I'll be adding toolbar customisation at some point but that's a bit more complex, so I need to plan it through first.

The initial view allows selection of which menu to edit:
http://www.robinhill.me.uk/maemo/FBR...miser_main.png

You're then presented with a list of Available actions (sorted alphabetically), and a list of currently Selected actions (in the order they'll be shown on the menu). The labels are the same as those shown in the menus in FBReader (and it should pick up the localised versions, but I've not tested that), so some of them may be context-sensitive (and some actions may not work at all):
http://www.robinhill.me.uk/maemo/FBR...miser_edit.png

You can scroll through the items using the normal touch scrolling, and move items between the lists (or reorder the Selected actions) using drag & drop. In order to get these two functions working together, a drag has to move sideways initially.

The main menu is limited to 14 actions (which is all that can fit on the screen), after which it won't allow you to drag any more from the Available list. The popup menu isn't limited at all.

Press the Save button to write out the custom configuration file. To revert to the default configuration, just remove the appropriate xml file (popupmenu,xml or menubar.xml) from ~/.FBReader (I'll add this functionality into the app for a future release).

Let me know if you find any issues, or have any suggestions. I'm not entirely happy with the current interface, so this may well be changing in a future version, but I thought I'd let you have what I've done currently (it's functional at least).

extendedping 2010-12-02 16:08

Re: New FBReader build in Extras-Devel
 
not in repos yet, this will be cool.

jstokes 2010-12-02 16:30

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by Rob1n (Post 865198)
The Diablo version doesn't support keeping the display on (I've not found any code for that yet)

http://pastebin.com/i45WPfzw

Now I can read Wallander in peace :-)

extendedping 2010-12-02 19:58

Re: New FBReader build in Extras-Devel
 
are my repos screwed up or is there normally a delay? I got some other updates but not my fav app fbreader...every update is like a little xmas gift to me:)

Rob1n 2010-12-02 20:27

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by extendedping (Post 887851)
are my repos screwed up or is there normally a delay? I got some other updates but not my fav app fbreader...every update is like a little xmas gift to me:)

There's no update to FBReader - it's a separate app. I probably need to sort out the dependencies actually, and make sure FBReader actually does get installed with it!

Rob1n 2010-12-02 20:36

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by jstokes (Post 887681)
http://pastebin.com/i45WPfzw

Now I can read Wallander in peace :-)

Thanks for that :)

I've just uploaded version 0.12.10-26 for Diablo only. I've implemented it slightly differently from your patch (there's actually a logic flaw in there, where calling enable twice will disable it). The screen is also only kept on if FBReader is the foreground application.

Rob1n 2010-12-03 16:08

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by Rob1n (Post 885584)
I'll look to push this to extras-testing at the end of the week, so please let me know if you find any issues before then.

As I've not heard of any major issues, I've pushed 0.12.10-25 to extras-testing now. Please run through the QA checklist and vote for it to get through to the main repository.

extendedping 2010-12-03 16:23

Re: New FBReader build in Extras-Devel
 
I take it this is not the fremantle version? I don't see it.

Rob1n 2010-12-03 16:27

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by extendedping (Post 888519)
I take it this is not the fremantle version? I don't see it.

That should have been 0.12.10-25, not 0.25

009N 2010-12-05 13:09

Re: New FBReader build in Extras-Devel
 
1 Attachment(s)
Quote:

Originally Posted by Rob1n (Post 879811)
Are you on Diablo? I've had several reports of this on Diablo and need to look into why it might be happening. I've not heard of any issues on Fremantle though.

Mine is fremantle (n900). Loading library seems much improved. However this is what I see and I am at a lost.
Maybe I missed out some important info as I didn't have the energy to follow the technical discussions closely.
Anyway thanks for your effort. It's an awful lot of work. I am sure many many users feel the same way. :D

[EDIT] sorry forgot to upload the screenshot. Here it is. Thanks!

Rob1n 2010-12-05 14:09

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by 009N (Post 889738)
Mine is fremantle (n900). Loading library seems much improved. However this is what I see and I am at a lost.

Does it hang on the same book every time? If so, can you send me a copy (maemo at robinhill.me.uk)?

009N 2010-12-05 14:37

Re: New FBReader build in Extras-Devel
 
No. Opening books is fine. But I just see a long unstructured list of books readable by the app without knowing what they are (pls. see the screenshot above).

ps Just for the record. My ePub books converted by Calibre look great! :D

Rob1n 2010-12-05 15:13

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by 009N (Post 889789)
No. Opening books is fine. But I just see a long unstructured list of books readable by the app without knowing what they are (pls. see the screenshot above).

That's odd - even for books without metadata it should at least show a title. If you click to "Edit information" on one of those, what does it show?

009N 2010-12-05 15:54

Re: New FBReader build in Extras-Devel
 
I was testing with the html version NET Bible (I have no religion though :D ). The archive is pretty big with many small files. The app treats each subdirectory as an individual book.
Switching to basic library view and turning off the book paths make things much smoother.
How to clean up the existing libarary database?

Rob1n 2010-12-05 22:33

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by 009N (Post 889837)
I was testing with the html version NET Bible (I have no religion though :D ). The archive is pretty big with many small files. The app treats each subdirectory as an individual book.

Ah, right. Yes, it doesn't handle sets of HTML documents very well. You could try using Calibre to convert them to an epub.

Quote:

Originally Posted by 009N (Post 889837)
Switching to basic library view and turning off the book paths make things much smoother.
How to clean up the existing libarary database?

Clean up how? The library view should only show those books currently in the library path, though I think it retains details in the database. If you want to clear those out, the easiest option is to delete the library database files (~/.FBReader/books.*) and let it recreate them - that'll lose any customisation you've done to the library though. Otherwise you can use sqlite3 to edit the database directly.

Rob1n 2010-12-06 22:09

Re: New FBReader build in Extras-Devel
 
I've uploaded 0.12.10-27 (for Diablo and Fremantle). The only change is support for handling svg image tags for EPub book covers (they were already supported within the books, just not for the cover). This support is a bit of a kludge though - the cover processing is done entirely separately from the main book processing, so there doesn't seem to be an easy way to make use of the same code. It works fine for the Baen epubs though, which is where I've noticed the issue.

The source code changes can be downloaded from here.

Rob1n 2010-12-13 10:03

Re: New FBReader build in Extras-Devel
 
I've uploaded 0.12.10-28 (for Diablo and Fremantle).

This fixes the issue reported where the application exits directly from the book info screen. This was caused by the changes I'd put in to prevent reloading a book if it's reopened from the library. Fixing the issue required only a minor change, but pointed out a more significant issue. As this code is also used from the book info screen, additional checks needed to be added in order to reload the book if any critical changes have been made (i.e. language/encoding). This new version handles this, avoiding the bulk of the reloading work in the normal case, but doing a full reload when required.

The source code changes can be downloaded from here.

ddwalker 2010-12-22 19:49

Re: New FBReader build in Extras-Devel
 
I'm having trouble to read chinese epub files fbreader. The same file works in dorian. Any idea how I should set it up to read chinese? Thanks.

rlpowell 2011-01-03 21:55

Re: New FBReader build in Extras-Devel
 
My n900 is broken and I probably won't be getting another one, but I just wanted to say thank you so much for making this available; it made my n900 experience way better.

As a random comment, I would have really liked a way to get fbreader to read out via espeak.

Thanks again.

-Robin

extendedping 2011-02-26 16:59

Re: New FBReader build in Extras-Devel
 
Hi I do love this app. Would there be any way to have a sort by last read in the library? I open in library mode and would love to just have the books appear in the order they were last used (kind of like a compromise between opening last read and opening in library mode).

Thanks again, as the above poster says the updates to fbreader are one of the great points of the n900.

geneven 2011-02-27 09:18

Re: New FBReader build in Extras-Devel
 
Does tap to scroll work? I checked the checkbox in Preferences. I need an easy way to do next page with the keyboard open, because I often use Ctrl-Bksp to switch windows. I use HiveMind together with FBreader for great note taking.

ejasmudar 2011-02-27 10:38

Re: New FBReader build in Extras-Devel
 
Right now, the open in doctionary is not working for me. Even when it was working, the implementation is not right IMO. ie, the text selection is way too accurate. ut when using fingers, we usually just want complete words to get selected to open in dictionary. What happens now is that when we select, even partial words from either side of the word we wish to select are also getting selected.

Is there any way to change this text selection behaviour so that it automatically selects complete words? For reference, you can check out the default behaviour of MobiPocket reader.
Thanks!

Rob1n 2011-02-27 14:56

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by extendedping (Post 955965)
Hi I do love this app. Would there be any way to have a sort by last read in the library? I open in library mode and would love to just have the books appear in the order they were last used (kind of like a compromise between opening last read and opening in library mode).

Thanks again, as the above poster says the updates to fbreader are one of the great points of the n900.

I'll have a look - it depends on what information is stored on previous books read. Currently, from the toolbar in the book view, you can access a list of the previous 10 books read, but I'm not sure whether that's all that's kept or not.

Quote:

Originally Posted by geneven (Post 956339)
Does tap to scroll work? I checked the checkbox in Preferences. I need an easy way to do next page with the keyboard open, because I often use Ctrl-Bksp to switch windows. I use HiveMind together with FBreader for great note taking.

Tap scroll works fine for me, though I'd recommend using the "Scroll by dragging" option instead, as it's less prone to accidents. Is it not scrolling at all for you?

Quote:

Originally Posted by ejasmudar (Post 956372)
Right now, the open in doctionary is not working for me. Even when it was working, the implementation is not right IMO. ie, the text selection is way too accurate. ut when using fingers, we usually just want complete words to get selected to open in dictionary. What happens now is that when we select, even partial words from either side of the word we wish to select are also getting selected.

Is there any way to change this text selection behaviour so that it automatically selects complete words? For reference, you can check out the default behaviour of MobiPocket reader.

I'll have a look, but I can't promise anything - it depends on just how the selection is done. The code's mostly cross-platform so I need to be careful of how I do any touch-specific stuff.

geneven 2011-02-28 09:08

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by Rob1n (Post 956549)
Tap scroll works fine for me, though I'd recommend using the "Scroll by dragging" option instead, as it's less prone to accidents. Is it not scrolling at all for you?

Oh, I didn't understand what new options I got when I turned on tap to scroll. I agree with you about using scroll by dragging.

I think I'm set up the way I want now, thanks.

ejasmudar 2011-02-28 09:47

Re: New FBReader build in Extras-Devel
 
With text selection and scroll by dragging enabled, I can only get text selection to work. I don't think both of these options are compatible.

Rob1n 2011-02-28 11:34

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by ejasmudar (Post 957139)
With text selection and scroll by dragging enabled, I can only get text selection to work. I don't think both of these options are compatible.

Well, no - there's no way for these two functions to work at the same time (similarly for tap scrolling and tap to open in dictionary). I'll have a look at making the settings toggle each other to prevent them being set at the same time though.

daperezg 2011-03-13 12:26

Re: New FBReader build in Extras-Devel
 
I have FBreader 0.10.7-1 on a Maemo OS2008 and I would like to use to search/read reference and translation dictionaries

I know that FB Reader can only read mobipocket format without DRM, however, my ebooks have no DRM or I think so.

One is wikipedia(Spanish), and in theory since it is not a commercial book I think it shouldn't have DRM, when I try to add to library, FBreader gives the message "Couldn't open: Unsupported compresion method"

In other thread someone told me about one python script to remove the compression, do you think the problem is the compression? is the script mobihuff.py?

The same error happen when Oxford ALD, and Chambers dictionaries

On the contrary I could open one mobipocket english dictionary (Wordnet) and I can access to the data. However, there isn't a search index, to search in the topics. I can use the normal search function but to search in the entire content instead of topics but it is useless.

Are you using FBreader with these kind of data?
any way to have wikipedia in a maemo OS2008?

sgiessl 2011-06-08 07:48

Re: New FBReader build in Extras-Devel
 
I, too, would like to second my appreciation for the work on FBReader.

Quote:

Originally Posted by ejasmudar (Post 956372)
Right now, the open in doctionary is not working for me.

The "Open in dictionary" feature does not work for me as well. When I select text and call the menu action, simply nothing happens (not even a message or console output stating that there was an error). I have both mstardict (configured with a few working dictionaries) and fbreader installed, and mstardict is running fine in standalone mode. mstardict integration is enabled in fbreader's configuration. (This is about fbreader on the n900)

Is this supposed to work?


All times are GMT. The time now is 16:52.

vBulletin® Version 3.8.8