maemo.org - Talk

maemo.org - Talk (https://talk.maemo.org/index.php)
-   Applications (https://talk.maemo.org/forumdisplay.php?f=41)
-   -   New FBReader build in Extras-Devel (https://talk.maemo.org/showthread.php?t=36857)

fms 2009-12-15 08:54

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by DaSilva (Post 428603)
*vote* Or should there be a link instead of the text?

I think we can do without a formal voting thread for this particular topic. Simply vote by leaving "I support tap scrolling by default" or "I do not support tap scrolling by default" messages in this thread.

DaSilva 2009-12-15 09:05

Re: New FBReader build in Extras-Devel
 
Ok, then I meant "I support tap scrolling by default" :D

cgarvie 2009-12-15 09:08

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by fms (Post 428585)
Not a bug.


No, only top/bottom. You have to configure Tap Scrolling in a special manner (it does not work out of the box on Maemo).

Please, vote here to enable tap scrolling by default

I can do that but only if people say it is ok with them.


not got my N900 yet but this is one of my Key Apps as i read about 2hours a day of ebooks

Oh i am defintly for Tap scroling . I would much prefer left right tap though, as if were reading in landscape mode the top/bottom half just seem a bit thin and i could see me easily pressing wrong half

DaSilva 2009-12-15 09:19

Re: New FBReader build in Extras-Devel
 
Yeah, left and right makes more sense because it would be like the pages in a real book.

Higgsboson 2009-12-15 10:03

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by epilido (Post 427339)
qwerty, fms

Dpkg purge and reinstall through application manager fixed the problem...

E.

I'd like to point out that you need to purge libzlibrary, not just fbreader to fix this issue. That fact is not initially clear (to a linux neophyte such as myself) to someone reading this thread.

After reading this thread, I tried to just purge fbreader and then reinstall. No luck.
So I again purged fbreader, then libzlibrary, then reinstalled fbreader 0.10.7-5 via the app mgr. (btw, I assume the H in HAM stands for Hildon?)
And now the volume keys can scroll. I do alot of reading on my phones, so a good ebook reader is a killer app as far as I'm concerned.

sierrafoxtrot 2009-12-15 11:04

Re: New FBReader build in Extras-Devel
 
firstly, thanks guys for porting this and integrating the patches, i can finally read on the tube again!!!

secondly, i would vote for tap scrolling by default, if i could only get it to bloody work with my finger!!

not sure what i'm doing wrong, if i have set it to 200ms, and the scrolling on finger tap checkbox is unticked, i can tap with the stylus and fingernail to scroll just fine (top/bottom half), but the pad of my finger does nothing. however, if i tick it, i can no longer scroll by tapping at all; stylus, fingernail and pad all won't work. any ideas? it'd be nice not to have to use a fingernail tap to scroll when i just use the pad of my thumb

two other questions, i notice on page 1 of this thread, qwerty12's screenshot has an extra prefs tab labelled Maemo, this doesn't seem to be on mine. also, how do i purge libzlibrary? my volume scrolling works, but thought i should find out, just in case.

aim1159 2009-12-15 11:14

Re: New FBReader build in Extras-Devel
 
vote for tap scrolling by default

fms 2009-12-15 11:59

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by sierrafoxtrot (Post 428748)
secondly, i would vote for tap scrolling by default, if i could only get it to bloody work with my finger!!

I will set it up so that it works.

Quote:

two other questions, i notice on page 1 of this thread, qwerty12's screenshot has an extra prefs tab labelled Maemo, this doesn't seem to be on mine.
Missing Maemo tab is a bug I introduced into _5 release. It will be fixed in _6.

qwerty12 2009-12-15 18:36

Re: New FBReader build in Extras-Devel
 
1 Attachment(s)
Attached diff contains some minor fixes to FBReader; only "major" thing is that I fixed the fullscreen button from escaping FBreader's window (Conny, please see my e-mail).

fms 2009-12-15 18:50

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by qwerty12 (Post 429333)
Attached diff contains some minor fixes to FBReader; only "major" thing is that I fixed the fullscreen button from escaping FBreader's window (Conny, please see my e-mail).

Thanks, integrating tonight.

Also, I have got a question to Conny:
The FBReader guys are asking if they can use your code in a possible closed-source version of FBReader. They are now only accepting patches whose authors agree to these terms. Conny, are you ok with it?

fms 2009-12-15 20:49

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by qwerty12 (Post 429333)
Attached diff contains some minor fixes to FBReader; only "major" thing is that I fixed the fullscreen button from escaping FBreader's window (Conny, please see my e-mail).

After applying fixes to Conny's widget, it shows up all black, rather than transparent. Is this a bug, somehow related to the widget no longer having text view as its parent?

qwerty12 2009-12-15 20:54

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by fms (Post 429514)
After applying fixes to Conny's widget, it shows up all black, rather than transparent. Is this a bug, somehow related to the widget no longer having text view as its parent?

****, ****, ****... I only tested that on a program that had a black background (due to the theme) and did not realize it had lost its transparency. Will force my test program to use a white background (duh) and look further into it tomorrow...

tirtawn 2009-12-15 22:43

Re: New FBReader build in Extras-Devel
 
I support tap scrolling by default

fms 2009-12-17 07:39

Re: New FBReader build in Extras-Devel
 
FBReader 0.10.7-7 is now in Extras-devel. I had to disable qwerty's fix to the overlay widget, as there are issues with it. Otherwise, tap scrolling has been configured and enabled by default, Maemo config tab fixed, and the new app icon borrowed from Gnome. Post your experiences with the new version here.

mtjioe 2009-12-17 08:34

Re: New FBReader build in Extras-Devel
 
Hi fms, keep up the good work!
the tapscrolling doesn't work after the update?? I tried tapping everywhere on the screen with my pointer and finger but for some strange reason it doesn't scroll.

Furthermore I would like to be able to open/read an 500 mb chm file, but at this moment fbreader skips this file in my library, it even doens't show up. On the fbreader board it was suggested to activate virtual memory, but on the n900 this is always available or not???

GeneralAntilles 2009-12-17 08:47

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by fms (Post 427500)
This is kinda troubling though. If I release the next version with zlibrary in libs, will HAM upgrade from the current one?

If the current package installed isn't in user/*, yes.

This is a small issue, I think, since FBReader is in Extras-devel and most users haven't installed it. Those who have can probably manage an uninstall/reinstall or apt-get upgrade.

GeneralAntilles 2009-12-17 08:49

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by Higgsboson (Post 428684)
I'd like to point out that you need to purge libzlibrary, not just fbreader to fix this issue. That fact is not initially clear (to a linux neophyte such as myself) to someone reading this thread.

Or just apt-get upgrade. . . .

twaelti 2009-12-17 08:54

Re: New FBReader build in Extras-Devel
 
Thanks for the great work FMS! This made my day :-) Finally, my beloved FBReader is usable again - +/- scrolling just rocks and makes the N900 a perfect ebook.

(can confirm 10.7-7 tap scrolling doesn't work)*

*Edit: Wrong. It works. Just not yet as I wish. See later posts

fms 2009-12-17 09:19

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by GeneralAntilles (Post 431551)
If the current package installed isn't in user/*, yes. This is a small issue, I think, since FBReader is in Extras-devel and most users haven't installed it. Those who have can probably manage an uninstall/reinstall or apt-get upgrade.

Actually, I am planning to promote it to -Testing as soon as possible, so if this becomes an issue, it has to be resolved ASAP. Please, confirm that update from _5 to _7 went without a hitch.

fms 2009-12-17 09:20

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by twaelti (Post 431561)
(can confirm 10.7-7 tap scrolling doesn't work)

Works-for-me. Please, test it again:

1. Use a large file that actually scrolls (i.e. bigger than one screen)
2. Use default config values that _7 comes with.
2. Strongly tap with your nail at the top/bottom of the text view and see if it scrolls.

fms 2009-12-17 09:22

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by mtjioe (Post 431541)
Furthermore I would like to be able to open/read an 500 mb chm file, but at this moment fbreader skips this file in my library, it even doens't show up.

Sorry, but I am not even sure if .chm files are supported. You may be better off reading that complete MSDN knowledge base on your Windows desktop...

FormerPalmUser 2009-12-17 09:26

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by twaelti (Post 431561)
Thanks for the great work FMS! This made my day :-) Finally, my beloved FBReader is usable again - +/- scrolling just rocks and makes the N900 a perfect ebook.

(can confirm 10.7-7 tap scrolling doesn't work)

Hello,
maybe you can give me an advice - how to configure the +/- scrolling ?
In my case only the volume is controlled with the +/- Buttons!

best regards
Dirk

fms 2009-12-17 10:30

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by FormerPalmUser (Post 431597)
maybe you can give me an advice - how to configure the +/- scrolling ? In my case only the volume is controlled with the +/- Buttons!

You have to remove FBReader and install it from scratch.

FormerPalmUser 2009-12-17 10:50

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by fms (Post 431658)
You have to remove FBReader and install it from scratch.

Thanks, I'll try it at home this evening

mtjioe 2009-12-17 12:00

Re: New FBReader build in Extras-Devel
 
Hi,

tapscrolling does work, kind off, I have to press really hard?? What about scrolling with the cursor keys.

CHM files are supported and are supported very well. Even the index is supported. I have several large files which open without problems, and even with pictures! Just tables are not displayed.
The 500 mb chm file is a medical database which I need for my work, it would be wonderful if that could be opened...

fms 2009-12-17 12:34

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by mtjioe (Post 431741)
tapscrolling does work, kind off, I have to press really hard??

Good.

Quote:

What about scrolling with the cursor keys.
Up/Down will scroll, Left/Right will browse through reading history inside the same document.

Quote:

The 500 mb chm file is a medical database which I need for my work, it would be wonderful if that could be opened...
You should not expect this much from something this small. :)

sierrafoxtrot 2009-12-17 12:48

Re: New FBReader build in Extras-Devel
 
i can confirm tapscrolling works, but only if scroll on finger tap only is *unchecked* and with a fingernail or stylus, not with finger. however, this behaviour was already existent in the 10.7-5 build.

also, i noticed that the maemo tab in prefs is still missing.

nb: i upgraded the package instead of uninstall/reinstall, should i have done that instead?

twaelti 2009-12-17 13:09

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by fms (Post 431591)
Works-for-me. Please, test it again:
2. Strongly tap with your nail at the top/bottom of the text view and see if it scrolls.

Indeed - technically it works, sorry :o
However, from a usability standpoint, please:
  • If possible: less pressure should be needed - is it not implemented as a normal click event?
  • Enlarge the area that acts as scroll button. It's MUCh to small right now. IMHO, as long as no other touch options are present in fullscreen view, you could give top half to backscroll and bottom half to next page.
And while I'm at it with blatant-FMS-Christmas-holiday-ignoring wishlist: preload next page for doublebuffering and faster page switch :D

fms 2009-12-17 13:25

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by sierrafoxtrot (Post 431792)
i can confirm tapscrolling works, but only if scroll on finger tap only is *unchecked* and with a fingernail or stylus, not with finger. however, this behaviour was already existent in the 10.7-5 build. also, i noticed that the maemo tab in prefs is still missing. nb: i upgraded the package instead of uninstall/reinstall, should i have done that instead?

You apparently have not upgraded the package. Uninstall. Reinstall.

fms 2009-12-17 13:27

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by twaelti (Post 431827)
If possible: less pressure should be needed - is it not implemented as a normal click event?

Possible at the cost of several hours needed to figure out how it works. So, not unless I have time.

Quote:

Enlarge the area that acts as scroll button. It's MUCh to small right now. IMHO, as long as no other touch options are present in fullscreen view, you could give top half to backscroll and bottom half to next page.
It is already done this way.

Quote:

preload next page for doublebuffering and faster page switch :D
See item #1, multiply time by a factor of 5, estimate how likely it is to happen.

sierrafoxtrot 2009-12-17 14:17

Re: New FBReader build in Extras-Devel
 
Thanks fms, properly updated now, with Maemo tab and nice new icon. Tapscrolling works, but only with fingernail. Don't know if it's just me, but it feels more responsive than the last build. Ticking Scroll on Finger Tap Only still disables all tapscrolling.

tirtawn 2009-12-17 16:44

Re: New FBReader build in Extras-Devel
 
Still new on this.

Does not work with me.
These are the steps to uninstall fbreader but mine does not work yet
1. install rootsh
2. go to terminal
3. sudo gainroot
4. dpkg --purge fbreader
5. dpkg --purge libzlibrary
6. reinstall fbreader (found the latest version .7)
7. when opening the fbreader after that
my last book is automaically open (the config file definitely is still there).

finger tap not working.

Question:
How can I remove the config file ?

is there any steps that I missed ?

fiferboy 2009-12-17 16:51

Re: New FBReader build in Extras-Devel
 
In xterm: rm -rf /home/user/.FBReader

tirtawn 2009-12-17 18:29

Re: New FBReader build in Extras-Devel
 
For those who have problems:

1. install rootsh
2. go to terminal
3. sudo gainroot
4. dpkg --purge fbreader
5. dpkg --purge libzlibrary
6. rm -r ~/.FBReader
7. reinstall fbreader (found the latest version .7)


Finger tap should works. (It works better with stylus).

You need to press it "HARD" and hold it for 1 second at the bottom right. (for a test).

And you will see the tap now works.

After that, you can play around and see how "hard" you need to press the screen to make it works :).


great application, Look forward for a new update :).

fms 2009-12-17 18:51

Re: New FBReader build in Extras-Devel
 
Looks like I will have to put zlibrary into user/libs again. This mess cannot be allowed to continue.

qwerty12 2009-12-17 19:05

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by fms (Post 431492)
I had to disable qwerty's fix to the overlay widget, as there are issues with it.

This appears to be a problem [the solution] on Maemo 5. (It has been discussed on -developers twice.)

Conny and I decided to workaround it by disabling/enabling the widget depending on if the HildonWindow (or any widget derived from it, like HildonStackableWindow) is on the screen.

I don't have the time now to do a diff, but the following in he-fullscreen-button.c should do it:
Code:

static void
fullscreen_button_on_is_topmost_changed (GObject *object G_GNUC_UNUSED,
                                                GParamSpec *property G_GNUC_UNUSED,
                                                gpointer data)
{
        HeFullscreenButton *self = HE_FULLSCREEN_BUTTON (data);

        if (hildon_window_get_is_topmost (HILDON_WINDOW(self->parent_window))) {
                if (gdk_window_get_state (GTK_WIDGET (self->parent_window)->window) & GDK_WINDOW_STATE_FULLSCREEN) {
                        fullscreen_button_enable (self);
                }
        }
        else {
                fullscreen_button_disable (self);
        }
}

[Before return self in he_fullscreen_button_new()]
    if (HILDON_IS_WINDOW(parent_window)) {
        g_signal_connect (parent_window, "notify::is-topmost",
            G_CALLBACK(fullscreen_button_on_is_topmost_changed), self);
    }

[After g_signal_handlers_disconnect_by_func (self->parent_window, fullscreen_button_destroy, self);]
g_signal_handlers_disconnect_by_func (self->parent_window, fullscreen_button_on_is_topmost_changed, self);

Oh, fullscreen_button_disable/fullscreen_button_enable are not called fullscreen_button_disable/fullscreen_button_enable in the castrated he-fullscreen-button.c for FBReader...

If you need to see the full code, check out the hildon-extras SVN project; I just committed rev. 13.

GeneralAntilles 2009-12-17 19:12

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by fms (Post 432265)
Looks like I will have to put zlibrary into user/libs again. This mess cannot be allowed to continue.

Which is exactly why you shouldn't but it back in user/*. :)

It's like a virus, currently some users are infected but that number is relatively small. It needs to be stopped now before users beyond Extras-devel get exposed.

Besides, it can't go into Extras with a lib in user/*.

fms 2009-12-17 20:23

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by GeneralAntilles (Post 432296)
Which is exactly why you shouldn't but it back in user/*. It's like a virus, currently some users are infected but that number is relatively small. It needs to be stopped now before users beyond Extras-devel get exposed. Besides, it can't go into Extras with a lib in user/*.

Ok, here is what we have determined so far:

1. It cannot go to user/libs because it is "like a virus".
2. It cannot go into libs because then the users cannot update the master package properly.
3. Fixing #1 requires some community gatekeepers to stop considering it a virus, which is not going to happen because it is "like a virus".
4. Fixing #2 requires changes to HAM, which are not going to happen because Nokia controls HAM distribution (even although its source may be open).

So, based on the stuff above, what is the solution for promoting library dependencies into Extras and making them upgrade through HAM?

fms 2009-12-17 20:25

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by qwerty12 (Post 432284)
This appears to be a problem [the solution] on Maemo 5. (It has been discussed on -developers twice.) Conny and I decided to workaround it by disabling/enabling the widget depending on if the HildonWindow (or any widget derived from it, like HildonStackableWindow) is on the screen. I don't have the time now to do a diff, but the following in he-fullscreen-button.c should do it:

Thanks, this should be enough for me. Integrating.

Rob1n 2009-12-17 20:29

Re: New FBReader build in Extras-Devel
 
My understanding is that the only people affected by #2 are those who currently have it installed in user/libs.


All times are GMT. The time now is 00:12.

vBulletin® Version 3.8.8