maemo.org - Talk
Page 6 of 11 « First 45 6 78 Last »
Show 40 post(s) from this thread on one page

maemo.org - Talk (https://talk.maemo.org/index.php)
-   Applications (https://talk.maemo.org/forumdisplay.php?f=41)
-   -   New FBReader build in Extras-Devel (https://talk.maemo.org/showthread.php?t=36857)

Rob1n 2010-11-02 09:29
Re: New FBReader build in Extras-Devel
 
Quote:
Originally Posted by geneven (Post 860415)
In the latest version of FBreader I can't copy and paste text. You can turn on allow text selection in Preferences but you used to be able to choose copy selection to clipboard and now that's gone.

Ctrl-v has never worked in FBreader and still doesn't now, it seems.
I'll have a look at adding that back in.

dov 2010-11-02 09:39
Re: New FBReader build in Extras-Devel
 
I'm personally missing search in the Library window, but I found that there is no such search in the upstream FBReader either. Ideally I would like to have a limiting search like in the contact application so that when you start typing only the entries that match are shown. I have far too many books installed and flipping through them searching for them is too inefficient...

Rob1n 2010-11-02 10:04
Re: New FBReader build in Extras-Devel
 
Quote:
Originally Posted by Rob1n (Post 860658)
I'll have a look at adding that back in.
A new version is being uploaded now, adding back the "Copy to clipboard" option (with Ctrl+C as a keyboard shortcut). There doesn't look to be any paste functionality in fbreader at all though.

Rob1n 2010-11-02 10:06
Re: New FBReader build in Extras-Devel
 
Quote:
Originally Posted by dov (Post 860670)
I'm personally missing search in the Library window, but I found that there is no such search in the upstream FBReader either. Ideally I would like to have a limiting search like in the contact application so that when you start typing only the entries that match are shown. I have far too many books installed and flipping through them searching for them is too inefficient...
Did this work in the old version? There does look to be some sort of search functionality that I can see about re-enabling. I think filtering (as you suggest, which would indeed be better) would need to be implemented upstream though.

fms 2010-11-02 10:11
Re: New FBReader build in Extras-Devel
 
Hello, Rob1n

Could you please return the standard Hildon notifications (rather than the gray messages at the top left corner) and do something about the Library window (barely useful in the new version)?

dov 2010-11-02 10:36
Re: New FBReader build in Extras-Devel
 
Quote:
Originally Posted by Rob1n (Post 860704)
Did this work in the old version? There does look to be some sort of search functionality that I can see about re-enabling. I think filtering (as you suggest, which would indeed be better) would need to be implemented upstream though.
Yes, there was a simple search in the earlier version in the Library view. It would open up highlight the first book that matched the search term. It would be great getting this back.

Btw, do you have a public repo with your maemo source changes for FBReader?

Rob1n 2010-11-02 11:30
Re: New FBReader build in Extras-Devel
 
Quote:
Originally Posted by fms (Post 860709)
Hello, Rob1n

Could you please return the standard Hildon notifications (rather than the gray messages at the top left corner) and do something about the Library window (barely useful in the new version)?
What's wrong with the Library window? It works perfectly well here. I'll have a look at the notifications - it depends on how they're implemented.

Rob1n 2010-11-02 11:37
Re: New FBReader build in Extras-Devel
 
Quote:
Originally Posted by dov (Post 860736)
Yes, there was a simple search in the earlier version in the Library view. It would open up highlight the first book that matched the search term. It would be great getting this back.
I can't find anything in the current release to do this - the only search functionality I can find is within a book. I'll pull down the old release and have a look there. I thought there was some filter functionality, but it seems to be just a stub at the moment :( Still, perhaps that means it'll be coming in a future release.

Quote:
Originally Posted by dov (Post 860736)
Btw, do you have a public repo with your maemo source changes for FBReader?
No - you can grab all the diffs (and the shell script I use to apply them) from here (not all the diffs are used though). They apply against the fbreader-0.12.10 source code you can download from fbreader.org.

JanKrejcarek 2010-11-02 12:05
Re: New FBReader build in Extras-Devel
 
Quote:
Originally Posted by Rob1n (Post 860800)
What's wrong with the Library window? It works perfectly well here.
Hello, I also think that the previous Library view was better. Now in landscape mode, only five books fit on a page, thus You have to scroll a lot more then in previous versions.
To read a book, you can't tap on the book's icon or title which are quite big, but You have to hit the really small 'Read book' link instead. If You have multiple categories and open one of them than the only way to get to another category is to either scroll through all the books (remember - only five fit on a page, so scrolling is annoying) or scroll back to the category and hide the list there. And there is no search field to filter the list (to achieve less scrolling), so the Library really is merely unusable...

So, if You would:
- allow to close a category using a button (there is plenty of space at the bottom)
- make the list of books more condensed to fit more books on a page (I suggest getting rid of the links below title, ie. read, edit and remove book - the screen space is too precious to have them where they are)
- allow to open a book by tapping the book's icon and title
- allow to filter the list of books

that would in my opinion make it more usable than it is now.

Thanks a lot in advance!
Jan

geneven 2010-11-02 12:27
Re: New FBReader build in Extras-Devel
 
Nice; Ctrl-C to copy and Ctrl-V to paste are now working, and Copy Selection to Clipboard is back.

Rob1n 2010-11-02 13:14
Re: New FBReader build in Extras-Devel
 
Quote:
Originally Posted by JanKrejcarek (Post 860840)
Hello, I also think that the previous Library view was better. Now in landscape mode, only five books fit on a page, thus You have to scroll a lot more then in previous versions.
To read a book, you can't tap on the book's icon or title which are quite big, but You have to hit the really small 'Read book' link instead. If You have multiple categories and open one of them than the only way to get to another category is to either scroll through all the books (remember - only five fit on a page, so scrolling is annoying) or scroll back to the category and hide the list there. And there is no search field to filter the list (to achieve less scrolling), so the Library really is merely unusable...
I must say that I prefer the new layout. Yes, there's fewer books shown on a page, but they're clustered nicely by author & series. Yes, opening a book can be quite tricky, but I found it just as difficult with the previous version. And you get 14 books on a page in portrait mode :)

I'll see how easy it is to offer the old layout as an option though.

Quote:
Originally Posted by JanKrejcarek (Post 860840)
So, if You would:
- allow to close a category using a button (there is plenty of space at the bottom)
- make the list of books more condensed to fit more books on a page (I suggest getting rid of the links below title, ie. read, edit and remove book - the screen space is too precious to have them where they are)
- allow to open a book by tapping the book's icon and title
- allow to filter the list of books
Sorry, those are all upstream features (I think - closing a category may be feasible to add, but I'll have to look into that) - log bugs/feature requests via fbreader.org for these. I'm quite happy to enable/disable existing functionality, or add in Maemo-specific features (if they're simple enough and fit into the existing framework) but I'm not interested in forking the project.

fms 2010-11-02 17:53
Re: New FBReader build in Extras-Devel
 
Quote:
Originally Posted by Rob1n (Post 860800)
What's wrong with the Library window? It works perfectly well here.
Well, the labels are too small now and cannot be easily pressed. The standard scrolling methods that work elsewhere in FBReader no longer work in the Library window. Instead, it has got an ugly and unusable scrollbar. And the whole thing got slower for some reason, probably because it has to render more complicated content now. IMHO, you should at least make labels bigger and restore proper scrolling or, if there is such an option, return the old Library interface.

Quote:
I'll have a look at the notifications - it depends on how they're implemented.
They were implemented with hildon notification ribbons. In fact, I have been fixing them the last time, after PR1.2 changed Gtk+ event handling mechanisms. No idea why FBReader reverted to those corner messages now.

extendedping 2010-11-02 18:30
Re: New FBReader build in Extras-Devel
 
so far my gripe is the little fs button in the bottom right hand corner.

used to be I could get it to leave full screen easily, now it takes about 10 taps till it will work. and I have calibrated several times. it that one feature could be made easier (press anywhere on it and it exits full screen) that would be great. thanks.

Rob1n 2010-11-02 21:22
Re: New FBReader build in Extras-Devel
 
Quote:
Originally Posted by fms (Post 861205)
Well, the labels are too small now and cannot be easily pressed. The standard scrolling methods that work elsewhere in FBReader no longer work in the Library window. Instead, it has got an ugly and unusable scrollbar. And the whole thing got slower for some reason, probably because it has to render more complicated content now. IMHO, you should at least make labels bigger and restore proper scrolling or, if there is such an option, return the old Library interface.
The volume key scroll works in the library, but the tap scrolling doesn't - I'll try to dig into that one as well.

Quote:
Originally Posted by fms (Post 861205)
They were implemented with hildon notification ribbons. In fact, I have been fixing them the last time, after PR1.2 changed Gtk+ event handling mechanisms. No idea why FBReader reverted to those corner messages now.
Yeah, I've found that - it's still supposed to be using the hildon notifications, but the upstream author looks to have tried to abstract out the handling of all the UI-specific code, and has made a complete mess of it (so the UI-specific code doesn't actually get reached). I've been trying to work around it all this evening, but I've not found a clean solution yet - I may have to make a nasty hack for now :(

fms 2010-11-02 21:59
Re: New FBReader build in Extras-Devel
 
Quote:
Originally Posted by Rob1n (Post 861417)
Yeah, I've found that - it's still supposed to be using the hildon notifications, but the upstream author looks to have tried to abstract out the handling of all the UI-specific code, and has made a complete mess of it (so the UI-specific code doesn't actually get reached). I've been trying to work around it all this evening, but I've not found a clean solution yet - I may have to make a nasty hack for now :(
I would say, fix the upstream code. The author is pretty accepting of changes to the code, so as long as you keep the original style and approach, your work will not go in vain.

Rob1n 2010-11-03 13:27
Re: New FBReader build in Extras-Devel
 
Version 0.12.10-8 has now been uploaded. This restores the hildon notifications (turned out a lot simpler than I though - just one method that needed changing to virtual) and makes the cover image (or author image) and author/series/book titles clickable links, either opening the book or expanding/collapsing the tree.

I'll have a look at doing a more basic library view next, eliminating the cover art and extra links. I'll also look into enabling the other scroll methods in the library.

extendedping 2010-11-03 14:13
Re: New FBReader build in Extras-Devel
 
Ignore post about fs button, I rebooted and it works great. Its great to see this app getting worked on, a good ereader is much more important then any game I could have on my phone.

TinaHolmboe 2010-11-03 14:29
Re: New FBReader build in Extras-Devel
 
FBreader has come a long way, and I'm particularly glad for the improved epub support.

But ... I am at a loss to find any way to add a book to the library from inside the application itself. It doesn't search sub-folders, despite the appropriate box being ticked.

There's also the problem with the preference editor not migrated to Maemo UI, which makes changing options very, very hard indeed.

irene 2010-11-03 14:34
Re: New FBReader build in Extras-Devel
 
Need help pls
I have updated my fbreader to 0.12.10
and now it won't recognize fb2's or any formats but txt's

thanks! :)

extendedping 2010-11-03 15:33
Re: New FBReader build in Extras-Devel
 
ok a few requests here...

1) fs button does not exist in library mode, this means if you decide to exit the app in library mode you must either a) select a book first or b) use keyboard ctrl backspace to minimize app then hope your touch closes it (I usually miss and it just reexpand it).

2) option to open app in full screen, since the ability to go to fs already exists, why not have this option?

3) library view that just shows book covers. for whatever reason my oreilly.com books work not so well with the library function in fbreader (but work better in say dorian). In fbreader. for instance I have 17 books but since it by default sorts by author, many of the books repeat in the library (I have 32 choices to be exact because if a book has multiple authors I get multiple entries for the same book). and I have to drill down through authors to get to the books. dorian and meebook on the other hand just show the book covers and titles, which is much easier. to have this functionality and to be able to set default library view would be great.

thanks for listening...

Rob1n 2010-11-03 15:57
Re: New FBReader build in Extras-Devel
 
Quote:
Originally Posted by TinaHolmboe (Post 862206)
But ... I am at a loss to find any way to add a book to the library from inside the application itself. It doesn't search sub-folders, despite the appropriate box being ticked.
That's odd - mine searches within subdirectories with no problems (my epub books are all in subdirectories by author). I'll look at re-adding the "Add book" option to the library menu though.

Quote:
Originally Posted by TinaHolmboe (Post 862206)
There's also the problem with the preference editor not migrated to Maemo UI, which makes changing options very, very hard indeed.
Yeah. There is a partly migrated version, but I need to look into how to get it enabled (and make sure it still offers all the options).

Quote:
Originally Posted by irene (Post 862216)
Need help pls
I have updated my fbreader to 0.12.10
and now it won't recognize fb2's or any formats but txt's
I'll try to grab some alternate formats and try them. That's all upstream functionality though, and certainly shouldn't be affected by any of the patches I've added.

EDIT2: I've just tried an fb2 (from fictionbook-lib.org) and that showed up (and opened) fine.

Quote:
Originally Posted by extendedping (Post 862282)
1) fs button does not exist in library mode, this means if you decide to exit the app in library mode you must either a) select a book first or b) use keyboard ctrl backspace to minimize app then hope your touch closes it (I usually miss and it just reexpand it).
You can also press "F" on the keyboard to exit full-screen mode. I'll look at forcing the fullscreen overlay back on for library view though (there's no way to add the FS button).

Quote:
Originally Posted by extendedping (Post 862282)
2) option to open app in full screen, since the ability to go to fs already exists, why not have this option?
Good question - should be straightforward enough to add.

Quote:
Originally Posted by extendedping (Post 862282)
3) library view that just shows book covers. for whatever reason my oreilly.com books work not so well with the library function in fbreader (but work better in say dorian). In fbreader. for instance I have 17 books but since it by default sorts by author, many of the books repeat in the library (I have 32 choices to be exact because if a book has multiple authors I get multiple entries for the same book). and I have to drill down through authors to get to the books. dorian and meebook on the other hand just show the book covers and titles, which is much easier. to have this functionality and to be able to set default library view would be great.
You could do this via the tag view (and deleting all tags from the books) but that's a bit messy. I'll have a look at how easy it'll be to do a non-clustered view. This'll get very messy if you have hundreds of books though (and how should it be sorted - by title I guess?).

Also, version 0.12.10-9 has now been uploaded, adding a basic library view option (in the preferences dialog). This shows only the author/series/title/tag label (with a +/- to indicate where they'll expand/collapse). The spacing looks reasonable enough to me, but let me know if you feel it's too spread out or too tight to easily select.

EDIT: Oh, the tap scrolling in the library view will have to wait - it's going to be a lot of work to add that in, so I'll look into some of these other issues/requests first.

extendedping 2010-11-03 16:21
Re: New FBReader build in Extras-Devel
 
And you thought this would be a little side project :)

TinaHolmboe 2010-11-03 16:45
Re: New FBReader build in Extras-Devel
 
Quote:
Originally Posted by Rob1n (Post 862322)
That's odd - mine searches within subdirectories with no problems (my epub books are all in subdirectories by author). I'll look at re-adding the "Add book" option to the library menu though.
I've just downloaded "First & Only" from the Black Library (Free eBook Fridays, yay), and copied it to

device:/home/user/.documents/MyDocs/ebooks/Black Library

THEN I found a spelling error in the "Book Path". Mea culpa; ignore the above problem report, please.

Now just to wait until FBreader has indexed everything down there ....

Rob1n 2010-11-04 15:47
Re: New FBReader build in Extras-Devel
 
Version 0.12.10-10 now uploaded. This adds an option to start in fullscreen mode, an extra view mode for the library (by name - without any hierarchy), and forces the fullscreen overlay button on in the Library view (making it easy to toggle back from fullscreen). There's also a few cleanups to the popup dialog code (added busy spinner) and the fullscreen code.

With adding the fullscreen startup option, I've added a new Startup tab to the preferences, and moved the option to start in the library view there as well (this may cause fbreader to forget the previous setting though, so check this if you're using this option).

The source code changes are available from here.

extendedping 2010-11-04 16:33
Re: New FBReader build in Extras-Devel
 
you're really banging out the releases with the changes implemented, this is great :)

dorian seems to be moving too...its an all out ereader war (meebook is pretty far in the rear right now).

adhrie 2010-11-04 16:35
Re: New FBReader build in Extras-Devel
 
i'm having problem opening .chm files since flashing to PR 1.3
already installed the latest 0.12.10-10 still having problem

tried opening .chm files from file manager and point fbreader to open it but still no luck

.chm books didn't showed in the library eventhough the path are correct
there is no add book icon or option in the library

any idea how to fix this?

Rob1n 2010-11-04 16:47
Re: New FBReader build in Extras-Devel
 
Quote:
Originally Posted by adhrie (Post 863405)
i'm having problem opening .chm files since flashing to PR 1.3
already installed the latest 0.12.10-10 still having problem

tried opening .chm files from file manager and point fbreader to open it but still no luck

.chm books didn't showed in the library eventhough the path are correct
there is no add book icon or option in the library

any idea how to fix this?
I'll have a play around with that this evening - I should definitely be able to get the "Add book" option in, but I'll also try to track down why it's not seeing them in the first place.

Rob1n 2010-11-04 16:50
Re: New FBReader build in Extras-Devel
 
Quote:
Originally Posted by Rob1n (Post 863417)
I'll have a play around with that this evening - I should definitely be able to get the "Add book" option in, but I'll also try to track down why it's not seeing them in the first place.
And I've just tried the desktop version, and the version in scratchbox. They both load .chm files fine, as long as the option to collect books without metadata is enabled. Can you make sure this is set and see whether that helps?

extendedping 2010-11-04 17:43
Re: New FBReader build in Extras-Devel
 
Ok first off thanks for all the work you are putting in. 2 issues I noticed off the bat.

1) I selected the new show covers view and I could neither swipe or use the volume rocker button to move down to page 2.

2) I know I cried wolf earlier, but it seems the little fs button no longer works at all. I tried 2 recalibrations and a reboot, and after 5 minutes of poking in and around fs with my stylus, it never exited full screen.

also just to make things more intuitive, it might make sense to put the options to show the fs and the other one to keep bigger full screen button on the same page in options, as they kind of relate but unless you read these threads it would be hard to figure out what do do just browsing though preferences. I would explain the options I am talking about better but since I opted for the new "start in full screen mode" and I can't use fs to exit it I can't get to the preferences dialogue :(

a final request (well they are never final are they?)...you have the small swipe option, is there a way to make it swipe more then one line at a time? like say 3 lines? again sorry it that option is already there but I am locked out at this moment...

Rob1n 2010-11-04 18:28
Re: New FBReader build in Extras-Devel
 
Quote:
Originally Posted by extendedping (Post 863472)
1) I selected the new show covers view and I could neither swipe or use the volume rocker button to move down to page 2.
Swipe definitely won't work - there's no support for that in the library view at all. Presumably the old version just mapped the library into the book view, so inherited all the same functionality, whereas the new version has totally separate frameworks for each. The volume rocker button works fine here though, in any library mode.

Quote:
Originally Posted by extendedping (Post 863472)
2) I know I cried wolf earlier, but it seems the little fs button no longer works at all. I tried 2 recalibrations and a reboot, and after 5 minutes of poking in and around fs with my stylus, it never exited full screen.
Again, I can't reproduce this one. It sometimes takes a couple of presses, but I've no problem using either finger or stylus.

Quote:
Originally Posted by extendedping (Post 863472)
also just to make things more intuitive, it might make sense to put the options to show the fs and the other one to keep bigger full screen button on the same page in options, as they kind of relate but unless you read these threads it would be hard to figure out what do do just browsing though preferences. I would explain the options I am talking about better but since I opted for the new "start in full screen mode" and I can't use fs to exit it I can't get to the preferences dialogue :(
From one point of view, yes. However, one is a global option (applying to the indicator bar, so present on that tab) and the other is maemo-specific (so on the Maemo tab).

Quote:
Originally Posted by extendedping (Post 863472)
a final request (well they are never final are they?)...you have the small swipe option, is there a way to make it swipe more then one line at a time? like say 3 lines? again sorry it that option is already there but I am locked out at this moment...
That's already there - on the Scrolling tab there's an option "Lines to Scroll per Line Scrolling". The small swipe just calls the line scroll function, so should use this value.

You can edit the ~/.FBReader/options.xml and edit the StartFullscreen option if you want to get access back to the menu. I'd recommend adding a shortcut for fullscreen mode as well (I thought that was a default, but apparently not - I'll see about adding this in for the next release).

EDIT: Ah, Ctrl+Enter is the default fullscreen toggle keybinding.

fms 2010-11-04 18:41
Re: New FBReader build in Extras-Devel
 
Rob1n, please, return "keep 1 line on page-scroll" default setting back: I specifically left it there, so that whoever turns a page could see the context he/she has been reading. One line does not make a difference in terms of efficiency, but provides some continuity to the reader.

extendedping 2010-11-04 18:56
Re: New FBReader build in Extras-Devel
 
hmm after 10 more minutes of clicking can say with certainty that fs is not working for me. I will reinstall and report back.

Rob1n 2010-11-04 19:21
Re: New FBReader build in Extras-Devel
 
Quote:
Originally Posted by fms (Post 863522)
Rob1n, please, return "keep 1 line on page-scroll" default setting back: I specifically left it there, so that whoever turns a page could see the context he/she has been reading. One line does not make a difference in terms of efficiency, but provides some continuity to the reader.
I'd brought across all the default settings from before, but it looks like the setting name has changed in the new version, so it was being ignored. I'll fix this in the next release.

adhrie 2010-11-04 19:21
Re: New FBReader build in Extras-Devel
 
collect books without metainfo already checked and .chm books still didn't show

probably something wrong with my .chm book (but it loads fine on my desktop Isilo and the previous version (don't remember which) of fbreader on my n900)

will try to find another .chm books and i'll let you know if anything changes...

extendedping 2010-11-04 20:04
Re: New FBReader build in Extras-Devel
 
ok I reinstalled twice. for sure fs is not working.

questions...

1) I am in "start in fs mode"
2) I disabled the option to have a big button to return to full screen.
3) hitting f on the keyboard does not exit fs (I think it did previously) :(

Rob1n 2010-11-04 20:47
Re: New FBReader build in Extras-Devel
 
Quote:
Originally Posted by extendedping (Post 863590)
ok I reinstalled twice. for sure fs is not working.

questions...

1) I am in "start in fs mode"
2) I disabled the option to have a big button to return to full screen.
3) hitting f on the keyboard does not exit fs (I think it did previously) :(
The default shortcut is Ctrl+Enter - "F" will only work if you've added it specifically.

extendedping 2010-11-04 21:23
Re: New FBReader build in Extras-Devel
 
bingo, I guess you need to have enable navigation enabled I did not, previously I don't thing you needed it but I am probably wrong (I usually am).

this is really looking like a great app with the work put into it.

damn you rob1n you will end up costing me $100 (the price for the mugen battery after shipping) now that this app is really usable...

Rob1n 2010-11-04 22:02
Re: New FBReader build in Extras-Devel
 
Quote:
Originally Posted by extendedping (Post 863684)
bingo, I guess you need to have enable navigation enabled I did not, previously I don't thing you needed it but I am probably wrong (I usually am).
Glad you've been able to track that down. I don't think that'll have changed at all from previous version, but I'll look into fixing it for next release - those settings shouldn't be dependent.

Rob1n 2010-11-05 18:06
Re: New FBReader build in Extras-Devel
 
Version 0.12.10-11 now uploaded. The changes are:
  • Fixed changed option names in default config
  • Added "Add book" menu option
  • Made indicator fullscreen button independent of the "enable navigation" setting
  • Hildonised application menu
  • Hildonised the configuration dialog

The menu and configuration changes were already in the code, but just weren't enabled before (there were some fixes I needed to do as well). I'm not entirely happy with the layout though - any suggestions on ways to improve it?

The source code changes are available from here.

jkq 2010-11-05 18:27
Re: New FBReader build in Extras-Devel
 
Quote:
Originally Posted by Rob1n (Post 864516)
Version 0.12.10-11 now uploaded. The changes are:
  • Fixed changed option names in default config
  • Added "Add book" menu option
  • Made indicator fullscreen button independent of the "enable navigation" setting
  • Hildonised application menu
  • Hildonised the configuration dialog

The menu and configuration changes were already in the code, but just weren't enabled before (there were some fixes I needed to do as well). I'm not entirely happy with the layout though - any suggestions on ways to improve it?

The source code changes are available from here.
Would it be possible to push this to the Diablo repos too?

-jkq


All times are GMT. The time now is 02:15.
Page 6 of 11 « First 45 6 78 Last »
Show 40 post(s) from this thread on one page

vBulletin® Version 3.8.8