maemo.org - Talk

maemo.org - Talk (https://talk.maemo.org/index.php)
-   Applications (https://talk.maemo.org/forumdisplay.php?f=41)
-   -   New FBReader build in Extras-Devel (https://talk.maemo.org/showthread.php?t=36857)

Rob1n 2010-11-05 18:31

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by jkq (Post 864522)
Would it be possible to push this to the Diablo repos too?

I'll have a look - I'll need to set up a diablo scratchbox and make sure if compiles and runs there first.

extendedping 2010-11-05 19:12

Re: New FBReader build in Extras-Devel
 
good to see this app getting the love it needs...

extendedping 2010-11-06 03:44

Re: New FBReader build in Extras-Devel
 
warning...noticed in the last build...

defaulted to saving 1 line on new page from old page. I moved that to 0 and changed nothing else in preferences. suddenly fbreader looked and acted differernt...looked again in preferences and every box was now unchecked...hmm there is a major glitch somewhere in this new build I think...

Rob1n 2010-11-06 11:52

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by extendedping (Post 864934)
warning...noticed in the last build...

defaulted to saving 1 line on new page from old page. I moved that to 0 and changed nothing else in preferences. suddenly fbreader looked and acted differernt...looked again in preferences and every box was now unchecked...hmm there is a major glitch somewhere in this new build I think...

Yes, looks like it's failing to read the value from the checkbox fields. Editing any value would seem to clear them all. I'll look into this ASAP.

extendedping 2010-11-06 11:59

Re: New FBReader build in Extras-Devel
 
thanks it is developers like you who keep this device alive...

Rob1n 2010-11-06 14:28

Re: New FBReader build in Extras-Devel
 
Version 0.12.10-12 now uploaded. The changes are:
  • Fixed read of checkbox config state
  • Fixed checkbox dependencies
  • Fixes to allow building on Maemo 4

I've uploaded this for both Fremantle and Diablo. The Diablo version doesn't support keeping the display on (I've not found any code for that yet), and doesn't feature the hildonised menu & config (as this is all using Maemo 5 specific code). The remaining features should be exactly the same though.

The source code changes are available from here.

extendedping 2010-11-06 14:39

Re: New FBReader build in Extras-Devel
 
Thanks now I can get back to reading on my n900 :)

If I find anything I will not report it till monday so you can have a weekend....

locolyric 2010-11-06 15:43

Re: New FBReader build in Extras-Devel
 
just update the fbreader to the latest version.
seems the preference do have some bugs, i made the change but when enter preference again, all things reset back to the status earlier.

even the fullscreen mode don't have the button to exit it.
yes, i do choose , show the exit fullscreen button in the menu.

extendedping 2010-11-06 16:01

Re: New FBReader build in Extras-Devel
 
I guess this makes me a liar.

I resorted all my original check boxes. I have it opening in fs mode. Now when I go to library and click on a book (I have it in the most basic library view where all it does is show the names of the books, no icons) and click on a book (either the one I was just on or on another one) it says loading book and then does one of two things.

a) fbreader crashes
b) it hangs on library and you need to eventually perform an action (such as going into full screen or rotating the book) to get the book back.

Looking at the app a few more requests...

1) Open books in fs option. As it is now you can open the app to open a book in fs but if you then say use the lib or toc you are brought to the next (or same) book not in fs mode...

2) taking that a step further, how about options to open toc and library in fs mode? I see the fs icon has already been implemented in the toc so why not give the option to just enter in full screen? I wonder if it then could be implemented in the library as well? I guess my overall point is that on a screen this size it really matters in terms of real estate when you are in full screen or not, and the more full screen default areas in my opinion, the better...

3) Press of the same book you were in in library mode take you to that book immediately as opposed to having to reload the book. I think this would be possible as I know in keyboard shortcuts there is an option to simply go back to your last page (was it cancel or quit?)...

4) the motherload functionality (from my perspective)...2 more tiny buttons on the bottom of the screen (I could do without the indicator and just keep the pages to know my position to save real estate)...a tc (table of contents) and a lb (library) button similar to and beside the fs button. In this case if I had entered books (and app) in fs mode along with library and toc in full screen mode enabled, using the device would be really intuitive and fast. Just enter, you are in book mode in fs, 1 click to go to toc, 1 click to go to library (and within library 1 click on book you are already in to go back fast to that book) and 1 click when you need to go full screen. heck you could even put a pr (preference) button on the bottom as well and be done with crippled small screen (for most actions). then you could even have one option in preferences that loads all the full screen options mentioned above, effectively making all the defaults full screen but with the ability to use the small screen mode at any point with the fs button...and duh a rt (rotate) button as well.

basically use of the bottom to put all the most commonly used options one would need while using the device on fs.

5) Enter library option with tap of library button (or just the screen) when the device is loading. This way you have the ability to usually load your last book, but enter the library to short circuit the book load if you want...

Sorry for the mouthful I was kind of going on a stream of thought there...

Rob1n 2010-11-06 18:10

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by locolyric (Post 865247)
just update the fbreader to the latest version.
seems the preference do have some bugs, i made the change but when enter preference again, all things reset back to the status earlier.

even the fullscreen mode don't have the button to exit it.
yes, i do choose , show the exit fullscreen button in the menu.

Are you sure that's not the 0.12.10-11 version? This issue was fixed in 0.12.10-12.

Quote:

Originally Posted by extendedping (Post 865257)
I resorted all my original check boxes. I have it opening in fs mode. Now when I go to library and click on a book (I have it in the most basic library view where all it does is show the names of the books, no icons) and click on a book (either the one I was just on or on another one) it says loading book and then does one of two things.

a) fbreader crashes
b) it hangs on library and you need to eventually perform an action (such as going into full screen or rotating the book) to get the book back.

Looks like this came in somewhere between -10 and -11 - I'll track down the change and get this fixed. I've not seen the crash myself - it just looks like it's failing to redraw the screen.

Quote:

Originally Posted by extendedping (Post 865257)
1) Open books in fs option. As it is now you can open the app to open a book in fs but if you then say use the lib or toc you are brought to the next (or same) book not in fs mode...

2) taking that a step further, how about options to open toc and library in fs mode? I see the fs icon has already been implemented in the toc so why not give the option to just enter in full screen? I wonder if it then could be implemented in the library as well? I guess my overall point is that on a screen this size it really matters in terms of real estate when you are in full screen or not, and the more full screen default areas in my opinion, the better...

This should be possible, but it's not exactly a lot of work to tap the fullscreen button in the toolbar! I'll have a look, but I don't see a lot of point in this unless you can change between the screen without needing to leave fullscreen mode.

Quote:

Originally Posted by extendedping (Post 865257)
3) Press of the same book you were in in library mode take you to that book immediately as opposed to having to reload the book. I think this would be possible as I know in keyboard shortcuts there is an option to simply go back to your last page (was it cancel or quit?)...

That should be straightforward enough, yes.

Quote:

Originally Posted by extendedping (Post 865257)
4) the motherload functionality (from my perspective)...2 more tiny buttons on the bottom of the screen (I could do without the indicator and just keep the pages to know my position to save real estate)...a tc (table of contents) and a lb (library) button similar to and beside the fs button. In this case if I had entered books (and app) in fs mode along with library and toc in full screen mode enabled, using the device would be really intuitive and fast. Just enter, you are in book mode in fs, 1 click to go to toc, 1 click to go to library (and within library 1 click on book you are already in to go back fast to that book) and 1 click when you need to go full screen. heck you could even put a pr (preference) button on the bottom as well and be done with crippled small screen (for most actions). then you could even have one option in preferences that loads all the full screen options mentioned above, effectively making all the defaults full screen but with the ability to use the small screen mode at any point with the fs button...and duh a rt (rotate) button as well.

basically use of the bottom to put all the most commonly used options one would need while using the device on fs.

I don't think that's really workable - putting any more buttons in there will just make it impossible to press the correct one with any accuracy. I'll look into some other options to offer the same functionality though.

Quote:

Originally Posted by extendedping (Post 865257)
5) Enter library option with tap of library button (or just the screen) when the device is loading. This way you have the ability to usually load your last book, but enter the library to short circuit the book load if you want...

I'll see about this - I'm not sure there's an easy way to cancel the loading process though.

mmr 2010-11-06 18:57

Re: New FBReader build in Extras-Devel
 
Im still not finding the add book function despite it being added any suggestions?

Rob1n 2010-11-06 20:38

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by mmr (Post 865370)
Im still not finding the add book function despite it being added any suggestions?

It should be in the menu - I've not added it to the toolbar though.

extendedping 2010-11-07 02:01

Re: New FBReader build in Extras-Devel
 
thanks library not crashing or hanging upon book selection now.

looking at the menu that starts with book info and ends with preferences...how about if that menu which includes toc and library could be accessed from a button from within a book? that way if there were options to open books the library and toc in full screen, one could have access to books toc and library without having to ever go to full screen.

I know for some who use fbreader to just read a book straight through the current function of fbreader may be sufficent. But for anyone trying to learn from technical books (I use fbreader with my oreilly.com books), constantly minimizing/maximizing while book hopping or toc hopping is a major pain (just like I am)...thanks for listening, and of course books toc and lib in default full screen with an option to easily access the main menu would only be options not defaults...

Rob1n 2010-11-10 18:27

Re: New FBReader build in Extras-Devel
 
Version 0.12.10-14 now uploaded. The changes are:
  • Touch scrolling works in library now
  • Added popup menu
  • Popup menu and/or toolbar can be disabled

The popup menu is currently fixed in a landscape orientation - there's no straightforward way to change this in GTK (I'll need to write a new menu implementation - I'll look into this, but I can't promise anything). It's timed to pop up after 0.5 seconds stylus/finger press, and has a tolerance for how far the stylus/finger can move in this time. This may make it difficult to use with the finger, as this seems to register quite a range of movement even while held still. Both the hold time and the movement tolerance setting are configurable, but haven't been added to the config dialog yet (you should be able to edit the ~/.FBReader/options.xml file and add either MovementTolerance (in pixels, default 5) or LongPressTime (in ms, default 500) options to the TapScrolling section).

I'll be uploading a Diablo version as well, but I'm still trying to get to the bottom of a segfault when loading books there. Unfortunately I can't find a working debugger - I'm going to try rebuilding the fremantle version of gdb next.

The source code changes are available from here.

jcharpak 2010-11-11 15:50

Re: New FBReader build in Extras-Devel
 
Robin, could you coordinate with danny.milo@gmail.com.nospam (minus the nospam)? He's got a version based on 0.14 which doesn't crash. See his website for his changes and debs for both n800 and n900.

extendedping 2010-11-11 16:10

Re: New FBReader build in Extras-Devel
 
Thanks works fine without stylus, if you can force portrait this will be better but you have really increased the usability of this app by leaps and bounds. I bought this device really only to have a command line in my pocket and an ability to keep my tech books inmy pocket. your help has really made this device fulfill its potential to me :)

oh btw finger scroll in library seems to be reversed.....is that a "feature"? (:

extendedping 2010-11-11 16:35

Re: New FBReader build in Extras-Devel
 
also a close application option fom the great little pop up menu so you could close without having to go full screen (one less step right?).

fms 2010-11-11 16:55

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by jcharpak (Post 870441)
Robin, could you coordinate with danny.milo@gmail.com.nospam (minus the nospam)? He's got a version based on 0.14 which doesn't crash. See his website for his changes and debs for both n800 and n900.

AFAIK (based on studying FBReader website), version 0.14 does not exist. 0.12 is the latest version. I have absolutely no idea where Danny Milo got his "0.14" or what it was.

extendedping 2010-11-11 17:17

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by fms (Post 870513)
AFAIK (based on studying FBReader website), version 0.14 does not exist. 0.12 is the latest version. I have absolutely no idea where Danny Milo got his "0.14" or what it was.

http://scratchpost.dreamhosters.com/...N900/FBReader/

greenbelt 2010-11-11 17:32

Re: New FBReader build in Extras-Devel
 
FBReader is my second most important software on the N900. Awesome Software and I like recent developments. What I am missing is the display of the time and page position, that was there in previous versions. Is that optional now and I am too dumb to find the switch. If it is gone, then can it come back please? I like being able to read a book in a train and checking the time without having to leave the full screen book display. The time display as before never disturbed me.

mscion 2010-11-11 17:39

Re: New FBReader build in Extras-Devel
 
I was wondering if fbreader allows for zooming of text, ideally with the text
wrapped so you dont have to shift the screen to see content?

Regardless, thanks for your efforts. A very nice application!

extendedping 2010-11-11 17:41

Re: New FBReader build in Extras-Devel
 
I have the latest build and time/show pages are there in preferences...

mscion 2010-11-11 17:47

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by mscion (Post 870550)
I was wondering if fbreader allows for zooming of text, ideally with the text
wrapped so you dont have to shift the screen to see content?

Regardless, thanks for your efforts. A very nice application!

My bad. Font size is in preferences.

extendedping 2010-11-11 17:56

Re: New FBReader build in Extras-Devel
 
just a thought...since bringing up the menu via touch actually contains the full screen option, and since it is still (a little) hard to tap to bring up the menu...

might it make better sense to do away with the fs button, replacing it with a menu button?

That way you have 2 methods to get to the menu (which contains the full screen option anyway) and the sm (show menu or whatever it would be called) would provide an option that would never require a stylus or perfectly still finger tap.

anyways hope I am not just being a pain cause the app is pretty good as it stands now. It just seems accessing the menu from the polsition the fs button is in now would make for better use of the space...opens up more options but still include full screen function...

Rob1n 2010-11-11 18:48

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by jcharpak (Post 870441)
Robin, could you coordinate with danny.milo@gmail.com.nospam (minus the nospam)? He's got a version based on 0.14 which doesn't crash. See his website for his changes and debs for both n800 and n900.

I've already looked at the code and backported the useful changes. I'll recheck other versions on the N800 and see whether I can reproduce/track down the lock-up issue. I'm also planning on pulling together some patchsets against the current FBReader source code and get them pushed upstream.

Quote:

Originally Posted by extendedping (Post 870470)
if you can force portrait this will be better

Version 0.12.10-15 has just been uploaded with rotation support for the popup menu. I've uploaded both the N800 and N900 version - the N800 still locks up sometimes on loading a book, but the previous version I uploaded suffers the same issue, so I've uploaded the improved version anyway.

Quote:

Originally Posted by extendedping (Post 870470)
oh btw finger scroll in library seems to be reversed.....is that a "feature"? (:

Oops - I'll swap that for the next release.

Quote:

Originally Posted by extendedping (Post 870497)
also a close application option fom the great little pop up menu so you could close without having to go full screen (one less step right?).

I'm concerned that it's too easy to hit by accident though. I'll have a look into it though.

Quote:

Originally Posted by greenbelt (Post 870547)
What I am missing is the display of the time and page position

That's enabled via the Indicator section in the preferences dialog.

Quote:

Originally Posted by extendedping (Post 870577)
just a thought...since bringing up the menu via touch actually contains the full screen option, and since it is still (a little) hard to tap to bring up the menu...

Given the problems you've reported getting the FS button to work reliably, I'm not sure it'd help. I'll look at adding some tuning for the sensitivity of the popup menu, which might help. I fon't find any problem getting it to show though - I usually use my fingernail.

extendedping 2010-11-11 19:00

Re: New FBReader build in Extras-Devel
 
yes but my fs has been very easy if you recall it was due (I believe) to an issue with not having navigation enabled.

anyway lets say that (which it is not for me anymore) hard to use fs...well once you hit it you may as well be rewarded with more options right?

actually the reason I asked is because I was walking using fbreader this morning and had to stop every time I needed the menu, yet could use the toggle fs while walking.

btw for the close app in the menu if you do include it...would it be possible to make it require either an extra long press or a double tap while leaving the other chioces unchanged?

again I can't stress enough my appreciation enough, its guys like you and martink (modrana) that are keeping this device fresh...

ps having a button to access the menu could just be an option meaning someone else could still opt for fs instead right?

extendedping 2010-11-11 20:25

Re: New FBReader build in Extras-Devel
 
could double tap screen be an option to bring up the menu? that seems like it would require less sensitivity then holding the finger/stylus...I don't know if it is used for anything else, but I for one have never (purposely) double tapped anything in fbreader.

fms 2010-11-12 08:49

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by extendedping (Post 870535)

Official FBReader site:

http://freshmeat.net/projects/fbreader

lists the latest version as 0.12.10. So, once again, it is not clear what 0.14.* stuff is about.

fms 2010-11-12 08:51

Re: New FBReader build in Extras-Devel
 
Hey, Rob1n, could you remove the scrollbar from the library view or, rather, make it optional? I think there was an option in the settings saying "show scrollbar" - the library view should make use of it.

Rob1n 2010-11-12 09:32

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by fms (Post 871235)
Official FBReader site:

http://freshmeat.net/projects/fbreader

lists the latest version as 0.12.10. So, once again, it is not clear what 0.14.* stuff is about.

It's mostly work on PDF - I've no idea where the new version number came from though (the tar file extracts to a 0.12.10 directory as well).

Quote:

Originally Posted by fms (Post 871238)
Hey, Rob1n, could you remove the scrollbar from the library view or, rather, make it optional? I think there was an option in the settings saying "show scrollbar" - the library view should make use of it.

I don't see any setting in there for that, but I can certainly add one in.

EDIT: Currently I'm working on clearing up the issues reported by Valgrind - hopefully this'll eliminate the segfault on exit, and possibly it'll help with the Diablo lockup issue as well.

extendedping 2010-11-12 14:04

Re: New FBReader build in Extras-Devel
 
small issue if you have show page numbers enabled and old school scroll bar, if you shrink scroll bar the book text starts covering the page numbers. the obvious fix is "dont shrink the scroll bar", but still...

gsever 2010-11-12 19:05

Re: New FBReader build in Extras-Devel
 
Hey, I see some updates on Fbreader and start reading books again :) Where do you keep the release/update logs? Would like to follow closely what is going on here. Thanks.

extendedping 2010-11-12 19:08

Re: New FBReader build in Extras-Devel
 
it has turned into a great app a few more tweaks and it is going to be amazing.

extendedping 2010-11-14 14:02

Re: New FBReader build in Extras-Devel
 
however the new pop up menu ends up implemented, would it be possible to allow custom addons from sections in the preferences? for example the standard things I see (lib toc rotate fs) would remain but for instance I would like change font size, exit app (quit) search forward/backwards jump to next/prev toc and open full preferences on the menu....others might want other things as optional add ons to the new quick menu.

then again I am 44 and am still waiting on that toy train set I never got :(

Rob1n 2010-11-14 20:35

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by gsever (Post 871794)
Hey, I see some updates on Fbreader and start reading books again :) Where do you keep the release/update logs? Would like to follow closely what is going on here. Thanks.

You can download the source code changes from here - that'll include the changelogs (the package repository only seems to show the latest changes).

Quote:

Originally Posted by extendedping (Post 873119)
however the new pop up menu ends up implemented, would it be possible to allow custom addons from sections in the preferences? for example the standard things I see (lib toc rotate fs) would remain but for instance I would like change font size, exit app (quit) search forward/backwards jump to next/prev toc and open full preferences on the menu....others might want other things as optional add ons to the new quick menu.

then again I am 44 and am still waiting on that toy train set I never got :(

You can do this already, but it's not straightforward. You'll need to edit the /usr/share/FBReader/default/popupmenu.xml file and add the new entries - the appropriate file from /usr/share/FBReader/resources (en.xml for English) will give you the relevant keys to use - you'll also have to make sure they appear within the menubar section of that file.

I'll have a look at an easier way to allow this, but I think this'll be rather a lot of work.

extendedping 2010-11-14 23:22

Re: New FBReader build in Extras-Devel
 
Thanks, I will have a go at configuring via the files tonight. I am still hoping an alternate method of accessing the menu can be done such as double tap or a button like the fs. I say this because I have no nails (keeping short for guitar) and being lefty using the stylus is just a pain.

Again thanks for all the great work and for at least listening to the users like me.

gsever 2010-11-14 23:26

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by Rob1n (Post 873350)
You can download the source code changes from here - that'll include the changelogs (the package repository only seems to show the latest changes).

Can you re-up the link? You might need to configure your server apparently.

Rob1n 2010-11-15 08:49

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by gsever (Post 873490)
Can you re-up the link? You might need to configure your server apparently.

Sorry - I meant to double check that before I posted it. The link's working now.

extendedping 2010-11-15 16:33

Re: New FBReader build in Extras-Devel
 
I'm a little bit confused here...aren't we entitled to at least 2 fbreader updates per day?

Rob1n 2010-11-15 19:37

Re: New FBReader build in Extras-Devel
 
Quote:

Originally Posted by extendedping (Post 874206)
I'm a little bit confused here...aren't we entitled to at least 2 fbreader updates per day?

Sorry, I've been slacking today :rolleyes:

I've managed to sort out a few issues anyway - uninitialised variables, memory not being freed properly, etc. There's still a couple more I want to look into before I start on any new stuff though.


All times are GMT. The time now is 02:15.

vBulletin® Version 3.8.8