Originally Posted by eitama (Post 686113)

Installed, my comments :
1. proximity sensor only brings up the interface, it does not hide it,
which is a bit annoying, but that my personal opinion, and you can just tap elsewhere.
2. While the interface is being displayed, the camera shutter button does NOT work, You need to go back to camera interface and take the shot, in this case, the half press is not intercepted by lFocus, and the manual focus is replaced by auto focus.

Suggestions :
1. Make proximity sensor toggle the UI on/off.
2. Add a checkbox to the left of the manual focus progress bar which will control the functionality of intercepting the half press.
This will allow one to set manual focus, remove the UI to get fullscreen without dimming / blurring - take the shot without auto-focus getting in the way.

Good job mate,
I enjoy doing QA for you.
Eitam.

Edit :
1 more bug, which existed in all versions as far as I remember.
- The hw keyboard shortcuts do not always work on the 1st hit, they sometimes require double click, even if you just toggle red light on off on hw keyboard this happens.

Originally Posted by m2cm2c (Post 686160)

thank you for your observations :D
1. when I first wrote the code for the proximity it was for showing and hiding the dialog but it got annoying when I put my thumb on the proximity by mistake and hide the dialog, then I thought it would be better just to tap on the screen to hide it instead.
2.lfocus does not turn off autofocus by default you only do that by turning on the keyboard shortcuts, as for taking a picture while the menu is shown, the solution I could think of right now is to automatically hide the menu and start capturing immediately, I think it is a good Idea and I will implement it in a future release.
3. yes the keyboard shortcuts are a bit laggy right now and you should hold on the shortcut for a little while for it to activate. I think I will find a solution for that in a future release also.
[Edit]
for #1 I think I could add a toggle button for the proximity showing/hiding the dialog :D

Originally Posted by eitama (Post 686216)

I am glad to help, you are doing fine work.
1. I understand about the proximity sensor, it's cool if you leave it as show UI only.
2. After reading what you wrote, I will change my suggestion :
when the UI pops up, it should automatically turn on keyboard shortcuts, this way you can close the UI, and still enjoy the manual focus you configured. Then, to go back to autofocus, the user needs to tap the proximity sensor again, and uncheck the checkbox I suggested earlier you should add.
3. Cool (;

Edit :
- The blinking red in timer mode is working great!

Originally Posted by Crogge (Post 686236)

It would be nice to add a delay to the proximity sensor, like a requirement to hold it 2 seconds before the menu appears. Its reacting sometimes on "false alarms" too quick.

Disabling the entire zoom could be also quite handy, replacing the zoom buttons with the manual focus also in the default camera mode would be better. (I saw that it works only in keyboard mode)

Except that I really like the plugin and use it very often :)

Originally Posted by zimon (Post 686276)

Does not work for me. Disabled shortcutd (which was using proximity sensor) but still didn't work.

If one keeps camera lens cover open all the time (mine is and cannot shut it down), will the program work?

Originally Posted by zimon (Post 686276)

Also tried to manually start lfocus.py on xterminal (sudo ...). Starts, but when camera button is pressed and camera application comes in front, I still cannot see anything which would tell there is some extra (lfocus).

Originally Posted by zimon (Post 687748)

Made the self.show_all() modification.

Got it working by manually starting from terminal. However, I have to CTRL+C to quit "sudo lfocus start" in the end?

Couldn't see any icon/information in the camera/video window though, with or without covering proximity sensor with my left thumb.