maemo.org - Talk - [Announce] MyContacts - 75 contacts on your desktop, custom ring tones per group and call with double-click

maemo.org - Talk (https://talk.maemo.org/index.php)

- Applications (https://talk.maemo.org/forumdisplay.php?f=41)

Re: [Announce] MyContacts - 75 contacts on your desktop, custom ring tones per group and call with double-click

Quote:

Originally Posted by uvatbc (Post 844450)

I just compiled a version of my binary with InitialAudio. It failed with exactly the same error as I had described. InitialAudio is the culprit!

It seems that the spirit CM "should" ignore it when used with EnsureChannel as mentioned in the docs, but it causes it to fail...

It is funny.... now I am wondering if I ever used the "audio call" to skype before ... When I first replied to you I was sure of it but now I am not anymore... I use it to start cellular calls and start skype chat sessions all the time but not sure if I ever used it to start audio calls... AT&T 3G does not work with the N900 so most of the times it is impossible to have a skype call while on cellular.

Back to the issue: I would have to agree with you that it seems like a "bug" on the skype CM like you said because:

1. Capablilites for the account return true for "supportsAudioCalls"

Code:

Tp::ConnectionCapabilities *pCap = m_account.data()->connection().data()->capabilities();

qDebug() << ">> supportsAudioCalls: " << pCap->supportsAudioCalls();

2. The allowed properties for the list of requestable channels return "StreamedMedia.InitialAudio".

Code:

    qDebug() << "----- requestable channels";

    Tp::RequestableChannelClassList list = pCap->requestableChannelClasses();

    foreach ( Tp::RequestableChannelClass klass, list) {

        QString channelType = klass.fixedProperties["org.freedesktop.Telepathy.Channel.ChannelType"].toString();



        // "org.freedesktop.Telepathy.Channel.Type.StreamedMedia"

        if  (channelType==TELEPATHY_INTERFACE_CHANNEL_TYPE_STREAMED_MEDIA) {

            qDebug() << ">> supports Streamed media";

            qDebug() << ">> properties: " << klass.allowedProperties;



            if ( klass.allowedProperties.contains(TELEPATHY_INTERFACE_CHANNEL ".Type.StreamedMedia.InitialAudio") ) {

                qDebug() << ">> supports audio";

            }



            if ( klass.allowedProperties.contains(TELEPATHY_INTERFACE_CHANNEL ".Type.StreamedMedia.InitialVideo") ) {

                qDebug() << ">> supports video";

            }

            continue;

        }

}

I couldn't find anything else that could help me "know" that I should not included the "initialaudio" when requesting the channel. If you know of anything else let me know.

Regardless, if it doesn't work it doesn't work!
Probably the easy/quick solution is to change mycontacts to omit the "initial audio" ... I will have to play a little bit to see what happens...

Not sure if you affect the "skype video" calls and even worst if will affect any other "telepathy account" (the code is generic).

Thank you very much for reporting it and helping me isolate the issue!

Re: [Announce] MyContacts - 75 contacts on your desktop, custom ring tones per group and call with double-click

Quote:

Originally Posted by fcrochik (Post 844532)

I couldn't find anything else that could help me "know" that I should not included the "initialaudio" when requesting the channel. If you know of anything else let me know.

The Freedesktop,org docs seem to imply that InitialAudio is going to be ignored when calling EnsureConnected but not if CreateChannel.
Your code (and mine) uses ensureConnected and so it should never send InitialAudio.

Re: [Announce] MyContacts - 75 contacts on your desktop, custom ring tones per group and call with double-click

Quote:

Originally Posted by uvatbc (Post 844544)

First let me say that I am not crazy :) :
I was/am able with the unmodified version of mycontacts to start skype audio calls to "skype accounts" from the widget, main window and online accounts window. I don't understand why it (always) fails for you.

I couldn't start a skype call to a phone number using the unmodified code (probably had never tried it before).

I wasn't able to start a video call with the unmodified version but not sure it is for the same reason or not.

One big problem then:
If according to the documentation I should not use the "initialaudio" nor the "initialvideo" with ensurechannel how can I get skype to start a video call instead of an audio call? Maybe I can't/shouldn't.... I assume that is why I started using the "initialaudio"/"initialvideo"

Do you know how what version of telepathy we have on the n900? I don't think it is the 0.2.0. Is it?

Re: [Announce] MyContacts - 75 contacts on your desktop, custom ring tones per group and call with double-click

Quote:

Originally Posted by fcrochik (Post 844554)

Interesting point about the video call - there ought to be a way for devs to begin a channel and specify "audio only" or "video only" or "audio+video". If it isn't possible at the time of channel creation at least there should be a way to enable it once the channel is established. Or something.

The n900 still has 0.19 I think.

Re: [Announce] MyContacts - 75 contacts on your desktop, custom ring tones per group and call with double-click

Quote:

Originally Posted by uvatbc (Post 844573)

I will post to the telepathy list to see if we get some guidance on how it should be done. I had just some example I found on the net to start with and got some advice here and there. Becuase it made sense to me and looked like it was doing what was supposed to I assumed it was right.

Still even by documentation you found it should have been ignored and not fail randomly in some cases. Worst of all it seems that it was written to take them into consideration becuase affects the result (that is how I got the video to start). If not enough does not even behave the same way when we start a call with a skypeid or with a phone number.

Re: [Announce] MyContacts - 75 contacts on your desktop, custom ring tones per group and call with double-click

Quote:

Originally Posted by fcrochik (Post 844594)

Your thought process makes sense. The only thing I remember while writing that code was "do just enough to make it work", because as far as I recall I used your code as reference point for my code.

Quote:

Originally Posted by fcrochik (Post 844594)

Still even by documentation you found it should have been ignored and not fail randomly in some cases. Worst of all it seems that it was written to take them into consideration becuase affects the result (that is how I got the video to start).

Yikes! But then its skype we're talking about. Quite a lot about it makes me say "yikes".

Re: [Announce] MyContacts - 75 contacts on your desktop, custom ring tones per group and call with double-click

Good (and bad) news!

The Good: The code on mycontacts is/was right (InitialAudio and InitialVideo) should be passed on ensureChannel. The idea is that they will ONLY be ignored if you are already in a call with the same contact.

The Bad: It won't for skype as it is! It seems that there is a bug on skype contact manager and it will fail with InitialAudio.

Bottom Line: I will create a new version of mycontacts that will not pass the InitialAudio for skype connections.

uvatbc: Thank you again for helping figure out this puzzle!

For a detailed explanation:
http://lists.freedesktop.org/archive...er/004989.html

Re: [Announce] MyContacts - 75 contacts on your desktop, custom ring tones per group and call with double-click

Soon we will have a new version of mycontacts but there is still a very old version (0.9.2) of mycontacts stuck on testing waiting for votes. I would like to have it promoted so I can have a new version there.

If you use mycontacts and like it please vote for it.

Thanks.

Re: [Announce] MyContacts - 75 contacts on your desktop, custom ring tones per group and call with double-click

Cant see nor choose contacts in mycontacts. Maybe because i am on PR1.3 now?

Re: [Announce] MyContacts - 75 contacts on your desktop, custom ring tones per group and call with double-click

Quote:

Originally Posted by gunni (Post 850538)

Cant see nor choose contacts in mycontacts. Maybe because i am on PR1.3 now?

Unfortunately yes. PR1.3 breaks mycontacts and the worst part is that if you run mycontacts after the upgrade you will loose your groups (all your settings will be saved but the contacts on each group will be removed).

EDIT:THERE IS A NEW VERSION OF MYCONTACTS ON EXTRAS-DEVEL THAT WORKS ON PR1.3 OUT OF THE BOX.

I will publish a new version of mycontacts soon but in the meanwhile:

IF YOU HAVEN'T STARTED MyContacts AFTER PR1.3 DON'T START JUST YET (READ FIRST):

1. If you have mycontacts running, select shutdown
2. You will have to edit the file

Code:

/home/user/.config/Crochik/MyContacts.conf

(*) the file is on a hidden folder - the easiest way to edit it is using vi on the xterminal

3. Change ONLY the line

Code:

Backend=maemo5-crochik

Code:

Backend=maemo5

4. Start the application again.