maemo.org - Talk

maemo.org - Talk (https://talk.maemo.org/index.php)
-   Maemo 5 / Fremantle (https://talk.maemo.org/forumdisplay.php?f=40)
-   -   [N900] Nokia Clock Replacement (https://talk.maemo.org/showthread.php?t=75425)

ade 2011-11-01 22:05

Re: [N900] Nokia Clock Replacement
 
Quote:

Originally Posted by toxaris (Post 1117059)
I dont change the 24h setting. All tho I notice that if I change 24h setting it doesnt change if I dont close clock.
Otherwise I follow the sequens in the pictures to reproduce the bug.



Yea, I sure Im using the replacement.
I can rotate and so on.
Strange that you can reproduce it.
I have rebooted and I can reproduce it again.
May be I should set regional to english and again back to swedish to trigger someting, will try that.

Very awkward that "13:00" is immediately translated in "1:00 PM". On my phone, 24-hr and am/pm notations do never mix.

Tests on other phones would be helpful now. Any volunteers ? :)

edoiks 2011-12-13 00:24

Re: [N900] Nokia Clock Replacement
 
1 Attachment(s)
Hi,

i have a problem, the labels of the buttons mix each other. I circled it on the picture. It is in new alarm window, repeat button. I think that there is not enough place for the polish label, probably you need add some extra space in a button for longer labels.

ade 2011-12-14 23:00

Re: [N900] Nokia Clock Replacement
 
edoiks,

I have shifted the conflicting text somewhat to the right so I assume it aligns correct in Polish now.

I updated the download which is referenced in the first post.

Please let us know if the adaptation was successful.

edoiks 2011-12-22 22:46

Re: [N900] Nokia Clock Replacement
 
I'm using clock replacement for a more than week and everything is OK.

artpra 2011-12-29 08:10

Re: [N900] Nokia Clock Replacement
 
First bug - when alarm starts, sometimes "Stop" and "Snooze" buttons places are mixed. "Stop" appears on the left, then next time is on the right. So instead of turning alarm off without even reading, I must read the screen every time, because I never know where that "Stop" button is (left or right?). It`s quite random.
Second bug - launch "Clock", select "New alarm", tap "Repeat", select any day(s), "Done". Short names of the days are now displayed in "New alarm" window at the "Repeat" button. They are displayed in wrong language, different then system one. My guess: it takes language from the "Regional settings" instead of "Device language" (in the "Regional settings" menu). Selecting "Never" and "Every day" for "Repeat" displays fine (in device language). BTW select many days for repeat and in portrait mode they are off the screen (not enough space) - some adjustment are needed (font size, text field position).
Third bug - leave "New alarm" window open for some time without any input. Sometimes it`s causing whole app to close. It`s rare.

Setup: PK49, DSP profile, newest CSSU, custom hildon desktop with locked portrait mode, newest clock binary.

artpra 2011-12-29 08:39

Re: [N900] Nokia Clock Replacement
 
One more thing - in the "World clocks" view, there is a redundant dot before date field.

PS - app closed itself when looking at the "World clocks" two times in last one minute so it`s not specific to "New alarm" window (third bug from previous post).

ade 2011-12-29 09:06

Re: [N900] Nokia Clock Replacement
 
Quote:

Originally Posted by artpra (Post 1143042)
One more thing - in the "World clocks" view, there is a redundant dot before date field.

PS - app closed itself when looking at the "World clocks" two times in last one minute so it`s not specific to "New alarm" window (third bug from previous post).

I do NOT notice a redundant dot in World clocks.

The application has the tendency to close itself after a while when it is not used. Don't know if it's a feature or bug. As long as it does not close then I'm actively using it I don't mind and actually find it convenient in most cases.

Estel 2011-12-29 16:09

Re: [N900] Nokia Clock Replacement
 
To be honest, I don't think any program should randomly close itself, until explicitly asked to (for example, timeout in settings). I also don't remember such "feature" in original worldclock, and this is a replacement, so it should not force such "features" in user (if no option to disable it), yep?

Not to mention, that - due to random nature of this "feature" - I'm quite convinced it is in fact a bug, segfaulting or whatsnot. Not a "feature" I would love to have.

Not demanding anything, just saying.

ade 2011-12-29 19:14

Re: [N900] Nokia Clock Replacement
 
Quote:

Originally Posted by artpra (Post 1143033)
First bug - when alarm starts, sometimes "Stop" and "Snooze" buttons places are mixed. "Stop" appears on the left, then next time is on the right. So instead of turning alarm off without even reading, I must read the screen every time, because I never know where that "Stop" button is (left or right?). It`s quite random.

Setup: PK49, DSP profile, newest CSSU, custom hildon desktop with locked portrait mode, newest clock binary.

I did about 25 alarm tests, all responding in the order [from left to right] Stop - Snooze. I did this in a mix of portrait and landscape positions. Maybe the combination of the locked portrait mode and the way the clock determines the landscape/portrait position leads to this "random" behavior.

artpra 2011-12-30 14:01

Re: [N900] Nokia Clock Replacement
 
Quote:

Originally Posted by ade (Post 1143052)
I do NOT notice a redundant dot in World clocks.

Take a look, it`s right before the date field:
http://img804.imageshack.us/img804/6...1123014501.jpg

Quote:

Originally Posted by ade (Post 1143052)
The application has the tendency to close itself after a while when it is not used. Don't know if it's a feature or bug.

Definitely a bug, no app should close itself like that without specific user preference to do so.

Quote:

Originally Posted by ade (Post 1143212)
I did about 25 alarm tests, all responding in the order [from left to right] Stop - Snooze.

Yeah, it`s quite strange - for the last two days no bug here too, so let`s classify it as "to be confirmed" by someone else. ;)

ade 2011-12-30 14:37

Re: [N900] Nokia Clock Replacement
 
Quote:

Originally Posted by artpra (Post 1143483)
Take a look, it`s right before the date field:
http://img804.imageshack.us/img804/6...1123014501.jpg

It now makes more sense to me (even if the picture is too small to see it).
Your date format is different. Mine is "DD-MM-YY" and not "DD/MM/YYYY" like you have.

So in my case it shows:
Code:

fri 30-12-11
  (GMT +1)

Your date of 30/12/2011 takes too much space and leaves just one line of pixel for the short dayname :D

ade 2012-01-02 23:16

Re: [N900] Nokia Clock Replacement
 
Quote:

Originally Posted by artpra (Post 1143033)
Second bug - launch "Clock", select "New alarm", tap "Repeat", select any day(s), "Done". Short names of the days are now displayed in "New alarm" window at the "Repeat" button. They are displayed in wrong language, different then system one. My guess: it takes language from the "Regional settings" instead of "Device language" (in the "Regional settings" menu). Selecting "Never" and "Every day" for "Repeat" displays fine (in device language).

Can confirm this. But most people won't notice it because they have their device language and regional setting the same.

For the full daynames and terms like "every day", the worldclock replacement uses the local message plugin from nokia. This is related to the device language.
For the short daynames, a QT function is used. QT always uses the local system settings, which is derived from the regional settings.

It took me a lot of work, but now the shortday names are based on HildonTranslation, which should give the local system short day names when entering a new alarm.
The short dayname in the worldclock section is still based on the local system settings. I might try to correct that in the future.

The new version can be downloaded from the link in the first post.

Let me know if issues are found because of the change.

sogoodbye 2012-01-03 10:17

Re: [N900] Nokia Clock Replacement
 
i rename the original one and copy urs into my usr/bin
after reboot my clock not function anymore..
anyone got the same problem with me?

ade 2012-01-03 10:43

Re: [N900] Nokia Clock Replacement
 
Quote:

Originally Posted by sogoodbye (Post 1144975)
i rename the original one and copy urs into my usr/bin
after reboot my clock not function anymore..
anyone got the same problem with me?

Maybe you miss executable permissions.

Can you try using the X-terminal:
Code:

/usr/bin/worldclock

sogoodbye 2012-01-03 11:10

Re: [N900] Nokia Clock Replacement
 
Quote:

Originally Posted by ade (Post 1144984)
Maybe you miss executable permissions.

Can you try using the X-terminal:
Code:

/usr/bin/worldclock

-sh: /usr/bin/worldclcok: permission denied

ivgalvez 2012-01-03 11:17

Re: [N900] Nokia Clock Replacement
 
Hi Ade, will you push the world clock replacement to CSSU testing?

ade 2012-01-03 11:19

Re: [N900] Nokia Clock Replacement
 
Quote:

Originally Posted by sogoodbye (Post 1144999)
-sh: /usr/bin/worldclcok: permission denied

Code:

chmod +x /usr/bin/worldclock
See if that helps.

end2begin 2012-01-03 11:36

Re: [N900] Nokia Clock Replacement
 
The clock replacement does not mute the alarm tone when the phone is switched to the Silent profile. A minor thing, but it tends to wake up my little daughter in the morning..

ivgalvez 2012-01-03 12:03

Re: [N900] Nokia Clock Replacement
 
Quote:

Originally Posted by end2begin (Post 1145017)
The clock replacement does not mute the alarm tone when the phone is switched to the Silent profile. A minor thing, but it tends to wake up my little daughter in the morning..

And, does the real clock mute the alarm? For me that would be a non desired feature, cause it's easy that you don't want to receive any call during the night but wake up in the morning.

ade 2012-01-03 12:15

Re: [N900] Nokia Clock Replacement
 
Quote:

Originally Posted by ivgalvez (Post 1145001)
Hi Ade, will you push the world clock replacement to CSSU testing?

Still not sure how to deal with this.
  • CepiPerez, who developed this clock replacement, seems only active on Meego and have lost interest in Maemo (like so many developers :(). He did not accept my patches nor reacted to a PM. So we may need another source repository, so others can see the recent code and work on it themselves.
  • As I mentioned before, I am not in favor of two clocks. Replacing the default clock means a big impact, especially if incorporated in CSSU. There might also be the option to put it in extra-devel as a separated app first.
  • Every now and then, minor things are found, so maybe it needs a little more time.
  • Should there be an official maintainer? I don't think I am the right person for that.

Having said that, I think I'll leave the situation as it is for now. But other people are free to step in :)

Estel 2012-01-03 18:30

Re: [N900] Nokia Clock Replacement
 
Quote:

Originally Posted by ade (Post 1145046)
Still not sure how to deal with this.[LIST][*]CepiPerez, who developed this clock replacement, seems only active on Meego and have lost interest in Maemo (like so many developers :(). He did not accept my patches nor reacted to a PM.

Yeah., thats what I call "responsible developer". Sure, everyone is free to shift interest into another project, but leaving without single note, and having messages about former projects in a.s.s. was always my 'favorite' thing that dev can do. Worth to know, who is not trustworthy one, if we ever meet in any platform.

Quote:

Originally Posted by ade (Post 1145046)
.[*]Should there be an official maintainer? I don't think I am the right person for that.

Yes, You are! :) Said that, I'm not demanding anything, of course. Thanks for the work You're doing, in any way.

/Estel

ivgalvez 2012-01-03 19:14

Re: [N900] Nokia Clock Replacement
 
Quote:

Originally Posted by ade (Post 1145046)
Still not sure how to deal with this.
  • CepiPerez, who developed this clock replacement, seems only active on Meego and have lost interest in Maemo (like so many developers :(). He did not accept my patches nor reacted to a PM. So we may need another source repository, so others can see the recent code and work on it themselves.
  • As I mentioned before, I am not in favor of two clocks. Replacing the default clock means a big impact, especially if incorporated in CSSU. There might also be the option to put it in extra-devel as a separated app first.
  • Every now and then, minor things are found, so maybe it needs a little more time.
  • Should there be an official maintainer? I don't think I am the right person for that.

Having said that, I think I'll leave the situation as it is for now. But other people are free to step in :)

I can honestly say that I think you are perfectly capable of becoming the new maintainer of World Clock replacement.

About how to deal with it, I don't see it as a standalone application, such as the Open Media Player, that could evolve outside the CSSU in the repos. The clock is part of the system, specially when managing alarms.

My suggestion is to push the sources to CSSU's gitorious under the testing branch, that doesn't mean it will become the default clock in next testing version of CSSU, but it will be more accessible to other CCSU developers that could build and test it in their own devices. I think right now it's pretty close to a stable state in which it could be installed by far more people.

Thanks, in any case, for your time spent on this project.

ade 2012-01-03 22:08

Re: [N900] Nokia Clock Replacement
 
I will try to upload the sourcecode to the community-ssu gitorious so the modifications can be seen (don't know if it will be allowed).

Meanwhile if have also adapted the shortdayname in worldclock section so it now obeys the devices settings instead of the country settings. For download see the first post (or direct download here: http://dl.dropbox.com/u/42147901/worldclock.zip)

bitrocky 2012-01-04 13:49

Re: [N900] Nokia Clock Replacement
 
Hi ade,
Is your version capable of automatically turning on the n900 for an alarm if it was turned off during night?
The prev version by cepi couldn't do that but the originial was enable to do that. I like that feature!

ade 2012-01-04 14:44

Re: [N900] Nokia Clock Replacement
 
I have never used that feature, but it sounds like an interesting option, especially if you are low on battery power.

If it was not available in CepiPerez's versions, it is still not available in the replacement clock.

No idea how that mechanism works, and don't know if it is documented somewhere. But it sounds like a complicated, low level something.

nicolai 2012-01-04 17:52

Re: [N900] Nokia Clock Replacement
 
Not that difficult. Take a look at
http://wiki.maemo.org/Documentation/...larm_Framework
and
http://maemo.org/api_refs/5.0/5.0-fi...balarm_8h.html
especially alarmeventflags
http://maemo.org/api_refs/5.0/5.0-fi...0a1c372999f681
CepiPerez used a flag called ALARM_EVENT_BOOT
But it seems this does not work as expected, it does
not show the alarm ui.
The builtin worldclock application uses the flag
ALARM_EVENT_ACTDEAD
That way, the alarm event boots up the device to acting dead mode
and shows the alarm ui. After you hit the "stop" button it asks for
booting the device.

You can compare the "flags:" property in /var/cache/alarmd/alarm_queue.ini for entries from
your worldclock application with the one
created by the builtin clock application.

ade 2012-01-04 20:01

Re: [N900] Nokia Clock Replacement
 
You almost made it a little too easy, even for me, Nicolai :D

Replacing the ALARM_EVENT_BOOT flag with ALARM_EVENT_ACTDEAD did the trick.

The device now gets booted just before the alarm time (if switched off). I updated the worldclock in http://dl.dropbox.com/u/42147901/worldclock.zip

But I still gonna read your useful links to get a better understanding of the alarm mechanism.

Maybe I might need a little more advice in the future or you could review the latest code adaptations (given the fact I am not a real QT/C++ developer). Judging on your specific advice, you have already looked into the code of the replacement clock.

bitrocky 2012-01-05 10:57

Re: [N900] Nokia Clock Replacement
 
Hi,

Automatic turning on the n900 from off works now, thanks!
Tried it last night:-)

But activating alarms doesn't work!

Weather by pressing the checkmark in the list or when I select the alarm and then pressing then activate button. The alarm isn't shown as activated in the alarmlist!
But nextalarm shows the alarm as activated! So it seems that only the alarmslist doesn't respect the activated flag!?

toxaris 2012-01-05 11:47

Re: [N900] Nokia Clock Replacement
 
Hello.

Just want to point out that I still got the problems with the new build reported in this post:
http://talk.maemo.org/showpost.php?p...&postcount=118

So from my point of view its far from ready to be a part of CSSU Testing.

ade 2012-01-05 12:15

Re: [N900] Nokia Clock Replacement
 
I asked others to test it as well (because I could not reproduce it), but no one stepped in :(

My guess is, it must have something to do with time/date format settings somewhere on the device.

And I agee that is should be reproduced and fixed before a possible CSSU test incorporation.

ade 2012-01-05 17:56

Re: [N900] Nokia Clock Replacement
 
It looks like I introduced some bug on one of the latest versions, indication that alarms are not active (but they are active).

Going to have a look at it now. Didn't receive reports about it here...


Update 1: it's the last change (device wakeup on alarm) that causes the alarms to be wrongly indicated as not active.
Update 2: looks like it is caused by different flag values needed to see the alarm active. Should be fixable I hope...
Update 3: Made a fix.
Update 4: Okay, I need more flags updated in case the alarm is repeated. So fix will be replaced soon..
Update 5: Fix for repeating alarms

Cause of wrongly displayed status:
Alarms created in the last version (with device wakeup on alarm) do generate a different flag because of that changed behavour. Consequently, worldclock did not mark them as being active in the alarmlist. Alarms entered before the last update where shown correctly, because they still had the old flag.

Now both old and new alarms should be shown correctly.

For people that downloaded the version of yesterday: please install this new version: http://dl.dropbox.com/u/42147901/worldclock.zip

bitrocky 2012-01-05 20:31

Re: [N900] Nokia Clock Replacement
 
Quote:

Originally Posted by ade (Post 1146233)
It looks like I introduced some bug on one of the latest versions, indication that alarms are not active (but they are active).

Going to have a look at it now. Didn't receive reports about it here...

I did!
Thats what I wanted to say with post #148:-)

ade 2012-01-05 20:38

Re: [N900] Nokia Clock Replacement
 
Quote:

Originally Posted by bitrocky (Post 1146316)
I did!
Thats what I wanted to say with post #148:-)

You did, I totally missed that post, sorry.

I hope this is fixed now, let me know if you still find an issue with (non)activated alarms. I will notice your post next time for sure :)

ade 2012-01-06 23:23

Re: [N900] Nokia Clock Replacement
 
Quote:

Originally Posted by artpra (Post 1143483)
Take a look, it`s right before the date field:
http://img804.imageshack.us/img804/6...1123014501.jpg

There is very little room to put all the worldclock information in one line, especially in portrait mode.
Depending on your local settings, the date in the worldclock part is shown in formats like dd/mm/yyyy, or dd-mm-yy.

I decided to remove the century part in all cases, meaning 20/12/2010 will now be shown as 20/12/10. This creates some precious extra space. If your phone settings did not display the century info, nothing will change of course. In my case (testing with dd/mm/yyyy as previous format), the date info is now never cut off. But for some fonts it may still be the case that a little part is missing.

Update: some formats start with yyyy (like when setting swedish). These are changed as well now.

8 january new Update: Using portrait mode and having short daynames of three characters (like Sun) could not fit properly if 6 days are chosen for alarm repeat. This has also to do with the extra space I gave the "repeat" label (rather large in polish :)).
To make it fit, I removed the spaces after the comma seperator.


Newest version as always http://dl.dropbox.com/u/42147901/worldclock.zip

If found, please report back related issues.

miqu 2012-01-12 17:08

Re: [N900] Nokia Clock Replacement
 
Hi ade,

Thanks for standing up and continuing this. It seems really close to beeing done.

Though I found a bug. Using Finnish language and locale the clock times get wrongly set. It doesn't matter what I select from the hour roller, it gets put in as a zero. The marker (.) between hour and minute is different I suspect. The field shows a value 19.00 if I select 19 on the hour and 00 on the minute. It gets translated to 00:19 when I press save.

Setting the time from top menu works as supposed. The field in that screen has the right marker (:) between hours and minutes.

Hope you have time to fix it. :)

ade 2012-01-12 22:07

Re: [N900] Nokia Clock Replacement
 
Quote:

Originally Posted by miqu (Post 1149578)
Hi ade,

Thanks for standing up and continuing this. It seems really close to beeing done.

Though I found a bug. Using Finnish language and locale the clock times get wrongly set. It doesn't matter what I select from the hour roller, it gets put in as a zero. The marker (.) between hour and minute is different I suspect. The field shows a value 19.00 if I select 19 on the hour and 00 on the minute. It gets translated to 00:19 when I press save.

Setting the time from top menu works as supposed. The field in that screen has the right marker (:) between hours and minutes.

Hope you have time to fix it. :)

Looks like no one else from Finland is using the replacement clock, or they all use foreign setting for their device :)

Ones switch to Finnish I noticed the problem instantly.

Is the time format "hh.mm" used in Finland? Somehow Qt sees it as a locale format. The stock alarm program uses the more regular "hh:mm" format for the hour and minute notation in Finnish.

Also noticed some other things with the Finnish settings :
- worldclock warns about an invalid date (could be harmless)
- The clock icon overlaps the alarm time in the alarm list
- using 12 hour clock notation gave some problems that look identical to the issues Toxaris noticed in Swedish and I could not reproduce.

Maybe I will switch my phone back to Finnish this weekend and have a further look at this.

But for now I hope to have fixed your specific issue: It replaces the "." with a ":" when the format is determined, so the rest of the program understands it.
Perhaps I will remove this format conversion part ones I am sure it has no use. Now it always expects "hh:mm" anyway....

Newest version as always http://dl.dropbox.com/u/42147901/worldclock.zip

ed_boner 2012-01-12 22:43

Re: [N900] Nokia Clock Replacement
 
damn...i installed this a few months ago and i love it...since then i have been trying to keep up with the uopdates but every version i out in the designated folder gives me a crash every time on clock app..:(

miqu 2012-01-12 22:50

Re: [N900] Nokia Clock Replacement
 
@ed_boner:
Quick thought, are you remembering to chmod the file so that it can be excecuted?

After copying the file over.
Code:

chmod 755 /usr/bin/worldclock
@ade

Nice, thanks I will pick it up now. :)

I think we use 19:25 times here in Finland. Qt might have a bug on that?

edit:
Didnt work yet but I can use my old alarms just fine.

It seems that we the Finns are using the point as a separator in times. So not a qt bug. But I do think you should propably have a method "char getTimeSeparatorMarker(locale)" in a localization avare library like QT? I dont know the internals yet, so just throwing a thought.

http://fi.wikipedia.org/wiki/Piste_%...%A4limerkki%29
"Ajanilmauksissa tunnit, minuutit ja sekunnit erotetaan toisistaan pisteellä, esimerkiksi kello 14.15." from the wiki page says so in Finnish. :)

ade 2012-01-12 23:24

Re: [N900] Nokia Clock Replacement
 
Quote:

Nice, thanks I will pick it up now. :)

I think we use 19:25 times here in Finland. Qt might have a bug on that?

edit:
Didnt work yet but I can use my old alarms just fine.

It seems that we the Finns are using the point as a separator in times. So not a qt bug. But I do think you should propably have a method "char getTimeSeparatorMarker(locale)" in a localization avare library like QT? I dont know the internals yet, so just throwing a thought.

http://fi.wikipedia.org/wiki/Piste_%...%A4limerkki%29
"Ajanilmauksissa tunnit, minuutit ja sekunnit erotetaan toisistaan pisteellä, esimerkiksi kello 14.15." from the wiki page says so in Finnish. :)
Thanks for finding the info. Hope to find a proper way to deal with this.

I know why the new version did not work
: my dropbox client is giving issues so it did not upload. Please download again for a proper test.

miqu 2012-01-12 23:52

Re: [N900] Nokia Clock Replacement
 
Quote:

I know why the new version did not work: my dropbox client is giving issues so it did not upload. Please download again for a proper test.
Thanks man it works nice now. :)

Do you have a donate button somewhere? I'd love to hand over a beer or whatever you like.


All times are GMT. The time now is 21:14.

vBulletin® Version 3.8.8