maemo.org - Talk

maemo.org - Talk (https://talk.maemo.org/index.php)
-   SailfishOS (https://talk.maemo.org/forumdisplay.php?f=52)
-   -   [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak (https://talk.maemo.org/showthread.php?t=92935)

coderus 2018-06-29 22:33

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
tell exact sfos version, then someone can upload matching lipstick contents

elastic 2018-06-29 23:10

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
2.2.0.29 many thanks

coderus 2018-06-30 09:17

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
Grab rpm from https://coderus.openrepos.net/lipsti...10.armv7hl.rpm

elastic 2018-06-30 22:52

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
Thanks for the rpm

Is there any other way to get the rpm on the phone than through the sd and mounting it in recovery mode as I’m abroad for work and of cource didn’t carry a sd card reader for my laptop ...

Sorry for bothering

olf 2018-07-01 01:44

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
Updated list of non-conflicting Patches (which I have installed), and Patches conflicting with or being an alternative to them (which I have looked at, so far), for SFOS 2.2.0 (post #2433 was for SFOS 2.1.4) with Patchmanager 2.3.3-10.41.1 or 3.0.56 (or higher).
Note that in order to install some of the Patches listed below from Patchmanager's web-catalog, one has to activate "Enable developer mode" in Patchmanager's pulley menu (so it shows "Disable developer mode" there), as a few the Patch authors missed to mark their Patches as compatible with this SFOS release; never mind, because if a Patch is really incompatible with the installed SailfishOS version, it will not apply when trying to activate it in Patchmanager's main menu.

Format: - <Patch name> <my rating>, <Patch author>, <Source: wc (Patchmanager's web catalog) | RPM (e.g. via Storeman)> [, <alt (alternative) | cts (contains) | "cts" (contains similar or same functionality) | cnf (just conflicts)>: <Patch name> <my rating>, <Patch author>, <wc | RPM>]

"My rating" resolves as follows:
- (+): Nice to have
- (++): Very good
- (+++): IMO a must
No "rating" indicates, that I have not used this Patch long enough to rate it.

Patches listed as an alternative (alt) to and / or contained (cts / "cts") in a Patch implicitly conflict with it (i.e. they cannot be applied together in Patchmanager, as they are patching the same locations of the SFOS UI).

Browser:
- Refresh browser cover (+), Markkyboy, RPM
- Right-handed tabs / "Right handed close icon for tabs (Sailfish Browser)" (+), Markkyboy, RPM
- Sailfish Browser bigger select tags (+), Markkyboy, RPM
Calendar:
- Add more calendars (++), Schturman, RPM
- Led missed calendar events (+), Schturman, RPM
- Widget date hint 2 / "Time hint for calendar widget" (+), Markkyboy, RPM
- Don't start/end events at midnight (++), Luen, wc
Camera:
- Camera overlay & bezel setting (+), Schturman, RPM
- Flip front camera view (+), Markkyboy, RPM
Clock:
- Auto snooze & snooze interval (++), Schturman, RPM
- Clock app cover actions (+), alina, RPM
- Clock in alarms (+), Markkyboy, RPM
- Separate alarm flipover (++), Ancelad, wc
Contacts:
- Hide recent contacts (+), Ancelad, RPM
Email:
- Enhanced email cover (+), Ancelad, wc
- Transparent email background (+), Markkyboy, RPM (only for Patchmanager 3!)
Gallery
Homescreen:
- Add new folder icons (+++), Schturman, RPM,
alt: Launcher combined (original), coderus, wc,
alt: Launcher Combined Patch, jayki, wc,
alt: Launcher Combined Patch, Thaodan, RPM
- Don't freeze app on peek (+), cornerman, RPM
- Don't steal focus (++), cornerman, RPM
- Event screen date & text (+++), Schturman, RPM
- Force cover size (+), Eugenio, RPM
- Free Rotate for Phone / "Allow any orientation except inverted portrait for SailfishOS apps" (+++), alina, RPM,
alt: Allow any rotation (+++), coderus, wc / RPM
- Improved notification preview (++), Ingvx, RPM,
cnf: No message preview on device lock, alina, RPM
- Instantly hide digits (++), babba22, RPM
- Lockscreen media buttons (++), alina, RPM
- Lockscreen pulley at home (++), cornerman, RPM
- More notifications on lockscreen (++), Ancelad, RPM
- Replace eventsview setting by general setting (++), lp35, RPM
- Switcher click hints Launcher (++), cornerman, RPM
- Ultimate statusbar patch (+++), Ancelad, RPM (v2.0.2.49-1 for Patchmanager 2, v2.0.2.49-3 for PM3)
alt/cts: Show all indicators on lockscreen (++), alina, RPM,
alt/"cts": Statusbar background, toxip, wc,
alt/"cts": Dimming hint for statusbar, alina, RPM
- Volume control settings (++), alina, RPM
- Add more shortcuts into lockscreen pulley (+), Ancelad, wc
- Lockscreen analog clock (+++; analog clock is optional!), Ancelad, wc,
cts: Show weather on lockscreen (+++) , Ancelad, RPM,
"cts": Seconds on Lockscreen clock (+), Markkyboy, RPM,
cts: Fix landscape lockscreen clock, Ancelad, RPM
- Devicelock faith text (++), Ancelad, wc
- Disable volume warning (+++), Ancelad, RPM
- Enhanced Power Menu (+++), Ancelad, RPM,
alt: Quick settings on power menu (++), alina, RPM
- Eventsview control (++), Ancelad, wc,
cnf: Quick settings on power menu (++), alina, RPM
Media:
- Extended mediaplayer cover (+), Ancelad, RPM
Messages:
- Messages layout (+++), alina, RPM
Other:
- Actdead charging clock (+), unai_i, RPM
- Autocapitalization settings (+++), alina, RPM
- Contacts app cover action (+), alina, RPM
- More readable calculator result-label (+), Ancelad, RPM
- Notes app cover (+), alina, RPM
- Remove space before punctuations (++), alina, RPM
- Back-Button Gesture for Android-Apps (+++), jakibaki, wc
- Swipe cursor by swiping on the keyboard (++), jakibaki, wc
Phone:
- Clock in call view (+), Markkyboy, RPM
- Voicecall combined patch (+++), Ancelad, wc,
alt/cts: Better CallLog.Alternative version (++), virgi-26, RPM,
alt/"cts": CallLog timestamps for yesterday and older entries, muppis, RPM
Settings:
- BT timer (+), Schturman, RPM
- Backup reminder (+), Schturman, RPM
- Custom hostname (++), Schturman, RPM
- Settings cover (+), alina, RPM
- Shutdown screen (+), Schturman, RPM
- Unapply all patches (+++), Schturman, RPM
- Unapply all patches on Upgrade, coderus, built-in
- Display sneak peek (LPM) (+), coderus, wc,
alt (but cnf: Ultimate Statusbar!): Sneak Peek option (+), alina, RPM
Silica:
- Return old remorse item animation (+), Ancelad, RPM
- Return old remorse popup animation (+), Ancelad, RPM
- Combined pulley menu (++), Ancelad, wc,
alt: Return old pulley menu (+), Ancelad, wc,
alt: Faster Pulley Menus, nodevel, RPM
- Remorse timeout control (++), Ancelad, wc

And if you like to disable these functions:
- No automatic launcher hint, cornerman, RPM
- Less home animations, cornerman, RPM

... or add this functionality:
- MazeLock, coderus, wc,
alt: Scramble lockpad buttons, coderus, wc

If you like to make more items available in the events-view quick-actions, take a look at the Patches by alina found via the search term quick action and at the "Non-Patches" by Markkyboy found via the search term quickaction at OpenRepos.
If you like alina's "Remove black ..."-series (suited for bright Ambiences), "... from dialogs and bars", "... from launcher" and "... from Browser background" are working together with above Patch list (in contrast to "... from remorse popup", "Status bar hint" and consequently "Integrative remove black", which conflict with Patches listed above).

Unfortunately, these Patches are not (yet) compatible with SFOS 2.2.0:
- Notifications count in Switcher (++), coderus, wc (last working under SFOS 2.1.2)
- GPS supplier (+; solely for Jolla 1 phones!), Schturman, RPM (last working under SFOS 2.1.0)
- Show month and days of the week heading in Calendar (++), pichlo, RPM (last working under SFOS 1.1.9)

P.S.: As YMMV (just as everybody's, including mine over time), please refrain from criticising my preferences (WRT chosen functionalities) or my (certainly) subjective "ratings".

And still, any suggestions to enhance this list are welcome.

coderus 2018-07-01 08:35

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
Quote:

Originally Posted by elastic (Post 1545916)
Thanks for the rpm

Is there any other way to get the rpm on the phone than through the sd and mounting it in recovery mode as I’m abroad for work and of cource didn’t carry a sd card reader for my laptop ...

Sorry for bothering

in recovery you can enable ssh session

elastic 2018-07-01 14:34

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
@coderus

many thanks for the file - I've been able to reinstall lipstick, and it worked (the install) as my lockscreen now doesn't show the calendar anymore .... but ... the login screen still shows only the background - no dialer buttons ... so I'm still locked out ... is there by any chance a possibility to disable the login from the terminal - As I have to unlock it in the Terminal anyway it won't be a security flaw if it's possible ..

or any other ideas?

coderus 2018-07-01 18:33

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
I think you also need to reinstall https://coderus.openrepos.net/sailfi....6.armv7hl.rpm

elastic 2018-07-01 19:57

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
Quote:

Originally Posted by coderus (Post 1545926)

Thanks again
unfortunately this didn't do the trick - behavior is still the same - no dialpad for entering the code anything else I could reinstall

olf 2018-07-01 21:53

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
Quote:

Originally Posted by elastic (Post 1545927)
[...] unfortunately this didn't do the trick - [...]

You may try if version --verify shows a package (RPM) as missing or installed in a wrong version.

olf 2018-07-02 20:53

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
@Ancelad, I was so happy to see you maintaining the "AlienDalvik runtime indicator" in Ultimate stausbar patch (despite the implementation hurdles your noted) up to version 2.1.3.7-3 (at least on Jolla 1 phones), as it is very useful (for me and others).

But with version 2.2.0.29-1 the "AlienDalvik runtime indicator" (rsp. its setting) is gone (again)!
Was that done deliberately or is it just a bug (maybe in the device detection)?

Is there any chance to bring it back (at least on Jolla 1 phones)?

Side note: If you want me to execute tests for debugging (e.g. obtaining logs, for example from PM3) on Jolla 1 and Xperia X phones, just let me know.

Ancelad 2018-07-03 06:37

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
@olf
it's still buggy, but there is a chance to do something with PM3 safety mechanism. But I have no time at all.

olf 2018-07-03 17:42

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
Quote:

Originally Posted by Ancelad (Post 1545957)
it's still buggy, but there is a chance to do something with PM3 safety mechanism. But I have no time at all.

Thank you for still considering to fix the "AlienDalvik runtime indicator" in Ultimate statusbar patch someday.

Markkyboy 2018-07-07 14:10

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
Hi all,

I'm attempting to make a patch based on this conversation on together.jolla.com; https://together.jolla.com/question/...post-id-179408 ~ problem is no matter what I do with this file `/usr/share/jolla-email/pages/htmlViewer.css` the finished patch will not apply, all I get is "Failed to apply patch".

When attempting to apply a patch, I get errors found in patchmanager.log, one after another, like;
Code:

patch: **** malformed patch at line "?"
where '?' could be any line number. I've edited just about every line because of this message, but I've a feeling I'm on the road to nowhere. One forum I looked on suggested that spacing was a problem, so I spaced the start of every line of code but still it didn't help.

Is it not possible in general, to patch a .css file?

coderus 2018-07-07 15:00

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
how do you create patch? putting random lines together? use git.

Markkyboy 2018-07-07 15:06

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
The data is not random. I can add the data manually and I get the effect I want, but if I try to use that same data to patch the file in question, I cannot apply the patch.

I don't know how to use git and haven't needed it so far, I'll look into it.

The rpm patch that won't apply is one I emailed to you earlier; sailfishos-patch-transparent-email-background, install and try to apply, it fails. The patch file is patching 4 different files, but only the htmlViewer.css is causing problems and I don't know how to get round it.

coderus 2018-07-07 15:35

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
https://docs.moodle.org/dev/How_to_create_a_patch

Markkyboy 2018-07-09 11:56

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
After more rigorous testing, I decided to swap to my other Jolla1 - on which the mail patch works flawlessly (I guess there is something adrift on my 1st Jolla1).

I offer the patch here and on TJC for testing and purposes of feedback. Please report all your findings here on this thread.

It works fine on my second device. It installs/applies/uninstalls without a hitch, the question is, does it do the job it was designed to do?.......I get all kinds of emails and so far, from what I can see, the background stays transparent, making emails much easier on the eyes, especially in the night/first thing in the morning.

PATCH: Transparent email background;

https://www.dropbox.com/s/qcyipsqbus...oarch.rpm?dl=0

Caution: Despite not finding any serious problems by using this patch, you use this file purely at your own risk.

kneeli 2018-07-09 15:42

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
@Markkyboy

I do prefer to increase the font size for text mail:

/usr/share/jolla-email/pages/PlainTextViewer.qml

from:
Code:

font.pixelSize: Screen.sizeCategory >= Screen.Large ? Theme.fontSizeSmall : Theme.fontSizeExtraSmall
to:
Code:

font.pixelSize: Screen.sizeCategory >= Screen.Large ? Theme.fontSizeMedium : Theme.fontSizeSmall



Some time before, there was one option more in silica webview to change:

/usr/lib/qt5/qml/Sailfish/Silica/SilicaWebView.qml

from:
Code:

color: webView.experimental.transparentBackground ? "transparent" : "white"
to:
Code:

color: webView.experimental.transparentBackground ? "transparent" : "transparent"
but since last update it may not necessary anymore.


I will try you're css file, because mine is very different. I'm exited. Thanks a lot for doing this job done!



I made also some changes on the htmlViewer component, because some emails got rendered totally unreadable, therefore I did the following changes:

/usr/share/jolla-email/pages/HtmlViewer.qml

from:
Code:

// Respect viewport meta tag if exists
        if (!hasViewportMetaTag(htmlBody)) {
            // This affects only to layouts that do not have width defined in body content.
            // Smaller content layout gets scaled up to WebView's width. Basically meaning that
            // html text emails will get scaled up by factor (1.5*Theme.pixelRatio) rounded to nearest half.
            // With higher scale factor content layouts starts touching edges of WebView and that hinders
            // legibility. Thus, this 1.5 base factor.
            var scale = Math.round((1.5 * Theme.pixelRatio) / .5) * .5
            experimental.customLayoutWidth = width / scale
        } else {
            experimental.customLayoutWidth = width
        }
        // reload html
        loadHtml(htmlBody, "file:///usr/share/jolla-email")
    }


to:

Code:

// Respect viewport meta tag if exists
      //if (!hasViewportMetaTag(htmlBody)) {
            // This affects only to layouts that do not have width defined in body content.
            // Smaller content layout gets scaled up to WebView's width. Basically meaning that
            // html text emails will get scaled up by factor (1.5*Theme.pixelRatio) rounded to nearest half.
            // With higher scale factor content layouts starts touching edges of WebView and that hinders
            // legibility. Thus, this 1.5 base factor.
            //var scale = Math.round((1.5 * Theme.pixelRatio) / .5) * .5
            //experimental.customLayoutWidth = webView.width / scale
        //} else {
            experimental.customLayoutWidth = 350
        //}
        // reload html
        //loadHtml(htmlBody, "file:///usr/share/jolla-email")
        webView.loadHtml(htmlBody, "file:///usr/share/jolla-email")
        onScreen = true
    }


coderus 2018-07-09 15:59

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
One big question: why you patch /usr/lib/qt5/qml/Sailfish/Silica/SilicaWebView.qml file???

Markkyboy 2018-07-09 17:13

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
Quote:

Originally Posted by coderus (Post 1546089)
One big question: why you patch /usr/lib/qt5/qml/Sailfish/Silica/SilicaWebView.qml file???

If you read the original thread on TJC, you'd understand that I didn't write/edit or choose the files used, the author of that original post provided the data.

This is not a case of admonishing myself of any responsibility, but I took the given files and with some messing around, made a working patch

So, you tell me why that file didn't need patching?

Markkyboy 2018-07-09 17:19

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
Quote:

Originally Posted by kneeli (Post 1546088)
@Markkyboy

I do prefer to increase the font size for text mail:

/usr/share/jolla-email/pages/PlainTextViewer.qml

from:
Code:

font.pixelSize: Screen.sizeCategory >= Screen.Large ? Theme.fontSizeSmall : Theme.fontSizeExtraSmall
to:
Code:

font.pixelSize: Screen.sizeCategory >= Screen.Large ? Theme.fontSizeMedium : Theme.fontSizeSmall



Some time before, there was one option more in silica webview to change:

/usr/lib/qt5/qml/Sailfish/Silica/SilicaWebView.qml

from:
Code:

color: webView.experimental.transparentBackground ? "transparent" : "white"
to:
Code:

color: webView.experimental.transparentBackground ? "transparent" : "transparent"
but since last update it may not necessary anymore.


I will try you're css file, because mine is very different. I'm exited. Thanks a lot for doing this job done!



I made also some changes on the htmlViewer component, because some emails got rendered totally unreadable, therefore I did the following changes:

/usr/share/jolla-email/pages/HtmlViewer.qml

from:
Code:

// Respect viewport meta tag if exists
        if (!hasViewportMetaTag(htmlBody)) {
            // This affects only to layouts that do not have width defined in body content.
            // Smaller content layout gets scaled up to WebView's width. Basically meaning that
            // html text emails will get scaled up by factor (1.5*Theme.pixelRatio) rounded to nearest half.
            // With higher scale factor content layouts starts touching edges of WebView and that hinders
            // legibility. Thus, this 1.5 base factor.
            var scale = Math.round((1.5 * Theme.pixelRatio) / .5) * .5
            experimental.customLayoutWidth = width / scale
        } else {
            experimental.customLayoutWidth = width
        }
        // reload html
        loadHtml(htmlBody, "file:///usr/share/jolla-email")
    }


to:

Code:

// Respect viewport meta tag if exists
      //if (!hasViewportMetaTag(htmlBody)) {
            // This affects only to layouts that do not have width defined in body content.
            // Smaller content layout gets scaled up to WebView's width. Basically meaning that
            // html text emails will get scaled up by factor (1.5*Theme.pixelRatio) rounded to nearest half.
            // With higher scale factor content layouts starts touching edges of WebView and that hinders
            // legibility. Thus, this 1.5 base factor.
            //var scale = Math.round((1.5 * Theme.pixelRatio) / .5) * .5
            //experimental.customLayoutWidth = webView.width / scale
        //} else {
            experimental.customLayoutWidth = 350
        //}
        // reload html
        //loadHtml(htmlBody, "file:///usr/share/jolla-email")
        webView.loadHtml(htmlBody, "file:///usr/share/jolla-email")
        onScreen = true
    }


Thanks kneeli, I will certainly look into making the changes you suggest. Please refer to the original post on TJC, as the original data is not mine or written by me; https://together.jolla.com/question/...-email-client/

kneeli 2018-07-09 18:09

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
Quote:

Originally Posted by coderus (Post 1546089)
One big question: why you patch /usr/lib/qt5/qml/Sailfish/Silica/SilicaWebView.qml file???

to make it possible to have transparent html email view.

kneeli 2018-07-09 18:11

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
Quote:

Thanks kneeli, I will certainly look into making the changes you suggest. Please refer to the original post on TJC, as the original data is not mine or written by me;
Yes I know this tread, I was the initiator of it.

Markkyboy 2018-07-09 19:00

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
Quote:

Originally Posted by kneeli (Post 1546095)
Yes I know this tread, I was the initiator of it.

Lol, fair enough, the username wasn't familiar ;)

kneeli 2018-07-09 20:07

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
Quote:

Lol, fair enough, the username wasn't familiar
Maybe I'm bit paranoid, I do use my password generator for usernames as well O:-)

Markkyboy 2018-07-09 20:22

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
Quote:

Originally Posted by kneeli (Post 1546104)
Maybe I'm bit paranoid, I do use my password generator for usernames as well O:-)

That's a good idea, I've never thought of that way of picking a username, nice one.

I'm attempting your suggestions now, but I'm tired an have managed to produce 2 RPM's that fail to install/apply.........yawn. Will try again tomorrow.

Thanks for the patch :)

coderus 2018-07-10 06:59

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
Quote:

Originally Posted by Markkyboy (Post 1546091)
So, you tell me why that file didn't need patching?

/usr/share/jolla-email/pages/HtmlViewer.qml of course. No need to mess any other webkit-based browser view with your patch.

coderus 2018-07-10 06:59

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
Quote:

Originally Posted by kneeli (Post 1546094)
to make it possible to have transparent html email view.

in the past email did not provide qml files, nowadays you can patch it. no need to mess systemwide plugins. please.

Markkyboy 2018-07-10 08:36

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
Quote:

Originally Posted by kneeli (Post 1546088)
@Markkyboy

I do prefer to increase the font size for text mail:

/usr/share/jolla-email/pages/PlainTextViewer.qml

from:
Code:

font.pixelSize: Screen.sizeCategory >= Screen.Large ? Theme.fontSizeSmall : Theme.fontSizeExtraSmall
to:
Code:

font.pixelSize: Screen.sizeCategory >= Screen.Large ? Theme.fontSizeMedium : Theme.fontSizeSmall



Some time before, there was one option more in silica webview to change:

/usr/lib/qt5/qml/Sailfish/Silica/SilicaWebView.qml

from:
Code:

color: webView.experimental.transparentBackground ? "transparent" : "white"
to:
Code:

color: webView.experimental.transparentBackground ? "transparent" : "transparent"
but since last update it may not necessary anymore.


I will try you're css file, because mine is very different. I'm exited. Thanks a lot for doing this job done!



I made also some changes on the htmlViewer component, because some emails got rendered totally unreadable, therefore I did the following changes:

/usr/share/jolla-email/pages/HtmlViewer.qml

from:
Code:

// Respect viewport meta tag if exists
        if (!hasViewportMetaTag(htmlBody)) {
            // This affects only to layouts that do not have width defined in body content.
            // Smaller content layout gets scaled up to WebView's width. Basically meaning that
            // html text emails will get scaled up by factor (1.5*Theme.pixelRatio) rounded to nearest half.
            // With higher scale factor content layouts starts touching edges of WebView and that hinders
            // legibility. Thus, this 1.5 base factor.
            var scale = Math.round((1.5 * Theme.pixelRatio) / .5) * .5
            experimental.customLayoutWidth = width / scale
        } else {
            experimental.customLayoutWidth = width
        }
        // reload html
        loadHtml(htmlBody, "file:///usr/share/jolla-email")
    }


to:

Code:

// Respect viewport meta tag if exists
      //if (!hasViewportMetaTag(htmlBody)) {
            // This affects only to layouts that do not have width defined in body content.
            // Smaller content layout gets scaled up to WebView's width. Basically meaning that
            // html text emails will get scaled up by factor (1.5*Theme.pixelRatio) rounded to nearest half.
            // With higher scale factor content layouts starts touching edges of WebView and that hinders
            // legibility. Thus, this 1.5 base factor.
            //var scale = Math.round((1.5 * Theme.pixelRatio) / .5) * .5
            //experimental.customLayoutWidth = webView.width / scale
        //} else {
            experimental.customLayoutWidth = 350
        //}
        // reload html
        //loadHtml(htmlBody, "file:///usr/share/jolla-email")
        webView.loadHtml(htmlBody, "file:///usr/share/jolla-email")
        onScreen = true
    }


Kneeli - your code shown for HtmlViewer.qml does not match what I have. I'm on SFOS 2.2.0.29 - which version are you using?

Kabouik 2018-07-10 10:30

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
Is anyone interested in adopting and maintaining the great patch named No home carousel? Unfortunately, Cornerman is not using Sailfish anymore and he is looking for a maintainer: https://github.com/cornerman/sailfis...ment-403765302

This patch greatly improved (in my opinion) the user experience by restoring the "one swipe direction = one feature" spirit of early Sailfish versions before everything was made less consistent to conform with the introduction of partnerspace. It also improved the task switcher page by allowing quick close gestures on covers, and allowed swiping events in the Events page to remove them without changing page.

The comments on OpenRepos show how much this patch was appreciated, as it had a great impact on whole UI.

kneeli 2018-07-10 10:32

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
Quote:

Originally Posted by coderus (Post 1546112)
in the past email did not provide qml files, nowadays you can patch it. no need to mess systemwide plugins. please.

Ok. you are right.

@Markkyboy
Please discharge all changes made on file /usr/lib/qt5/qml/Sailfish/Silica/SilicaWebView.qml

Instead insert in file /usr/share/jolla-email/pages/HtmlViewer.qml
at around line 24 the following:

experimental.transparentBackground: true

that's enough, I tried it already.

kneeli 2018-07-10 11:22

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
Quote:

Originally Posted by Markkyboy (Post 1546113)
Kneeli - your code shown for HtmlViewer.qml does not match what I have. I'm on SFOS 2.2.0.29 - which version are you using?

is in function
Code:

function setHtml(html) {
}

The sailfish mail app, does show many html mails in desktop view. Sometimes there even not zoom able, so unreadable at all.

In this function jolla-email does count the viewport, which seems to be buggy sincs version 1

I just defined a fix viewport with 300, which make nearly all html emails readable and shows them up in mobile view if there responsive.

Just replace this function with:
Code:

    function setHtml(html) {
        htmlBody = html
            experimental.customLayoutWidth = 300
        webView.loadHtml(htmlBody, "file:///usr/share/jolla-email")
        onScreen = true
    }


Markkyboy 2018-07-10 18:30

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
Man, did I get in a muddle!, 35c here, fitting a new bathroom and compiling this patch, I am cooked!!

Anyway, I can now see the new changes that have been made, text looks a little too big in HTML emails, but is now very readable and plain emails also are now easily readable, see what you guys think!

As usual, all users try this second version at their own risk, it installs/applies & functions correctly on my ageing Jolla1;

https://www.dropbox.com/s/d66q7kojnc...oarch.rpm?dl=0

kneeli 2018-07-10 20:33

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
Quote:

Originally Posted by Markkyboy (Post 1546129)
text looks a little too big in HTML emails

Here on my device, sometimes too big, mostly perfect. I have the XperiaX, I don't know how does it look an screens with more less resolution.
But anyhow, sometimes too big is far better as sometimes too tiny and not zoomable.

I just looked an you're patch, it seems all parts to be fine.

You're CSS file is well formatted. I changed mine, with you're version.

kneeli 2018-07-10 20:43

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
Quote:

Originally Posted by Markkyboy (Post 1546129)
As usual, all users try this second version at their own risk, it installs/applies & functions correctly on my ageing Jolla1

ok. I had a small mistake, because my HtmlViewer.qml file was a little bit older

line 98 in you're patch file should be:
Code:

loadHtml(htmlBody, "file:///usr/share/jolla-email")
But I think it is also working with the "webView." before. You can try to increase the with from 300 to 480 and see, if the text size got smaller.

Markkyboy 2018-07-10 21:17

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
Quote:

Originally Posted by kneeli (Post 1546136)
ok. I had a small mistake, because my HtmlViewer.qml file was a little bit older

line 98 in you're patch file should be:
Code:

loadHtml(htmlBody, "file:///usr/share/jolla-email")
But I think it is also working with the "webView." before. You can try to increase the with from 300 to 480 and see, if the text size got smaller.

Cool, yeah, I've just tried 480, for me it's a little too small, so I set at 400 instead, which looks pretty good on my Jolla1. Also line 98 changed to your specification.

Thanks for the code! :)

PATCH VERSION THREE:

https://www.dropbox.com/s/f5xbhgjczl...oarch.rpm?dl=0

I think this is ready to be offered on Openrepos

Markkyboy 2018-07-11 10:49

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
@coderus

Is this 'categories' list an exhaustive list of Patchmanager categories or are there more?

https://github.com/sailfishos-patches/patchmanager

coderus 2018-07-11 14:29

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
Quote:

Originally Posted by Markkyboy (Post 1546155)
@coderus

Is this 'categories' list an exhaustive list of Patchmanager categories or are there more?

https://github.com/sailfishos-patches/patchmanager

this readme is outdated... check pm2 submit page

Markkyboy 2018-07-11 15:43

Re: [WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak
 
Quote:

Originally Posted by coderus (Post 1546160)
this readme is outdated... check pm2 submit page

and where might that be?, link please.


All times are GMT. The time now is 18:05.

vBulletin® Version 3.8.8