[WIP] App / Tweak: patchmanager a system-wide patching system + homescreen tweak - Page 254 - maemo.org

olf | # 2531 | 2018-07-02, 20:53 | Report

@Ancelad, I was so happy to see you maintaining the "AlienDalvik runtime indicator" in Ultimate stausbar patch (despite the implementation hurdles your noted) up to version 2.1.3.7-3 (at least on Jolla 1 phones), as it is very useful (for me and others).

But with version 2.2.0.29-1 the "AlienDalvik runtime indicator" (rsp. its setting) is gone (again)!
Was that done deliberately or is it just a bug (maybe in the device detection)?

Is there any chance to bring it back (at least on Jolla 1 phones)?

Side note: If you want me to execute tests for debugging (e.g. obtaining logs, for example from PM3) on Jolla 1 and Xperia X phones, just let me know.

The Following User Says Thank You to olf For This Useful Post:
Amboss

Ancelad | # 2532 | 2018-07-03, 06:37 | Report

@olf
it's still buggy, but there is a chance to do something with PM3 safety mechanism. But I have no time at all.

The Following 4 Users Say Thank You to Ancelad For This Useful Post:
Amboss, cy8aer, imaginaryenemy, suicidal_orange

olf | # 2533 | 2018-07-03, 17:42 | Report

Originally Posted by Ancelad View Post

it's still buggy, but there is a chance to do something with PM3 safety mechanism. But I have no time at all.

Thank you for still considering to fix the "AlienDalvik runtime indicator" in Ultimate statusbar patch someday.

Last edited by olf; 2018-07-03 at 17:56.

The Following User Says Thank You to olf For This Useful Post:
Amboss

Markkyboy | # 2534 | 2018-07-07, 14:10 | Report

Hi all,

I'm attempting to make a patch based on this conversation on together.jolla.com; https://together.jolla.com/question/...post-id-179408 ~ problem is no matter what I do with this file `/usr/share/jolla-email/pages/htmlViewer.css` the finished patch will not apply, all I get is "Failed to apply patch".

When attempting to apply a patch, I get errors found in patchmanager.log, one after another, like;

Code:

patch: **** malformed patch at line "?"

where '?' could be any line number. I've edited just about every line because of this message, but I've a feeling I'm on the road to nowhere. One forum I looked on suggested that spacing was a problem, so I spaced the start of every line of code but still it didn't help.

Is it not possible in general, to patch a .css file?

The Following User Says Thank You to Markkyboy For This Useful Post:
Amboss

coderus | # 2535 | 2018-07-07, 15:00 | Report

how do you create patch? putting random lines together? use git.

The Following User Says Thank You to coderus For This Useful Post:
Amboss

Markkyboy | # 2536 | 2018-07-07, 15:06 | Report

The data is not random. I can add the data manually and I get the effect I want, but if I try to use that same data to patch the file in question, I cannot apply the patch.

I don't know how to use git and haven't needed it so far, I'll look into it.

The rpm patch that won't apply is one I emailed to you earlier; sailfishos-patch-transparent-email-background, install and try to apply, it fails. The patch file is patching 4 different files, but only the htmlViewer.css is causing problems and I don't know how to get round it.

Last edited by Markkyboy; 2018-07-07 at 15:12.

The Following User Says Thank You to Markkyboy For This Useful Post:
Amboss

coderus | # 2537 | 2018-07-07, 15:35 | Report

https://docs.moodle.org/dev/How_to_create_a_patch

The Following User Says Thank You to coderus For This Useful Post:
Amboss

Markkyboy | # 2538 | 2018-07-09, 11:56 | Report

After more rigorous testing, I decided to swap to my other Jolla1 - on which the mail patch works flawlessly (I guess there is something adrift on my 1st Jolla1).

I offer the patch here and on TJC for testing and purposes of feedback. Please report all your findings here on this thread.

It works fine on my second device. It installs/applies/uninstalls without a hitch, the question is, does it do the job it was designed to do?.......I get all kinds of emails and so far, from what I can see, the background stays transparent, making emails much easier on the eyes, especially in the night/first thing in the morning.

PATCH: Transparent email background;

https://www.dropbox.com/s/qcyipsqbus...oarch.rpm?dl=0

Caution: Despite not finding any serious problems by using this patch, you use this file purely at your own risk.

The Following 3 Users Say Thank You to Markkyboy For This Useful Post:
Amboss, imaginaryenemy, pasko

kneeli | # 2539 | 2018-07-09, 15:42 | Report

@Markkyboy

I do prefer to increase the font size for text mail:

/usr/share/jolla-email/pages/PlainTextViewer.qml

from:

Code:

font.pixelSize: Screen.sizeCategory >= Screen.Large ? Theme.fontSizeSmall : Theme.fontSizeExtraSmall

to:

Code:

font.pixelSize: Screen.sizeCategory >= Screen.Large ? Theme.fontSizeMedium : Theme.fontSizeSmall

Some time before, there was one option more in silica webview to change:

/usr/lib/qt5/qml/Sailfish/Silica/SilicaWebView.qml

from:

Code:

color: webView.experimental.transparentBackground ? "transparent" : "white"

to:

Code:

color: webView.experimental.transparentBackground ? "transparent" : "transparent"

but since last update it may not necessary anymore.

I will try you're css file, because mine is very different. I'm exited. Thanks a lot for doing this job done!

I made also some changes on the htmlViewer component, because some emails got rendered totally unreadable, therefore I did the following changes:

/usr/share/jolla-email/pages/HtmlViewer.qml

from:

Code:

 // Respect viewport meta tag if exists
        if (!hasViewportMetaTag(htmlBody)) {
            // This affects only to layouts that do not have width defined in body content.
            // Smaller content layout gets scaled up to WebView's width. Basically meaning that
            // html text emails will get scaled up by factor (1.5*Theme.pixelRatio) rounded to nearest half.
            // With higher scale factor content layouts starts touching edges of WebView and that hinders
            // legibility. Thus, this 1.5 base factor.
            var scale = Math.round((1.5 * Theme.pixelRatio) / .5) * .5
            experimental.customLayoutWidth = width / scale
        } else {
            experimental.customLayoutWidth = width
        }
        // reload html
        loadHtml(htmlBody, "file:///usr/share/jolla-email")
    }

to:

Code:

// Respect viewport meta tag if exists
       //if (!hasViewportMetaTag(htmlBody)) {
            // This affects only to layouts that do not have width defined in body content.
            // Smaller content layout gets scaled up to WebView's width. Basically meaning that
            // html text emails will get scaled up by factor (1.5*Theme.pixelRatio) rounded to nearest half.
            // With higher scale factor content layouts starts touching edges of WebView and that hinders
            // legibility. Thus, this 1.5 base factor.
            //var scale = Math.round((1.5 * Theme.pixelRatio) / .5) * .5
            //experimental.customLayoutWidth = webView.width / scale
        //} else {
            experimental.customLayoutWidth = 350
        //}
        // reload html
        //loadHtml(htmlBody, "file:///usr/share/jolla-email")
        webView.loadHtml(htmlBody, "file:///usr/share/jolla-email")
        onScreen = true
    }

Last edited by kneeli; 2018-07-09 at 15:43. Reason: small changes

The Following User Says Thank You to kneeli For This Useful Post:
Amboss

coderus | # 2540 | 2018-07-09, 15:59 | Report

One big question: why you patch /usr/lib/qt5/qml/Sailfish/Silica/SilicaWebView.qml file???

The Following User Says Thank You to coderus For This Useful Post:
Amboss