Calendar Home Widget replacement - Page 47 - maemo.org

nicolai | # 461 | 2011-04-27, 13:47 | Report

CURRENT_THEME/images/CalendarAppletBackground.png

The Following User Says Thank You to nicolai For This Useful Post:
hawaii

TimusEravan | # 462 | 2011-04-28, 11:22 | Report

I have one feature request : Have an option to show future events only upto some date.
For example, I have set an event for June 20. I can have an setting option to show events only say 20 days in future - so this event will not be shown on the desktop widget till May 30. The number of days in future to be configurable.
Can this be done?
Thanks

Edit: I found the option to do it

Last edited by TimusEravan; 2011-04-28 at 11:31.

The Following User Says Thank You to TimusEravan For This Useful Post:
nicolai

markusm | # 463 | 2011-04-29, 12:18 | Report

I have a strange problem with the widget - all the events are shown as starting 1 hour earlier than they are actually set in the calendar. Any fix for it?

Maybe this has been asked and answered before but I couldn't find it. I'd appreciate any help and tips.

Thanks!

stlpaul | # 464 | 2011-04-29, 20:17 | Report

Originally Posted by nicolai View Post

That is really strange. I had so many bugs with wrong time offset, which
I got fixed only by using the TZ and TZ-offset.

I am afraid I can not simply remove this time offset from the timezone,
as in other cases the time offset may be wrong again.

Nicolai

(disclaimer: I didn't look at the code

)

If you're using TZ/TZ-Offset of the event, I think that's the cause of the problems.

You can reproduce the error without MfE as well:

I set time zone to to America/Chicago. (GMT -5)
Create new event for 5:00
Cal-Home widget shows event at 5:00
Change time zone to America/New_York (GMT -4)
Cal-Home widget still shows event at 5:00, but it should be 6:00

(you can use any time zones as long as they differ)

The UTC timestamp in the calendar database is correct in every case.

I think using the TZ/TZ-Offset of the event is fundamentally the wrong thing to do. The event does not necessarily happen in the same TZ the N900 exists in. For example, if I live in New York and I get an meeting request from someone in Tokyo, I don't want to see Tokyo local time, I want to see New York time. Or if I am traveling, I want my times to reflect the time zone where I am presently located, not the time zone I was in when the calendar entry was created.

I think you should read time zone of the N900 and compute the offset from UTC start and end times based on that. TZ of the event itself is irrelevant. In my opinion.

Forgive me if I misunderstood or made false assumptions about how it is calculated. I'm only trying to help. Thanks.

The Following 2 Users Say Thank You to stlpaul For This Useful Post:
nicolai

nicolai | # 465 | 2011-05-01, 12:18 | Report

Originally Posted by stlpaul View Post

I think using the TZ/TZ-Offset of the event is fundamentally the wrong thing to do. The event does not necessarily happen in the same TZ the N900 exists in. For example, if I live in New York and I get an meeting request from someone in Tokyo, I don't want to see Tokyo local time, I want to see New York time. Or if I am traveling, I want my times to reflect the time zone where I am presently located, not the time zone I was in when the calendar entry was created.

I think you should read time zone of the N900 and compute the offset from UTC start and end times based on that. TZ of the event itself is irrelevant. In my opinion.

Yes, but I had this timezone bugs with allday and birthdays
events (and todos maybe).

Now I changed it again. All times are in localtime again,
besided allday events, birhtdays and todos.

Please test and report back when it is still (or again) wrong.

Nicolai

The Following 3 Users Say Thank You to nicolai For This Useful Post:
OVK, reinob, stlpaul

JensU | # 466 | 2011-05-01, 13:19 | Report

if i change the time zone to a different one all displayed times remain the same.
my guess is that the difference between event time offset and current system time offset is missing.

nicolai, i've seen in the code you've removed the relevant part with getSystemTimeShift()? imo the calculation (time = eventTimeOffset - systemTimeOffset) there doesn't look bad

didn't it work?

best
jens

EDIT: didn't read you last post nicolai, took me too long to write this one (my little daugther demanded some attantion

, i'll give it a try asap

Last edited by JensU; 2011-05-01 at 13:22.

stlpaul | # 467 | 2011-05-01, 21:54 | Report

Originally Posted by nicolai View Post

Now I changed it again. All times are in localtime again,
besided allday events, birhtdays and todos.

Please test and report back when it is still (or again) wrong.

Hi Nicolai,

Now I'm using the new version and so far everything looks correct to me. Thanks for the quick work

The Following User Says Thank You to stlpaul For This Useful Post:
nicolai

JensU | # 468 | 2011-05-02, 06:24 | Report

hi,

i can confirm it too, works as expected.
thanks nicolai!

cheers
jens

JensU | # 469 | 2011-05-02, 07:32 | Report

i've found one small issue.
when the time of an event has arrived and you change the time zone it will disappear even your are stil between start and end time.
e.g. at "BERLIN GTM+2" an event at 9:00 is scheduled. if i change the TZ to "MOSKOW GTM+4", the even will disapear at 11:00, in "GTM+2" i will still be visible till 10:00.
the times are displayed correct at any time and TZ, so it seems only to be the condition for "now" events ( event_end_time could be the problem, as it's not handled like the event_start_time )

cheers
jens

Last edited by JensU; 2011-05-02 at 07:35.

The Following User Says Thank You to For This Useful Post:
nicolai

nicolai | # 470 | 2011-05-02, 08:04 | Report

Yes you are right.
I remember, while testing, something like "don't forget the end time" came to mind :-)

The Following User Says Thank You to nicolai For This Useful Post:
stlpaul