Notices


Reply
Thread Tools
Posts: 1,100 | Thanked: 2,797 times | Joined on Apr 2011 @ Netherlands
#291
The replacement clock has its own wiki page: http://wiki.maemo.org/Clock_replacement

For now it is mainly focusing on the differences between the stock- and replacement clock.
 

The Following 8 Users Say Thank You to ade For This Useful Post:
Posts: 838 | Thanked: 3,384 times | Joined on Mar 2009
#292
Without looking code, I can claim there are some 'new' without 'delete' (not critical, but reminding you about valgrind).

Against: 7f4dc197eb371f0550fa964445781f41fab7cc37
Code:
==6037==    at 0x4832090: operator new(unsigned int) (vg_replace_malloc.c:255)
==6037==    by 0x397DF: World::getAMPM() (world.cpp:138)
==6037==    by 0x3A957: World::loadCurrent() (world.cpp:245)
==6037==    by 0x3D227: World::World(QWidget*) (world.cpp:75)
==6037==    by 0x17797: MainWindow::MainWindow(QWidget*) (mainwindow.cpp:169)
==6037==    by 0x135A7: main (main.cpp:51)

==6037==    at 0x4832090: operator new(unsigned int) (vg_replace_malloc.c:255)
==6037==    by 0x3A977: World::loadCurrent() (world.cpp:247)
==6037==    by 0x3D227: World::World(QWidget*) (world.cpp:75)
==6037==    by 0x17797: MainWindow::MainWindow(QWidget*) (mainwindow.cpp:169)
==6037==    by 0x135A7: main (main.cpp:51)

==6037==    at 0x4832090: operator new(unsigned int) (vg_replace_malloc.c:255)
==6037==    by 0x14DDB: MainWindow::getAMPM() (mainwindow.cpp:201)
==6037==    by 0x177CF: MainWindow::MainWindow(QWidget*) (mainwindow.cpp:173)
==6037==    by 0x135A7: main (main.cpp:51)

I suggest to drop generated file(s) from git, i.e. Makefile (generated by qmake + Alarm.pro)


On git: chmod a-x Alarm.pro *.ui
 

The Following 5 Users Say Thank You to AapoRantalainen For This Useful Post:
Posts: 1,100 | Thanked: 2,797 times | Joined on Apr 2011 @ Netherlands
#293
You could very well be right about the missing deletes. I will check the code for that.

I am not sure if we can remove the *.ui files from git, as they represent the layout. Afaik they are created by Qt Creator and not generated by something else.

edit: added some deletes in the code and updated the executables. I am not sure if all reports are valid (for example the one in main.cpp and mainwindow.cpp:169). Delete ww (from line 169) in mainwindow.cpp would lead to a segfault. But I am not a C++ expert, so I may try to delete it in the wrong location

Last edited by ade; 2012-09-07 at 12:45.
 

The Following User Says Thank You to ade For This Useful Post:
Posts: 1,100 | Thanked: 2,797 times | Joined on Apr 2011 @ Netherlands
#294
Did some experimenting with GCC 4.7.2. and thumb2 for the replacement clock.

Results are as follows:

Code:
GCC version    thumb  size worldclock   worldclock-with-date
4.2.1          no         422712             476040     
4.7.2          no         278636             309779
4.7.2          yes        225292             246364
(files are stripped, size in bytes)

It shows the thumb versions are almost half the size, but even without thumb, files are smaller with 4.7.2 (experienced the same with other programs compiled).
Speed gain will not really be noticable for this program, but Freemangordon has posted some nice results in the thumb kernel thread.

For those why want to try the thumb2 version and have a thumb2 supported kernel: download is in the opening post.
 

The Following 7 Users Say Thank You to ade For This Useful Post:
Estel's Avatar
Posts: 5,028 | Thanked: 8,613 times | Joined on Mar 2011
#295
Yay, thumb2 compiled ade's worldclock! Thanks a lot!

As thumb repos are separate one (kinda CSSU fork, although it's author hate such naming ), maybe You could send it to freemangordon as package, just the way like busybox-power does it, for thumb? It should be compatibles with Your plans re clock replacement and "basic" CSSU.

/Estel
__________________
N900's aluminum backcover / body replacement
-
N900's HDMI-Out
-
Camera cover MOD
-
Measure battery's real capacity on-device
-
TrueCrypt 7.1 | ereswap | bnf
-
Hardware's mods research is costly. To support my work, please consider donating. Thank You!
 

The Following 2 Users Say Thank You to Estel For This Useful Post:
Posts: 1,100 | Thanked: 2,797 times | Joined on Apr 2011 @ Netherlands
#296
Originally Posted by Estel View Post
Yay, thumb2 compiled ade's worldclock! Thanks a lot!

As thumb repos are separate one (kinda CSSU fork, although it's author hate such naming ), maybe You could send it to freemangordon as package, just the way like busybox-power does it, for thumb? It should be compatibles with Your plans re clock replacement and "basic" CSSU.

/Estel
I would not mind if it appeared in the thumb repos first. But in the end, it is Merlin1991 that could/would do the next (packaging) step, not Freemangordon or some personal packaging attempt from myself (which can be seen as non CSSU compliant). If someone wants to poke Merlin1991 for that as a reminder, be my guest.
 

The Following 2 Users Say Thank You to ade For This Useful Post:
Posts: 424 | Thanked: 196 times | Joined on Mar 2010 @ Sweden
#297
Hello.

I dont know if enyone else have experienced this behavor.
Anyway, lets say you create a new alarm occasion 07:30 named Regular Workday (name isnt nessesary).
Activate your alarm and at 07:30 the alarm awakes you but you want to snooze so you hit the snooze. And when the alarm awakes you again 10 later you hit stop. Now, if you look at you saved alarm called Regular Workday, the alarm-time have been changed to 07:40.
Is it supposed to be like this?
 

The Following 4 Users Say Thank You to toxaris For This Useful Post:
Estel's Avatar
Posts: 5,028 | Thanked: 8,613 times | Joined on Mar 2011
#298
Good catch. Doesn't look very convenient, so I suppose it's a glitch, not feature
__________________
N900's aluminum backcover / body replacement
-
N900's HDMI-Out
-
Camera cover MOD
-
Measure battery's real capacity on-device
-
TrueCrypt 7.1 | ereswap | bnf
-
Hardware's mods research is costly. To support my work, please consider donating. Thank You!
 

The Following User Says Thank You to Estel For This Useful Post:
Posts: 2,102 | Thanked: 1,937 times | Joined on Sep 2008 @ Berlin, Germany
#299
Face it, that is the AI, social engineering and behavioral computing at work!
Good job,@ade!
 

The Following 2 Users Say Thank You to michaaa62 For This Useful Post:
Posts: 1,100 | Thanked: 2,797 times | Joined on Apr 2011 @ Netherlands
#300
Originally Posted by toxaris View Post
Hello.

I dont know if enyone else have experienced this behavor.
Anyway, lets say you create a new alarm occasion 07:30 named Regular Workday (name isnt nessesary).
Activate your alarm and at 07:30 the alarm awakes you but you want to snooze so you hit the snooze. And when the alarm awakes you again 10 later you hit stop. Now, if you look at you saved alarm called Regular Workday, the alarm-time have been changed to 07:40.
Is it supposed to be like this?
No, this is not how it supposed to work, and it has not worked like this. Must be some stupid regression I introduced in a later version, although I have not made specific changes to this part.

I will try to fix it this evening (local time).
 

The Following 6 Users Say Thank You to ade For This Useful Post:
Reply

Tags
clock-ui, replacement, worldclock


 
Forum Jump


All times are GMT. The time now is 20:50.